You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Justin Erenkrantz <je...@ebuilt.com> on 2002/01/09 08:52:31 UTC
[PATCH] Fix oversight in Makefile
I'm assuming that this is an oversight. But, on the off chance
that it isn't, I'll post to the list before committing.
I need to add the runtime-linking flags for my Linux and Solaris
builds - no go without this. -- justin
Makefile.in: Allow LDFLAGS to be substituted from configure.
Index: ./Makefile.in
===================================================================
--- ./Makefile.in
+++ ./Makefile.in Wed Jan 9 00:46:03 2002
@@ -60,7 +60,7 @@
CFLAGS = @CFLAGS@
CPPFLAGS = @CPPFLAGS@
-LDFLAGS =
+LDFLAGS = @LDFLAGS@
COMPILE = $(CC) $(CPPFLAGS) $(CFLAGS) $(INCLUDES)
LT_COMPILE = $(LIBTOOL) $(LTFLAGS) --mode=compile $(COMPILE) -o $@ -c $<
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Fix oversight in Makefile
Posted by Karl Fogel <kf...@newton.ch.collab.net>.
Justin Erenkrantz <je...@ebuilt.com> writes:
> I'm assuming that this is an oversight. But, on the off chance
> that it isn't, I'll post to the list before committing.
>
> I need to add the runtime-linking flags for my Linux and Solaris
> builds - no go without this. -- justin
Your change makes sense to me, and is in lots of other `Makefile.in's.
I say go for it, just test a couple of builds with and without your
extra flags to make sure.
-K
> Makefile.in: Allow LDFLAGS to be substituted from configure.
>
> Index: ./Makefile.in
> ===================================================================
> --- ./Makefile.in
> +++ ./Makefile.in Wed Jan 9 00:46:03 2002
> @@ -60,7 +60,7 @@
>
> CFLAGS = @CFLAGS@
> CPPFLAGS = @CPPFLAGS@
> -LDFLAGS =
> +LDFLAGS = @LDFLAGS@
>
> COMPILE = $(CC) $(CPPFLAGS) $(CFLAGS) $(INCLUDES)
> LT_COMPILE = $(LIBTOOL) $(LTFLAGS) --mode=compile $(COMPILE) -o $@ -c $<
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Fix oversight in Makefile
Posted by Greg Stein <gs...@lyra.org>.
On Wed, Jan 09, 2002 at 12:52:31AM -0800, Justin Erenkrantz wrote:
> I'm assuming that this is an oversight. But, on the off chance
> that it isn't, I'll post to the list before committing.
>
> I need to add the runtime-linking flags for my Linux and Solaris
> builds - no go without this. -- justin
>
> Makefile.in: Allow LDFLAGS to be substituted from configure.
Just an oversight. We didn't really have any LDFLAGS, primarily because all
the linking was being done by libtool (and nobody found a borken case).
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org