You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/05/03 23:32:19 UTC
[GitHub] [hive] mustafaiman opened a new pull request #2242: HIVE-21935: Hive Vectorization : degraded performance with vectorize UDF
mustafaiman opened a new pull request #2242:
URL: https://github.com/apache/hive/pull/2242
Change-Id: I5fad847456d8c3319ea07cfe114007ed01b54bbe
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] abstractdog commented on pull request #2242: HIVE-21935: Hive Vectorization : degraded performance with vectorize UDF
Posted by GitBox <gi...@apache.org>.
abstractdog commented on pull request #2242:
URL: https://github.com/apache/hive/pull/2242#issuecomment-838819612
the change makes sense to me, could you confirm that this use-case is covered by a q.test?
I was looking for qtests, I found similar ones but only with struct type (StructColumnVector, which doesn’t inherit MultiValuedColumnVector)
e.g.:
schema_evol_text_vecrow_part_all_complex.q
I think q.test for this use should have the following properties:
1. use text format file for reading
2. force vector/row serde deserialize:
```
SET hive.vectorized.use.vectorized.input.format=false;
SET hive.vectorized.use.vector.serde.deserialize=true;
SET hive.vectorized.use.row.serde.deserialize=true;
```
3. use map/list type
4. work on small batches or a large amount of rows <1024 (to force batch reuse = reuse of deserializerBatch)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] abstractdog commented on pull request #2242: HIVE-21935: Hive Vectorization : degraded performance with vectorize UDF
Posted by GitBox <gi...@apache.org>.
abstractdog commented on pull request #2242:
URL: https://github.com/apache/hive/pull/2242#issuecomment-842075237
> @abstractdog @rbalamohan are you ok with the latest patch?
> @abstractdog @rbalamohan are you ok with the latest patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] rbalamohan commented on a change in pull request #2242: HIVE-21935: Hive Vectorization : degraded performance with vectorize UDF
Posted by GitBox <gi...@apache.org>.
rbalamohan commented on a change in pull request #2242:
URL: https://github.com/apache/hive/pull/2242#discussion_r629967730
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorMapOperator.java
##########
@@ -885,20 +885,7 @@ public void process(Writable value) throws HiveException {
batchCounter++;
oneRootOperator.process(deserializerBatch, 0);
- /**
- * Only reset the current data columns. Not any data columns defaulted to NULL
- * because they are not present in the partition, and not partition columns.
- */
- for (int c = 0; c < currentDataColumnCount; c++) {
- ColumnVector colVector = deserializerBatch.cols[c];
- if (colVector != null) {
- colVector.reset();
- colVector.init();
- }
- }
- deserializerBatch.selectedInUse = false;
- deserializerBatch.size = 0;
- deserializerBatch.endOfFile = false;
+ deserializerBatch.reset();
Review comment:
After reset, can you reinit isNull and isRepeating for columns which are not present in currentDataColumnCount?
(i.e similar to the case mentioned in https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorMapOperator.java#L706)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] mustafaiman closed pull request #2242: HIVE-21935: Hive Vectorization : degraded performance with vectorize UDF
Posted by GitBox <gi...@apache.org>.
mustafaiman closed pull request #2242:
URL: https://github.com/apache/hive/pull/2242
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] mustafaiman commented on pull request #2242: HIVE-21935: Hive Vectorization : degraded performance with vectorize UDF
Posted by GitBox <gi...@apache.org>.
mustafaiman commented on pull request #2242:
URL: https://github.com/apache/hive/pull/2242#issuecomment-841363674
@abstractdog @rbalamohan are you ok with the latest patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] abstractdog removed a comment on pull request #2242: HIVE-21935: Hive Vectorization : degraded performance with vectorize UDF
Posted by GitBox <gi...@apache.org>.
abstractdog removed a comment on pull request #2242:
URL: https://github.com/apache/hive/pull/2242#issuecomment-842075237
> @abstractdog @rbalamohan are you ok with the latest patch?
> @abstractdog @rbalamohan are you ok with the latest patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] abstractdog removed a comment on pull request #2242: HIVE-21935: Hive Vectorization : degraded performance with vectorize UDF
Posted by GitBox <gi...@apache.org>.
abstractdog removed a comment on pull request #2242:
URL: https://github.com/apache/hive/pull/2242#issuecomment-842075237
> @abstractdog @rbalamohan are you ok with the latest patch?
> @abstractdog @rbalamohan are you ok with the latest patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] mustafaiman commented on a change in pull request #2242: HIVE-21935: Hive Vectorization : degraded performance with vectorize UDF
Posted by GitBox <gi...@apache.org>.
mustafaiman commented on a change in pull request #2242:
URL: https://github.com/apache/hive/pull/2242#discussion_r630604192
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorMapOperator.java
##########
@@ -885,20 +885,7 @@ public void process(Writable value) throws HiveException {
batchCounter++;
oneRootOperator.process(deserializerBatch, 0);
- /**
- * Only reset the current data columns. Not any data columns defaulted to NULL
- * because they are not present in the partition, and not partition columns.
- */
- for (int c = 0; c < currentDataColumnCount; c++) {
- ColumnVector colVector = deserializerBatch.cols[c];
- if (colVector != null) {
- colVector.reset();
- colVector.init();
- }
- }
- deserializerBatch.selectedInUse = false;
- deserializerBatch.size = 0;
- deserializerBatch.endOfFile = false;
+ deserializerBatch.reset();
Review comment:
I excluded partition column and rowidentifiercolumn from reset. So this is more like the original code now. It only resets the output columns in addition to original implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] abstractdog commented on pull request #2242: HIVE-21935: Hive Vectorization : degraded performance with vectorize UDF
Posted by GitBox <gi...@apache.org>.
abstractdog commented on pull request #2242:
URL: https://github.com/apache/hive/pull/2242#issuecomment-842075237
> @abstractdog @rbalamohan are you ok with the latest patch?
> @abstractdog @rbalamohan are you ok with the latest patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org