You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by dpkp <gi...@git.apache.org> on 2016/05/09 01:59:11 UTC

[GitHub] kafka pull request: Fixup KAFKA-3160: catch decompression errors i...

GitHub user dpkp opened a pull request:

    https://github.com/apache/kafka/pull/1344

    Fixup KAFKA-3160: catch decompression errors in constructor

    After testing KAFKA-3160 a bit more, I found that the error code was not being set properly in ProduceResponse. This happened because the validation error is raised in the CompressionFactory constructor, which was not wrapped in a try / catch.
    
    @ijuma @junrao 
    
    (This contribution is my original work and I license the work under Apache 2.0.)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dpkp/kafka decompress_error_code

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/1344.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1344
    
----
commit bac92e133cb80aa13ee155a1200bf085947376b7
Author: Dana Powers <da...@gmail.com>
Date:   2016-05-09T01:54:22Z

    Fixup to KAFKA-3160: catch decompression errors in constructor; return CorruptMessageError

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request: Fixup KAFKA-3160: catch decompression errors i...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/kafka/pull/1344


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---