You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/07/03 03:29:42 UTC

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25013: [SPARK-28077][SQL][FOLLOW-UP] Add overlay and placing to TableIdentifierParserSuite

dongjoon-hyun commented on a change in pull request #25013: [SPARK-28077][SQL][FOLLOW-UP] Add overlay and placing to TableIdentifierParserSuite
URL: https://github.com/apache/spark/pull/25013#discussion_r299764068
 
 

 ##########
 File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
 ##########
 @@ -1011,6 +1011,7 @@ ansiNonReserved
     | PARTITIONS
     | PERCENTLIT
     | PIVOT
+    | PLACING
 
 Review comment:
   This describes this parser change, too. This is more important change than a test suite change.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org