You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/10/10 22:41:25 UTC
[GitHub] [incubator-gobblin] sv2000 opened a new pull request #3123: GOBBLIN-1284: Fix flaky tests causing local build failures
sv2000 opened a new pull request #3123:
URL: https://github.com/apache/incubator-gobblin/pull/3123
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1284
### Description
- [x] Here are some details about my PR, including screenshots (if applicable):
On local build, we see intermittent failures in the following test classes:
RateControlledFileSystemTest
HiveSourceTest
HighLevelConsumerTest
The test failures happen due to a combination of reasons:
Failure to clean up files/directories (HiveSourceTest)
Inadequate number of iterations resulting in sample mean not converging (RateControlledFileSystemTest), and
Timeout exceptions (HighLevelConsumerTest)
This task attempts to fix the flakiness in these test classes.
The build.gradle has been modified to add gpg to rat exclusion.
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] abti commented on pull request #3123: GOBBLIN-1284: Fix flaky tests causing local build failures
Posted by GitBox <gi...@apache.org>.
abti commented on pull request #3123:
URL: https://github.com/apache/incubator-gobblin/pull/3123#issuecomment-707451563
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] codecov-io edited a comment on pull request #3123: GOBBLIN-1284: Fix flaky tests causing local build failures
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #3123:
URL: https://github.com/apache/incubator-gobblin/pull/3123#issuecomment-706626746
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3123?src=pr&el=h1) Report
> Merging [#3123](https://codecov.io/gh/apache/incubator-gobblin/pull/3123?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/52cefe6339182e3f78e93e3913ebd946c7a57512?el=desc) will **decrease** coverage by `0.00%`.
> The diff coverage is `65.38%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/3123?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3123 +/- ##
============================================
- Coverage 46.02% 46.01% -0.01%
+ Complexity 9582 9580 -2
============================================
Files 1986 1986
Lines 75796 75809 +13
Branches 8445 8446 +1
============================================
+ Hits 34884 34886 +2
- Misses 37635 37643 +8
- Partials 3277 3280 +3
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/3123?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...a/org/apache/gobblin/service/FlowConfigClient.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi1mbG93LWNvbmZpZy1zZXJ2aWNlL2dvYmJsaW4tZmxvdy1jb25maWctc2VydmljZS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9GbG93Q29uZmlnQ2xpZW50LmphdmE=) | `71.66% <0.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...apache/gobblin/kafka/writer/Kafka09DataWriter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtMDkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4va2Fma2Evd3JpdGVyL0thZmthMDlEYXRhV3JpdGVyLmphdmE=) | `72.30% <65.21%> (-2.27%)` | `10.00 <0.00> (ø)` | |
| [...lin/kafka/writer/KafkaWriterConfigurationKeys.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2thZmthL3dyaXRlci9LYWZrYVdyaXRlckNvbmZpZ3VyYXRpb25LZXlzLmphdmE=) | `75.00% <100.00%> (+8.33%)` | `1.00 <0.00> (ø)` | |
| [...org/apache/gobblin/service/FlowConfigV2Client.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi1mbG93LWNvbmZpZy1zZXJ2aWNlL2dvYmJsaW4tZmxvdy1jb25maWctc2VydmljZS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9GbG93Q29uZmlnVjJDbGllbnQuamF2YQ==) | `58.88% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...a/org/apache/gobblin/util/limiter/NoopLimiter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvbGltaXRlci9Ob29wTGltaXRlci5qYXZh) | `40.00% <0.00%> (-20.00%)` | `2.00% <0.00%> (-1.00%)` | |
| [...lin/util/filesystem/FileSystemInstrumentation.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsZXN5c3RlbS9GaWxlU3lzdGVtSW5zdHJ1bWVudGF0aW9uLmphdmE=) | `92.85% <0.00%> (-7.15%)` | `3.00% <0.00%> (-1.00%)` | |
| [.../org/apache/gobblin/metrics/RootMetricContext.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9Sb290TWV0cmljQ29udGV4dC5qYXZh) | `73.43% <0.00%> (-6.25%)` | `15.00% <0.00%> (-1.00%)` | |
| [...in/java/org/apache/gobblin/cluster/HelixUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhVdGlscy5qYXZh) | `38.01% <0.00%> (-2.48%)` | `14.00% <0.00%> (ø%)` | |
| [...n/java/org/apache/gobblin/util/PullFileLoader.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvUHVsbEZpbGVMb2FkZXIuamF2YQ==) | `73.88% <0.00%> (-0.34%)` | `26.00% <0.00%> (+1.00%)` | :arrow_down: |
| [.../org/apache/gobblin/cluster/GobblinTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpblRhc2tSdW5uZXIuamF2YQ==) | `63.78% <0.00%> (+0.32%)` | `35.00% <0.00%> (ø%)` | |
| ... and [1 more](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3123?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3123?src=pr&el=footer). Last update [52cefe6...24eec5b](https://codecov.io/gh/apache/incubator-gobblin/pull/3123?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] codecov-io edited a comment on pull request #3123: GOBBLIN-1284: Fix flaky tests causing local build failures
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #3123:
URL: https://github.com/apache/incubator-gobblin/pull/3123#issuecomment-706626746
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3123?src=pr&el=h1) Report
> Merging [#3123](https://codecov.io/gh/apache/incubator-gobblin/pull/3123?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/52cefe6339182e3f78e93e3913ebd946c7a57512?el=desc) will **decrease** coverage by `0.00%`.
> The diff coverage is `66.66%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/3123?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3123 +/- ##
============================================
- Coverage 46.02% 46.02% -0.01%
- Complexity 9582 9583 +1
============================================
Files 1986 1986
Lines 75796 75809 +13
Branches 8445 8446 +1
============================================
+ Hits 34884 34889 +5
- Misses 37635 37641 +6
- Partials 3277 3279 +2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/3123?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/gobblin/kafka/writer/Kafka09DataWriter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtMDkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4va2Fma2Evd3JpdGVyL0thZmthMDlEYXRhV3JpdGVyLmphdmE=) | `72.30% <65.21%> (-2.27%)` | `10.00 <0.00> (ø)` | |
| [...lin/kafka/writer/KafkaWriterConfigurationKeys.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2thZmthL3dyaXRlci9LYWZrYVdyaXRlckNvbmZpZ3VyYXRpb25LZXlzLmphdmE=) | `75.00% <100.00%> (+8.33%)` | `1.00 <0.00> (ø)` | |
| [...in/java/org/apache/gobblin/cluster/HelixUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhVdGlscy5qYXZh) | `38.01% <0.00%> (-2.48%)` | `14.00% <0.00%> (ø%)` | |
| [...n/java/org/apache/gobblin/util/PullFileLoader.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvUHVsbEZpbGVMb2FkZXIuamF2YQ==) | `73.88% <0.00%> (-0.34%)` | `26.00% <0.00%> (+1.00%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3123?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3123?src=pr&el=footer). Last update [52cefe6...155c3a9](https://codecov.io/gh/apache/incubator-gobblin/pull/3123?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] codecov-io edited a comment on pull request #3123: GOBBLIN-1284: Fix flaky tests causing local build failures
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #3123:
URL: https://github.com/apache/incubator-gobblin/pull/3123#issuecomment-706626746
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3123?src=pr&el=h1) Report
> Merging [#3123](https://codecov.io/gh/apache/incubator-gobblin/pull/3123?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/52cefe6339182e3f78e93e3913ebd946c7a57512?el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `65.38%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/3123?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3123 +/- ##
============================================
- Coverage 46.02% 46.01% -0.02%
+ Complexity 9582 9580 -2
============================================
Files 1986 1986
Lines 75796 75809 +13
Branches 8445 8446 +1
============================================
- Hits 34884 34880 -4
- Misses 37635 37646 +11
- Partials 3277 3283 +6
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/3123?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...a/org/apache/gobblin/service/FlowConfigClient.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi1mbG93LWNvbmZpZy1zZXJ2aWNlL2dvYmJsaW4tZmxvdy1jb25maWctc2VydmljZS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9GbG93Q29uZmlnQ2xpZW50LmphdmE=) | `71.66% <0.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...apache/gobblin/kafka/writer/Kafka09DataWriter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtMDkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4va2Fma2Evd3JpdGVyL0thZmthMDlEYXRhV3JpdGVyLmphdmE=) | `72.30% <65.21%> (-2.27%)` | `10.00 <0.00> (ø)` | |
| [...lin/kafka/writer/KafkaWriterConfigurationKeys.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2thZmthL3dyaXRlci9LYWZrYVdyaXRlckNvbmZpZ3VyYXRpb25LZXlzLmphdmE=) | `75.00% <100.00%> (+8.33%)` | `1.00 <0.00> (ø)` | |
| [...org/apache/gobblin/service/FlowConfigV2Client.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi1mbG93LWNvbmZpZy1zZXJ2aWNlL2dvYmJsaW4tZmxvdy1jb25maWctc2VydmljZS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9GbG93Q29uZmlnVjJDbGllbnQuamF2YQ==) | `58.88% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...a/org/apache/gobblin/util/limiter/NoopLimiter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvbGltaXRlci9Ob29wTGltaXRlci5qYXZh) | `40.00% <0.00%> (-20.00%)` | `2.00% <0.00%> (-1.00%)` | |
| [...lin/util/filesystem/FileSystemInstrumentation.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsZXN5c3RlbS9GaWxlU3lzdGVtSW5zdHJ1bWVudGF0aW9uLmphdmE=) | `85.71% <0.00%> (-14.29%)` | `3.00% <0.00%> (-1.00%)` | |
| [...e/gobblin/runtime/locks/ZookeeperBasedJobLock.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbG9ja3MvWm9va2VlcGVyQmFzZWRKb2JMb2NrLmphdmE=) | `58.88% <0.00%> (-5.56%)` | `16.00% <0.00%> (ø%)` | |
| [...in/java/org/apache/gobblin/cluster/HelixUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhVdGlscy5qYXZh) | `38.01% <0.00%> (-2.48%)` | `14.00% <0.00%> (ø%)` | |
| [...lin/elasticsearch/writer/FutureCallbackHolder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tZWxhc3RpY3NlYXJjaC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9lbGFzdGljc2VhcmNoL3dyaXRlci9GdXR1cmVDYWxsYmFja0hvbGRlci5qYXZh) | `61.42% <0.00%> (-1.43%)` | `4.00% <0.00%> (ø%)` | |
| [...a/management/copy/publisher/CopyDataPublisher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvcHkvcHVibGlzaGVyL0NvcHlEYXRhUHVibGlzaGVyLmphdmE=) | `74.00% <0.00%> (-1.34%)` | `31.00% <0.00%> (-1.00%)` | |
| ... and [2 more](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3123?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3123?src=pr&el=footer). Last update [52cefe6...314671a](https://codecov.io/gh/apache/incubator-gobblin/pull/3123?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] codecov-io commented on pull request #3123: GOBBLIN-1284: Fix flaky tests causing local build failures
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #3123:
URL: https://github.com/apache/incubator-gobblin/pull/3123#issuecomment-706626746
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3123?src=pr&el=h1) Report
> Merging [#3123](https://codecov.io/gh/apache/incubator-gobblin/pull/3123?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/52cefe6339182e3f78e93e3913ebd946c7a57512?el=desc) will **decrease** coverage by `0.00%`.
> The diff coverage is `66.66%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/3123?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3123 +/- ##
============================================
- Coverage 46.02% 46.02% -0.01%
- Complexity 9582 9583 +1
============================================
Files 1986 1986
Lines 75796 75809 +13
Branches 8445 8446 +1
============================================
+ Hits 34884 34889 +5
- Misses 37635 37641 +6
- Partials 3277 3279 +2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/3123?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/gobblin/kafka/writer/Kafka09DataWriter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtMDkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4va2Fma2Evd3JpdGVyL0thZmthMDlEYXRhV3JpdGVyLmphdmE=) | `72.30% <65.21%> (-2.27%)` | `10.00 <0.00> (ø)` | |
| [...lin/kafka/writer/KafkaWriterConfigurationKeys.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2thZmthL3dyaXRlci9LYWZrYVdyaXRlckNvbmZpZ3VyYXRpb25LZXlzLmphdmE=) | `75.00% <100.00%> (+8.33%)` | `1.00 <0.00> (ø)` | |
| [...in/java/org/apache/gobblin/cluster/HelixUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhVdGlscy5qYXZh) | `38.01% <0.00%> (-2.48%)` | `14.00% <0.00%> (ø%)` | |
| [...n/java/org/apache/gobblin/util/PullFileLoader.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvUHVsbEZpbGVMb2FkZXIuamF2YQ==) | `73.88% <0.00%> (-0.34%)` | `26.00% <0.00%> (+1.00%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3123?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3123?src=pr&el=footer). Last update [52cefe6...155c3a9](https://codecov.io/gh/apache/incubator-gobblin/pull/3123?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] codecov-io edited a comment on pull request #3123: GOBBLIN-1284: Fix flaky tests causing local build failures
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #3123:
URL: https://github.com/apache/incubator-gobblin/pull/3123#issuecomment-706626746
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3123?src=pr&el=h1) Report
> Merging [#3123](https://codecov.io/gh/apache/incubator-gobblin/pull/3123?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/52cefe6339182e3f78e93e3913ebd946c7a57512?el=desc) will **decrease** coverage by `36.75%`.
> The diff coverage is `1.88%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/3123?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3123 +/- ##
============================================
- Coverage 46.02% 9.26% -36.76%
+ Complexity 9582 1724 -7858
============================================
Files 1986 1986
Lines 75796 75809 +13
Branches 8445 8446 +1
============================================
- Hits 34884 7023 -27861
- Misses 37635 68103 +30468
+ Partials 3277 683 -2594
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/3123?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/gobblin/kafka/writer/Kafka09DataWriter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtMDkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4va2Fma2Evd3JpdGVyL0thZmthMDlEYXRhV3JpdGVyLmphdmE=) | `0.00% <0.00%> (-74.58%)` | `0.00 <0.00> (-10.00)` | |
| [...lin/kafka/writer/KafkaWriterConfigurationKeys.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2thZmthL3dyaXRlci9LYWZrYVdyaXRlckNvbmZpZ3VyYXRpb25LZXlzLmphdmE=) | `0.00% <0.00%> (-66.67%)` | `0.00 <0.00> (-1.00)` | |
| [...a/org/apache/gobblin/service/FlowConfigClient.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi1mbG93LWNvbmZpZy1zZXJ2aWNlL2dvYmJsaW4tZmxvdy1jb25maWctc2VydmljZS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9GbG93Q29uZmlnQ2xpZW50LmphdmE=) | `0.00% <0.00%> (-71.67%)` | `0.00 <0.00> (-8.00)` | |
| [...org/apache/gobblin/service/FlowConfigV2Client.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi1mbG93LWNvbmZpZy1zZXJ2aWNlL2dvYmJsaW4tZmxvdy1jb25maWctc2VydmljZS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9GbG93Q29uZmlnVjJDbGllbnQuamF2YQ==) | `0.00% <0.00%> (-58.89%)` | `0.00 <0.00> (-10.00)` | |
| [...n/java/org/apache/gobblin/util/PullFileLoader.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvUHVsbEZpbGVMb2FkZXIuamF2YQ==) | `17.91% <3.70%> (-56.31%)` | `2.00 <0.00> (-23.00)` | |
| [...c/main/java/org/apache/gobblin/util/FileUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvRmlsZVV0aWxzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...n/java/org/apache/gobblin/fork/CopyableSchema.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2ZvcmsvQ29weWFibGVTY2hlbWEuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...java/org/apache/gobblin/stream/ControlMessage.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc3RyZWFtL0NvbnRyb2xNZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...va/org/apache/gobblin/dataset/DatasetResolver.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YXNldC9EYXRhc2V0UmVzb2x2ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...va/org/apache/gobblin/converter/EmptyIterable.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbnZlcnRlci9FbXB0eUl0ZXJhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1052 more](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3123?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3123?src=pr&el=footer). Last update [52cefe6...362a885](https://codecov.io/gh/apache/incubator-gobblin/pull/3123?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] asfgit closed pull request #3123: GOBBLIN-1284: Fix flaky tests causing local build failures
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3123:
URL: https://github.com/apache/incubator-gobblin/pull/3123
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] codecov-io edited a comment on pull request #3123: GOBBLIN-1284: Fix flaky tests causing local build failures
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #3123:
URL: https://github.com/apache/incubator-gobblin/pull/3123#issuecomment-706626746
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3123?src=pr&el=h1) Report
> Merging [#3123](https://codecov.io/gh/apache/incubator-gobblin/pull/3123?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/52cefe6339182e3f78e93e3913ebd946c7a57512?el=desc) will **decrease** coverage by `4.28%`.
> The diff coverage is `65.38%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/3123?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3123 +/- ##
============================================
- Coverage 46.02% 41.73% -4.29%
+ Complexity 9582 8732 -850
============================================
Files 1986 1986
Lines 75796 75809 +13
Branches 8445 8446 +1
============================================
- Hits 34884 31638 -3246
- Misses 37635 41152 +3517
+ Partials 3277 3019 -258
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/3123?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...a/org/apache/gobblin/service/FlowConfigClient.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi1mbG93LWNvbmZpZy1zZXJ2aWNlL2dvYmJsaW4tZmxvdy1jb25maWctc2VydmljZS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9GbG93Q29uZmlnQ2xpZW50LmphdmE=) | `71.66% <0.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...apache/gobblin/kafka/writer/Kafka09DataWriter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtMDkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4va2Fma2Evd3JpdGVyL0thZmthMDlEYXRhV3JpdGVyLmphdmE=) | `72.30% <65.21%> (-2.27%)` | `10.00 <0.00> (ø)` | |
| [...lin/kafka/writer/KafkaWriterConfigurationKeys.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2thZmthL3dyaXRlci9LYWZrYVdyaXRlckNvbmZpZ3VyYXRpb25LZXlzLmphdmE=) | `75.00% <100.00%> (+8.33%)` | `1.00 <0.00> (ø)` | |
| [...org/apache/gobblin/service/FlowConfigV2Client.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi1mbG93LWNvbmZpZy1zZXJ2aWNlL2dvYmJsaW4tZmxvdy1jb25maWctc2VydmljZS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9GbG93Q29uZmlnVjJDbGllbnQuamF2YQ==) | `58.88% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [.../org/apache/gobblin/util/filters/HiddenFilter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsdGVycy9IaWRkZW5GaWx0ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...g/apache/gobblin/cluster/HelixMessageSubTypes.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhNZXNzYWdlU3ViVHlwZXMuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...gobblin/runtime/mapreduce/GobblinOutputFormat.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbWFwcmVkdWNlL0dvYmJsaW5PdXRwdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../gobblin/compaction/suite/CompactionSuiteBase.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vc3VpdGUvQ29tcGFjdGlvblN1aXRlQmFzZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-10.00%)` | |
| [...obblin/compaction/source/CompactionFailedTask.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vc291cmNlL0NvbXBhY3Rpb25GYWlsZWRUYXNrLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...n/cluster/event/ClusterManagerShutdownRequest.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvZXZlbnQvQ2x1c3Rlck1hbmFnZXJTaHV0ZG93blJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [154 more](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3123?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3123?src=pr&el=footer). Last update [52cefe6...362a885](https://codecov.io/gh/apache/incubator-gobblin/pull/3123?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] codecov-io edited a comment on pull request #3123: GOBBLIN-1284: Fix flaky tests causing local build failures
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #3123:
URL: https://github.com/apache/incubator-gobblin/pull/3123#issuecomment-706626746
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3123?src=pr&el=h1) Report
> Merging [#3123](https://codecov.io/gh/apache/incubator-gobblin/pull/3123?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/52cefe6339182e3f78e93e3913ebd946c7a57512?el=desc) will **decrease** coverage by `36.76%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/3123?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3123 +/- ##
============================================
- Coverage 46.02% 9.25% -36.77%
+ Complexity 9582 1722 -7860
============================================
Files 1986 1986
Lines 75796 75809 +13
Branches 8445 8446 +1
============================================
- Hits 34884 7017 -27867
- Misses 37635 68109 +30474
+ Partials 3277 683 -2594
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/3123?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/gobblin/kafka/writer/Kafka09DataWriter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtMDkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4va2Fma2Evd3JpdGVyL0thZmthMDlEYXRhV3JpdGVyLmphdmE=) | `0.00% <0.00%> (-74.58%)` | `0.00 <0.00> (-10.00)` | |
| [...lin/kafka/writer/KafkaWriterConfigurationKeys.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2thZmthL3dyaXRlci9LYWZrYVdyaXRlckNvbmZpZ3VyYXRpb25LZXlzLmphdmE=) | `0.00% <0.00%> (-66.67%)` | `0.00 <0.00> (-1.00)` | |
| [...a/org/apache/gobblin/service/FlowConfigClient.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi1mbG93LWNvbmZpZy1zZXJ2aWNlL2dvYmJsaW4tZmxvdy1jb25maWctc2VydmljZS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9GbG93Q29uZmlnQ2xpZW50LmphdmE=) | `0.00% <0.00%> (-71.67%)` | `0.00 <0.00> (-8.00)` | |
| [...org/apache/gobblin/service/FlowConfigV2Client.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi1mbG93LWNvbmZpZy1zZXJ2aWNlL2dvYmJsaW4tZmxvdy1jb25maWctc2VydmljZS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9GbG93Q29uZmlnVjJDbGllbnQuamF2YQ==) | `0.00% <0.00%> (-58.89%)` | `0.00 <0.00> (-10.00)` | |
| [...c/main/java/org/apache/gobblin/util/FileUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvRmlsZVV0aWxzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...n/java/org/apache/gobblin/fork/CopyableSchema.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2ZvcmsvQ29weWFibGVTY2hlbWEuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...java/org/apache/gobblin/stream/ControlMessage.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc3RyZWFtL0NvbnRyb2xNZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...va/org/apache/gobblin/dataset/DatasetResolver.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YXNldC9EYXRhc2V0UmVzb2x2ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...va/org/apache/gobblin/converter/EmptyIterable.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbnZlcnRlci9FbXB0eUl0ZXJhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...org/apache/gobblin/ack/BasicAckableForTesting.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vYWNrL0Jhc2ljQWNrYWJsZUZvclRlc3RpbmcuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [1051 more](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3123?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3123?src=pr&el=footer). Last update [52cefe6...24eec5b](https://codecov.io/gh/apache/incubator-gobblin/pull/3123?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] sv2000 closed pull request #3123: GOBBLIN-1284: Fix flaky tests causing local build failures
Posted by GitBox <gi...@apache.org>.
sv2000 closed pull request #3123:
URL: https://github.com/apache/incubator-gobblin/pull/3123
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] codecov-io edited a comment on pull request #3123: GOBBLIN-1284: Fix flaky tests causing local build failures
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #3123:
URL: https://github.com/apache/incubator-gobblin/pull/3123#issuecomment-706626746
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3123?src=pr&el=h1) Report
> Merging [#3123](https://codecov.io/gh/apache/incubator-gobblin/pull/3123?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/52cefe6339182e3f78e93e3913ebd946c7a57512?el=desc) will **decrease** coverage by `0.00%`.
> The diff coverage is `65.38%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/3123?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3123 +/- ##
============================================
- Coverage 46.02% 46.01% -0.01%
+ Complexity 9582 9580 -2
============================================
Files 1986 1986
Lines 75796 75809 +13
Branches 8445 8446 +1
============================================
+ Hits 34884 34887 +3
- Misses 37635 37643 +8
- Partials 3277 3279 +2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/3123?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...a/org/apache/gobblin/service/FlowConfigClient.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi1mbG93LWNvbmZpZy1zZXJ2aWNlL2dvYmJsaW4tZmxvdy1jb25maWctc2VydmljZS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9GbG93Q29uZmlnQ2xpZW50LmphdmE=) | `71.66% <0.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...apache/gobblin/kafka/writer/Kafka09DataWriter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtMDkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4va2Fma2Evd3JpdGVyL0thZmthMDlEYXRhV3JpdGVyLmphdmE=) | `72.30% <65.21%> (-2.27%)` | `10.00 <0.00> (ø)` | |
| [...lin/kafka/writer/KafkaWriterConfigurationKeys.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2thZmthL3dyaXRlci9LYWZrYVdyaXRlckNvbmZpZ3VyYXRpb25LZXlzLmphdmE=) | `75.00% <100.00%> (+8.33%)` | `1.00 <0.00> (ø)` | |
| [...org/apache/gobblin/service/FlowConfigV2Client.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi1mbG93LWNvbmZpZy1zZXJ2aWNlL2dvYmJsaW4tZmxvdy1jb25maWctc2VydmljZS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9GbG93Q29uZmlnVjJDbGllbnQuamF2YQ==) | `58.88% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...in/java/org/apache/gobblin/cluster/HelixUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhVdGlscy5qYXZh) | `37.19% <0.00%> (-3.31%)` | `13.00% <0.00%> (-1.00%)` | |
| [...ctor/extract/kafka/KafkaExtractorStatsTracker.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9leHRyYWN0b3IvZXh0cmFjdC9rYWZrYS9LYWZrYUV4dHJhY3RvclN0YXRzVHJhY2tlci5qYXZh) | `86.58% <0.00%> (-0.44%)` | `49.00% <0.00%> (-1.00%)` | |
| [...n/java/org/apache/gobblin/util/PullFileLoader.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvUHVsbEZpbGVMb2FkZXIuamF2YQ==) | `73.88% <0.00%> (-0.34%)` | `26.00% <0.00%> (+1.00%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3123?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3123?src=pr&el=footer). Last update [52cefe6...232e672](https://codecov.io/gh/apache/incubator-gobblin/pull/3123?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] codecov-io edited a comment on pull request #3123: GOBBLIN-1284: Fix flaky tests causing local build failures
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #3123:
URL: https://github.com/apache/incubator-gobblin/pull/3123#issuecomment-706626746
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3123?src=pr&el=h1) Report
> Merging [#3123](https://codecov.io/gh/apache/incubator-gobblin/pull/3123?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/52cefe6339182e3f78e93e3913ebd946c7a57512?el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `65.38%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/3123?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3123 +/- ##
============================================
- Coverage 46.02% 46.01% -0.02%
+ Complexity 9582 9580 -2
============================================
Files 1986 1986
Lines 75796 75809 +13
Branches 8445 8446 +1
============================================
- Hits 34884 34880 -4
- Misses 37635 37646 +11
- Partials 3277 3283 +6
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/3123?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...a/org/apache/gobblin/service/FlowConfigClient.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi1mbG93LWNvbmZpZy1zZXJ2aWNlL2dvYmJsaW4tZmxvdy1jb25maWctc2VydmljZS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9GbG93Q29uZmlnQ2xpZW50LmphdmE=) | `71.66% <0.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...apache/gobblin/kafka/writer/Kafka09DataWriter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtMDkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4va2Fma2Evd3JpdGVyL0thZmthMDlEYXRhV3JpdGVyLmphdmE=) | `72.30% <65.21%> (-2.27%)` | `10.00 <0.00> (ø)` | |
| [...lin/kafka/writer/KafkaWriterConfigurationKeys.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2thZmthL3dyaXRlci9LYWZrYVdyaXRlckNvbmZpZ3VyYXRpb25LZXlzLmphdmE=) | `75.00% <100.00%> (+8.33%)` | `1.00 <0.00> (ø)` | |
| [...org/apache/gobblin/service/FlowConfigV2Client.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi1mbG93LWNvbmZpZy1zZXJ2aWNlL2dvYmJsaW4tZmxvdy1jb25maWctc2VydmljZS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9GbG93Q29uZmlnVjJDbGllbnQuamF2YQ==) | `58.88% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...a/org/apache/gobblin/util/limiter/NoopLimiter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvbGltaXRlci9Ob29wTGltaXRlci5qYXZh) | `40.00% <0.00%> (-20.00%)` | `2.00% <0.00%> (-1.00%)` | |
| [...lin/util/filesystem/FileSystemInstrumentation.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsZXN5c3RlbS9GaWxlU3lzdGVtSW5zdHJ1bWVudGF0aW9uLmphdmE=) | `85.71% <0.00%> (-14.29%)` | `3.00% <0.00%> (-1.00%)` | |
| [...e/gobblin/runtime/locks/ZookeeperBasedJobLock.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbG9ja3MvWm9va2VlcGVyQmFzZWRKb2JMb2NrLmphdmE=) | `58.88% <0.00%> (-5.56%)` | `16.00% <0.00%> (ø%)` | |
| [...in/java/org/apache/gobblin/cluster/HelixUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhVdGlscy5qYXZh) | `38.01% <0.00%> (-2.48%)` | `14.00% <0.00%> (ø%)` | |
| [...lin/elasticsearch/writer/FutureCallbackHolder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tZWxhc3RpY3NlYXJjaC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9lbGFzdGljc2VhcmNoL3dyaXRlci9GdXR1cmVDYWxsYmFja0hvbGRlci5qYXZh) | `61.42% <0.00%> (-1.43%)` | `4.00% <0.00%> (ø%)` | |
| [...a/management/copy/publisher/CopyDataPublisher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvcHkvcHVibGlzaGVyL0NvcHlEYXRhUHVibGlzaGVyLmphdmE=) | `74.00% <0.00%> (-1.34%)` | `31.00% <0.00%> (-1.00%)` | |
| ... and [2 more](https://codecov.io/gh/apache/incubator-gobblin/pull/3123/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3123?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3123?src=pr&el=footer). Last update [52cefe6...314671a](https://codecov.io/gh/apache/incubator-gobblin/pull/3123?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org