[jira] [Comment Edited] (HIVE-19823) BytesBytesMultiHashMap estimation should account for loadFactor

["Sergey Shelukhin (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-19823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16506326#comment-16506326 ] 

Sergey Shelukhin edited comment on HIVE-19823 at 6/8/18 5:51 PM:
-----------------------------------------------------------------

MapJoinBytesTableContainer already accounts for LoadFactor when creating it. Perhaps that functionality should be moved to the ctor of hashtable instead; otherwise it should be removed.


was (Author: sershe):
MapJoinBytesTableContainer already accounts for LoadFactor when creating it. Perhaps that functionality should be moved to the ctor of hashtable instead, or removed.

> BytesBytesMultiHashMap estimation should account for loadFactor
> ---------------------------------------------------------------
>
>                 Key: HIVE-19823
>                 URL: https://issues.apache.org/jira/browse/HIVE-19823
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Zoltan Haindrich
>            Assignee: Zoltan Haindrich
>            Priority: Major
>         Attachments: HIVE-19823.01.patch
>
>
> it could happen that the capacity is known beforehand; and the estimated size of the hashtable is accurate. but still; because after some time the element count violates loadfactor ratio a rehash will occur.
> this by default could happen with a {{1-loadfactor = 25%}}  probability
> this rehashing takes around 2 seconds on my system for 6.5M entries
> https://github.com/apache/hive/blob/cfd57348c1ac188e0ba131d5636a62ff7b7c27be/ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/BytesBytesMultiHashMap.java#L176-L187



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)