You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/07/25 13:11:24 UTC

[GitHub] [pulsar] Nicklee007 opened a new pull request, #16780: [improve][broker]add NamespacePolicies and AntiAffinity check before unload in checkNamespaceBundleSplit

Nicklee007 opened a new pull request, #16780:
URL: https://github.com/apache/pulsar/pull/16780

   ### Motivation
   Add `NamespacePolicies` and `AntiAffinity` check before unload bundle when `checkNamespaceBundleSplit`.
   When unload the bundle after split, It's better to guarantee there are at least one another broker can load those bundle which satisfy the NamespacePolicies and AntiAffinity. Otherwise the bundle may not load successfully and  cause the client reconnect frequently.
   
   ### Modifications
   1. add NamespacePolicies and AntiAffinity check before unload bundle when `checkNamespaceBundleSplit`.
   2. add some unit test.
   
   ### Documentation
   
   - [X] `doc-not-needed` 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Nicklee007 commented on pull request #16780: [improve][broker]add NamespacePolicies and AntiAffinity check before unload in checkNamespaceBundleSplit

Posted by GitBox <gi...@apache.org>.
Nicklee007 commented on PR #16780:
URL: https://github.com/apache/pulsar/pull/16780#issuecomment-1378168738

   /pulsarbot rerun-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Nicklee007 commented on pull request #16780: [improve][broker]add NamespacePolicies and AntiAffinity check before unload in checkNamespaceBundleSplit

Posted by GitBox <gi...@apache.org>.
Nicklee007 commented on PR #16780:
URL: https://github.com/apache/pulsar/pull/16780#issuecomment-1378462160

   /pulsarbot rerun-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Nicklee007 commented on pull request #16780: [improve][broker]add NamespacePolicies and AntiAffinity check before unload in checkNamespaceBundleSplit

Posted by GitBox <gi...@apache.org>.
Nicklee007 commented on PR #16780:
URL: https://github.com/apache/pulsar/pull/16780#issuecomment-1194957976

   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Nicklee007 commented on pull request #16780: [improve][broker]add NamespacePolicies and AntiAffinity check before unload in checkNamespaceBundleSplit

Posted by GitBox <gi...@apache.org>.
Nicklee007 commented on PR #16780:
URL: https://github.com/apache/pulsar/pull/16780#issuecomment-1341885831

   @codelipenghui @Technoboy-  Could you help review this PR , better to check if has another broker satisfy 
    `NamespacePolicies` and `AntiAffinity` for the bundle before unload bundle,  which can help us avoid invalid bundle unload.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Nicklee007 commented on pull request #16780: [improve][broker]add NamespacePolicies and AntiAffinity check before unload in checkNamespaceBundleSplit

Posted by GitBox <gi...@apache.org>.
Nicklee007 commented on PR #16780:
URL: https://github.com/apache/pulsar/pull/16780#issuecomment-1231847982

   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] github-actions[bot] commented on pull request #16780: [improve][broker]add NamespacePolicies and AntiAffinity check before unload in checkNamespaceBundleSplit

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #16780:
URL: https://github.com/apache/pulsar/pull/16780#issuecomment-1296450952

   The pr had no activity for 30 days, mark with Stale label.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Nicklee007 commented on pull request #16780: [improve][broker]add NamespacePolicies and AntiAffinity check before unload in checkNamespaceBundleSplit

Posted by GitBox <gi...@apache.org>.
Nicklee007 commented on PR #16780:
URL: https://github.com/apache/pulsar/pull/16780#issuecomment-1340917218

   /pulsarbot rerun-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] github-actions[bot] commented on pull request #16780: [improve][broker]add NamespacePolicies and AntiAffinity check before unload in checkNamespaceBundleSplit

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #16780:
URL: https://github.com/apache/pulsar/pull/16780#issuecomment-1374686850

   The pr had no activity for 30 days, mark with Stale label.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Nicklee007 commented on pull request #16780: [improve][broker]add NamespacePolicies and AntiAffinity check before unload in checkNamespaceBundleSplit

Posted by GitBox <gi...@apache.org>.
Nicklee007 commented on PR #16780:
URL: https://github.com/apache/pulsar/pull/16780#issuecomment-1226853847

   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Nicklee007 commented on pull request #16780: [improve][broker]add NamespacePolicies and AntiAffinity check before unload in checkNamespaceBundleSplit

Posted by GitBox <gi...@apache.org>.
Nicklee007 commented on PR #16780:
URL: https://github.com/apache/pulsar/pull/16780#issuecomment-1228189052

   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Nicklee007 commented on pull request #16780: [improve][broker]add NamespacePolicies and AntiAffinity check before unload in checkNamespaceBundleSplit

Posted by GitBox <gi...@apache.org>.
Nicklee007 commented on PR #16780:
URL: https://github.com/apache/pulsar/pull/16780#issuecomment-1378402562

   /pulsarbot rerun-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Nicklee007 commented on pull request #16780: [improve][broker]add NamespacePolicies and AntiAffinity check before unload in checkNamespaceBundleSplit

Posted by GitBox <gi...@apache.org>.
Nicklee007 commented on PR #16780:
URL: https://github.com/apache/pulsar/pull/16780#issuecomment-1195071252

   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] gaozhangmin merged pull request #16780: [improve][broker]add NamespacePolicies and AntiAffinity check before unload in checkNamespaceBundleSplit

Posted by GitBox <gi...@apache.org>.
gaozhangmin merged PR #16780:
URL: https://github.com/apache/pulsar/pull/16780


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codecov-commenter commented on pull request #16780: [improve][broker]add NamespacePolicies and AntiAffinity check before unload in checkNamespaceBundleSplit

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #16780:
URL: https://github.com/apache/pulsar/pull/16780#issuecomment-1340682392

   # [Codecov](https://codecov.io/gh/apache/pulsar/pull/16780?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#16780](https://codecov.io/gh/apache/pulsar/pull/16780?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1f56dc6) into [master](https://codecov.io/gh/apache/pulsar/commit/99e26f5e943e3978bba135a2c17ff08dc9b9599a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (99e26f5) will **decrease** coverage by `7.80%`.
   > The diff coverage is `0.00%`.
   
   > :exclamation: Current head 1f56dc6 differs from pull request most recent head 8c17ec2. Consider uploading reports for the commit 8c17ec2 to get more accurate results
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/pulsar/pull/16780/graphs/tree.svg?width=650&height=150&src=pr&token=acYqCpsK9J&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/pulsar/pull/16780?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #16780      +/-   ##
   ============================================
   - Coverage     44.79%   36.98%   -7.81%     
   + Complexity    10026     1963    -8063     
   ============================================
     Files           703      209     -494     
     Lines         68808    14425   -54383     
     Branches       7375     1574    -5801     
   ============================================
   - Hits          30822     5335   -25487     
   + Misses        34378     8508   -25870     
   + Partials       3608      582    -3026     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | unittests | `36.98% <0.00%> (-7.81%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/pulsar/pull/16780?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...he/pulsar/client/impl/MultiTopicsConsumerImpl.java](https://codecov.io/gh/apache/pulsar/pull/16780/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NsaWVudC9pbXBsL011bHRpVG9waWNzQ29uc3VtZXJJbXBsLmphdmE=) | `22.86% <0.00%> (-0.12%)` | :arrow_down: |
   | [...he/pulsar/client/impl/PartitionedProducerImpl.java](https://codecov.io/gh/apache/pulsar/pull/16780/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NsaWVudC9pbXBsL1BhcnRpdGlvbmVkUHJvZHVjZXJJbXBsLmphdmE=) | `30.34% <0.00%> (-5.13%)` | :arrow_down: |
   | [.../pulsar/client/impl/ProducerStatsRecorderImpl.java](https://codecov.io/gh/apache/pulsar/pull/16780/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NsaWVudC9pbXBsL1Byb2R1Y2VyU3RhdHNSZWNvcmRlckltcGwuamF2YQ==) | `84.04% <0.00%> (-0.62%)` | :arrow_down: |
   | [...va/org/apache/pulsar/client/impl/ProducerImpl.java](https://codecov.io/gh/apache/pulsar/pull/16780/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NsaWVudC9pbXBsL1Byb2R1Y2VySW1wbC5qYXZh) | `16.41% <0.00%> (-0.59%)` | :arrow_down: |
   | [...che/bookkeeper/mledger/impl/ManagedCursorImpl.java](https://codecov.io/gh/apache/pulsar/pull/16780/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWFuYWdlZC1sZWRnZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvbWxlZGdlci9pbXBsL01hbmFnZWRDdXJzb3JJbXBsLmphdmE=) | | |
   | [...pache/bookkeeper/mledger/impl/RangeSetWrapper.java](https://codecov.io/gh/apache/pulsar/pull/16780/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWFuYWdlZC1sZWRnZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvbWxlZGdlci9pbXBsL1JhbmdlU2V0V3JhcHBlci5qYXZh) | | |
   | [...pulsar/broker/admin/impl/PersistentTopicsBase.java](https://codecov.io/gh/apache/pulsar/pull/16780/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9hZG1pbi9pbXBsL1BlcnNpc3RlbnRUb3BpY3NCYXNlLmphdmE=) | | |
   | [...ar/broker/loadbalance/impl/BundleSplitterTask.java](https://codecov.io/gh/apache/pulsar/pull/16780/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9sb2FkYmFsYW5jZS9pbXBsL0J1bmRsZVNwbGl0dGVyVGFzay5qYXZh) | | |
   | [...roker/loadbalance/impl/ModularLoadManagerImpl.java](https://codecov.io/gh/apache/pulsar/pull/16780/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9sb2FkYmFsYW5jZS9pbXBsL01vZHVsYXJMb2FkTWFuYWdlckltcGwuamF2YQ==) | | |
   | [...broker/service/schema/BookkeeperSchemaStorage.java](https://codecov.io/gh/apache/pulsar/pull/16780/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL3NjaGVtYS9Cb29ra2VlcGVyU2NoZW1hU3RvcmFnZS5qYXZh) | | |
   | ... and [490 more](https://codecov.io/gh/apache/pulsar/pull/16780/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org