You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by Bobby Evans <ev...@yahoo-inc.com> on 2014/05/14 19:30:50 UTC
Some JIRA needing reviews
I went though JIRA this morning and found several that already have a +1 from a committer but not 2, and I am not able to give the second +1, either I give the first +1 or I submitted the patch. If some other committer could take a look at them it would be helpful.
https://issues.apache.org/jira/browse/STORM-265
https://issues.apache.org/jira/browse/STORM-138
https://issues.apache.org/jira/browse/STORM-233
https://issues.apache.org/jira/browse/STORM-264
https://issues.apache.org/jira/browse/STORM-245
https://issues.apache.org/jira/browse/STORM-295
https://issues.apache.org/jira/browse/STORM-232
https://issues.apache.org/jira/browse/STORM-63
Thanks,
Bobby
Re: Some JIRA needing reviews
Posted by "P. Taylor Goetz" <pt...@gmail.com>.
This has been merged into the master branch and will be included in the next release.
-Taylor
> On May 23, 2014, at 6:12 PM, Andres Gomez Urquiza <an...@fractal.ai> wrote:
>
> STORM-265 <https://issues.apache.org/jira/browse/STORM-265> (Upgrade
> clojure to 1.5.1) is a really simple and useful change, pls someone with
> the authority +1 it.
> I give it a moral +1.
>
>
> On Tue, May 20, 2014 at 4:19 PM, Suresh Srinivas <su...@hortonworks.com>wrote:
>
>> I think requiring two +1s from committers is a big bottleneck. If for some
>> reason the committed code has issues, it can always be either followed up
>> with another jira or reverted. With very few number of committers
>> participating in Storm project, the requirement of +1s from two committers
>> is an overhead and slows down the progress.
>>
>>
>> On Tue, May 20, 2014 at 8:25 AM, P. Taylor Goetz <pt...@gmail.com>
>> wrote:
>>
>>> We still need an additional committer +1 for
>>> https://issues.apache.org/jira/browse/STORM-265 (Upgrade clojure to
>>> 1.5.1).
>>>
>>> I’d like to include this in the next release for a number of reasons, but
>>> mostly because it fixes a situation where clojure compilation may fail,
>> but
>>> the maven clojure plugin does not output any information about the root
>>> cause of the compilation failure. That can be very frustrating when
>> making
>>> changes to the clojure code.
>>>
>>> - Taylor
>>>
>>> On May 14, 2014, at 1:30 PM, Bobby Evans <ev...@yahoo-inc.com> wrote:
>>>
>>> I went though JIRA this morning and found several that already have a +1
>>> from a committer but not 2, and I am not able to give the second +1,
>> either
>>> I give the first +1 or I submitted the patch. If some other committer
>>> could take a look at them it would be helpful.
>>>
>>> https://issues.apache.org/jira/browse/STORM-265
>>> https://issues.apache.org/jira/browse/STORM-138
>>> https://issues.apache.org/jira/browse/STORM-233
>>> https://issues.apache.org/jira/browse/STORM-264
>>> https://issues.apache.org/jira/browse/STORM-245
>>> https://issues.apache.org/jira/browse/STORM-295
>>> https://issues.apache.org/jira/browse/STORM-232
>>> https://issues.apache.org/jira/browse/STORM-63
>>>
>>> Thanks,
>>>
>>> Bobby
>>
>>
>> --
>> http://hortonworks.com/download/
>>
>> --
>> CONFIDENTIALITY NOTICE
>> NOTICE: This message is intended for the use of the individual or entity to
>> which it is addressed and may contain information that is confidential,
>> privileged and exempt from disclosure under applicable law. If the reader
>> of this message is not the intended recipient, you are hereby notified that
>> any printing, copying, dissemination, distribution, disclosure or
>> forwarding of this communication is strictly prohibited. If you have
>> received this communication in error, please contact the sender immediately
>> and delete it from your system. Thank You.
>>
Re: Some JIRA needing reviews
Posted by Andres Gomez Urquiza <an...@fractal.ai>.
STORM-265 <https://issues.apache.org/jira/browse/STORM-265> (Upgrade
clojure to 1.5.1) is a really simple and useful change, pls someone with
the authority +1 it.
I give it a moral +1.
On Tue, May 20, 2014 at 4:19 PM, Suresh Srinivas <su...@hortonworks.com>wrote:
> I think requiring two +1s from committers is a big bottleneck. If for some
> reason the committed code has issues, it can always be either followed up
> with another jira or reverted. With very few number of committers
> participating in Storm project, the requirement of +1s from two committers
> is an overhead and slows down the progress.
>
>
> On Tue, May 20, 2014 at 8:25 AM, P. Taylor Goetz <pt...@gmail.com>
> wrote:
>
> > We still need an additional committer +1 for
> > https://issues.apache.org/jira/browse/STORM-265 (Upgrade clojure to
> > 1.5.1).
> >
> > I’d like to include this in the next release for a number of reasons, but
> > mostly because it fixes a situation where clojure compilation may fail,
> but
> > the maven clojure plugin does not output any information about the root
> > cause of the compilation failure. That can be very frustrating when
> making
> > changes to the clojure code.
> >
> > - Taylor
> >
> > On May 14, 2014, at 1:30 PM, Bobby Evans <ev...@yahoo-inc.com> wrote:
> >
> > I went though JIRA this morning and found several that already have a +1
> > from a committer but not 2, and I am not able to give the second +1,
> either
> > I give the first +1 or I submitted the patch. If some other committer
> > could take a look at them it would be helpful.
> >
> > https://issues.apache.org/jira/browse/STORM-265
> > https://issues.apache.org/jira/browse/STORM-138
> > https://issues.apache.org/jira/browse/STORM-233
> > https://issues.apache.org/jira/browse/STORM-264
> > https://issues.apache.org/jira/browse/STORM-245
> > https://issues.apache.org/jira/browse/STORM-295
> > https://issues.apache.org/jira/browse/STORM-232
> > https://issues.apache.org/jira/browse/STORM-63
> >
> > Thanks,
> >
> > Bobby
> >
> >
> >
>
>
> --
> http://hortonworks.com/download/
>
> --
> CONFIDENTIALITY NOTICE
> NOTICE: This message is intended for the use of the individual or entity to
> which it is addressed and may contain information that is confidential,
> privileged and exempt from disclosure under applicable law. If the reader
> of this message is not the intended recipient, you are hereby notified that
> any printing, copying, dissemination, distribution, disclosure or
> forwarding of this communication is strictly prohibited. If you have
> received this communication in error, please contact the sender immediately
> and delete it from your system. Thank You.
>
Re: Some JIRA needing reviews
Posted by Suresh Srinivas <su...@hortonworks.com>.
I think requiring two +1s from committers is a big bottleneck. If for some
reason the committed code has issues, it can always be either followed up
with another jira or reverted. With very few number of committers
participating in Storm project, the requirement of +1s from two committers
is an overhead and slows down the progress.
On Tue, May 20, 2014 at 8:25 AM, P. Taylor Goetz <pt...@gmail.com> wrote:
> We still need an additional committer +1 for
> https://issues.apache.org/jira/browse/STORM-265 (Upgrade clojure to
> 1.5.1).
>
> I’d like to include this in the next release for a number of reasons, but
> mostly because it fixes a situation where clojure compilation may fail, but
> the maven clojure plugin does not output any information about the root
> cause of the compilation failure. That can be very frustrating when making
> changes to the clojure code.
>
> - Taylor
>
> On May 14, 2014, at 1:30 PM, Bobby Evans <ev...@yahoo-inc.com> wrote:
>
> I went though JIRA this morning and found several that already have a +1
> from a committer but not 2, and I am not able to give the second +1, either
> I give the first +1 or I submitted the patch. If some other committer
> could take a look at them it would be helpful.
>
> https://issues.apache.org/jira/browse/STORM-265
> https://issues.apache.org/jira/browse/STORM-138
> https://issues.apache.org/jira/browse/STORM-233
> https://issues.apache.org/jira/browse/STORM-264
> https://issues.apache.org/jira/browse/STORM-245
> https://issues.apache.org/jira/browse/STORM-295
> https://issues.apache.org/jira/browse/STORM-232
> https://issues.apache.org/jira/browse/STORM-63
>
> Thanks,
>
> Bobby
>
>
>
--
http://hortonworks.com/download/
--
CONFIDENTIALITY NOTICE
NOTICE: This message is intended for the use of the individual or entity to
which it is addressed and may contain information that is confidential,
privileged and exempt from disclosure under applicable law. If the reader
of this message is not the intended recipient, you are hereby notified that
any printing, copying, dissemination, distribution, disclosure or
forwarding of this communication is strictly prohibited. If you have
received this communication in error, please contact the sender immediately
and delete it from your system. Thank You.
Re: Some JIRA needing reviews
Posted by "P. Taylor Goetz" <pt...@gmail.com>.
We still need an additional committer +1 for https://issues.apache.org/jira/browse/STORM-265 (Upgrade clojure to 1.5.1).
I’d like to include this in the next release for a number of reasons, but mostly because it fixes a situation where clojure compilation may fail, but the maven clojure plugin does not output any information about the root cause of the compilation failure. That can be very frustrating when making changes to the clojure code.
- Taylor
On May 14, 2014, at 1:30 PM, Bobby Evans <ev...@yahoo-inc.com> wrote:
> I went though JIRA this morning and found several that already have a +1 from a committer but not 2, and I am not able to give the second +1, either I give the first +1 or I submitted the patch. If some other committer could take a look at them it would be helpful.
>
> https://issues.apache.org/jira/browse/STORM-265
> https://issues.apache.org/jira/browse/STORM-138
> https://issues.apache.org/jira/browse/STORM-233
> https://issues.apache.org/jira/browse/STORM-264
> https://issues.apache.org/jira/browse/STORM-245
> https://issues.apache.org/jira/browse/STORM-295
> https://issues.apache.org/jira/browse/STORM-232
> https://issues.apache.org/jira/browse/STORM-63
>
> Thanks,
>
> Bobby
>