You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by "adoroszlai (via GitHub)" <gi...@apache.org> on 2023/12/09 16:07:41 UTC
[PR] RATIS-1960. Follower may be incorrectly marked as having caught up [ratis]
adoroszlai opened a new pull request, #983:
URL: https://github.com/apache/ratis/pull/983
## What changes were proposed in this pull request?
1. Fix race condition that may cause follower to be incorrectly marked as having caught up with leader.
2. Fix calculation of `initializing` flag for `appendEntries` request sent to follower.
Please see RATIS-1960 for details on both.
## How was this patch tested?
CI:
https://github.com/adoroszlai/ratis/actions/runs/7151958459
Passed 10x50 `TestInstallSnapshotNotificationWithGrpc#testInstallSnapshotDuringBootstrap` (this was failing in 6% of runs after fixing only the race condition):
https://github.com/adoroszlai/ratis/actions/runs/7152037092
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RATIS-1960. Follower may be incorrectly marked as having caught up [ratis]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #983:
URL: https://github.com/apache/ratis/pull/983#issuecomment-1848888078
Thansk @szetszwo for reviewing and merging this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RATIS-1960. Follower may be incorrectly marked as having caught up [ratis]
Posted by "SzyWilliam (via GitHub)" <gi...@apache.org>.
SzyWilliam commented on PR #983:
URL: https://github.com/apache/ratis/pull/983#issuecomment-1851188698
Cool catch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RATIS-1960. Follower may be incorrectly marked as having caught up [ratis]
Posted by "szetszwo (via GitHub)" <gi...@apache.org>.
szetszwo merged PR #983:
URL: https://github.com/apache/ratis/pull/983
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org