You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/03 22:59:27 UTC

[GitHub] [beam] kennknowles opened a new issue, #19224: Go check for IsWorkerCompatibleBinary is wrong

kennknowles opened a new issue, #19224:
URL: https://github.com/apache/beam/issues/19224

   Per BEAM-5253, The linux/amd64 check in IsWorkerCompatibleBinary is insufficient:
   
   https://github.com/apache/beam/blob/609a42978405173a60e5d91f35170a5c0b5d5332/sdks/go/pkg/beam/runners/universal/runnerlib/compile.go#L37
   
   We need to see if we can do a better check here (such as looking up the symbol table or similar) or disable this optimization.
   
   Imported from Jira [BEAM-5357](https://issues.apache.org/jira/browse/BEAM-5357). Original Jira may contain additional context.
   Reported by: herohde.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Go check for IsWorkerCompatibleBinary is wrong [beam]

Posted by "damccorm (via GitHub) via github" <gi...@beam.apache.org>.
damccorm commented on issue #19224:
URL: https://github.com/apache/beam/issues/19224#issuecomment-6749126536

   Resolved in commit a25bbc7cb36, which disabled the `IsWorkerCompatibleBinary` check in `sdks/go/pkg/beam/runners/universal/runnerlib/compile.go` as requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Go check for IsWorkerCompatibleBinary is wrong [beam]

Posted by "damccorm (via GitHub) via github" <gi...@beam.apache.org>.
damccorm closed issue #19224: Go check for IsWorkerCompatibleBinary is wrong
URL: https://github.com/apache/beam/issues/19224


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org