You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Narayan Periwal <na...@inmobi.com> on 2017/01/19 12:25:53 UTC
Review Request 55715: Update error message for data completeness check
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55715/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-1384
https://issues.apache.org/jira/browse/LENS-1384
Repository: lens
Description
-------
We can make the error message for the data completeness check less verbose.
New message can be something like - Requested metrics are only partially complete. Partially complete metrics: <comma separated list of metrics>. Try again later or remove metric and re-run report.
Diffs
-----
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java 2ad6e20
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java c9e7c29
Diff: https://reviews.apache.org/r/55715/diff/
Testing
-------
Thanks,
Narayan Periwal
Re: Review Request 55715: Update error message for data completeness
check
Posted by Puneet Gupta <pu...@gmail.com>.
> On Jan. 19, 2017, 2:06 p.m., Puneet Gupta wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java, line 151
> > <https://reviews.apache.org/r/55715/diff/1/?file=1608971#file1608971line151>
> >
> > Should we say
> >
> > "Data for the requested metrics is only partially available. Partially available metrics are : %s. Please try again later."
Data for the requested metrics is only partially complete. Partially complete metrics are : %s. Please try again later or rerun after removing incomplete metrics
- Puneet
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55715/#review162281
-----------------------------------------------------------
On Jan. 25, 2017, 6:29 a.m., Narayan Periwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55715/
> -----------------------------------------------------------
>
> (Updated Jan. 25, 2017, 6:29 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1384
> https://issues.apache.org/jira/browse/LENS-1384
>
>
> Repository: lens
>
>
> Description
> -------
>
> We can make the error message for the data completeness check less verbose.
> New message can be something like - Requested metrics are only partially complete. Partially complete metrics: <comma separated list of metrics>. Try again later or remove metric and re-run report.
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java 2ad6e20
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java c9e7c29
>
> Diff: https://reviews.apache.org/r/55715/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Narayan Periwal
>
>
Re: Review Request 55715: Update error message for data completeness
check
Posted by Narayan Periwal <na...@inmobi.com>.
> On Jan. 19, 2017, 2:06 p.m., Puneet Gupta wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java, line 154
> > <https://reviews.apache.org/r/55715/diff/1/?file=1608971#file1608971line154>
> >
> > Are we logging the old more verbose message( metric - time - %completion) somewhere ? It would be required for debugging the issue or to answer user queries when they pour in .
Yes, we are logging the entire verbose message that will help in debugging the issue, as you mentioned.
- Narayan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55715/#review162281
-----------------------------------------------------------
On Jan. 19, 2017, 12:25 p.m., Narayan Periwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55715/
> -----------------------------------------------------------
>
> (Updated Jan. 19, 2017, 12:25 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1384
> https://issues.apache.org/jira/browse/LENS-1384
>
>
> Repository: lens
>
>
> Description
> -------
>
> We can make the error message for the data completeness check less verbose.
> New message can be something like - Requested metrics are only partially complete. Partially complete metrics: <comma separated list of metrics>. Try again later or remove metric and re-run report.
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java 2ad6e20
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java c9e7c29
>
> Diff: https://reviews.apache.org/r/55715/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Narayan Periwal
>
>
Re: Review Request 55715: Update error message for data completeness
check
Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55715/#review162281
-----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java (line 151)
<https://reviews.apache.org/r/55715/#comment233618>
Should we say
"Data for the requested metrics is only partially available. Partially available metrics are : %s. Please try again later."
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java (line 154)
<https://reviews.apache.org/r/55715/#comment233619>
Are we logging the old more verbose message( metric - time - %completion) somewhere ? It would be required for debugging the issue or to answer user queries when they pour in .
- Puneet Gupta
On Jan. 19, 2017, 12:25 p.m., Narayan Periwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55715/
> -----------------------------------------------------------
>
> (Updated Jan. 19, 2017, 12:25 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1384
> https://issues.apache.org/jira/browse/LENS-1384
>
>
> Repository: lens
>
>
> Description
> -------
>
> We can make the error message for the data completeness check less verbose.
> New message can be something like - Requested metrics are only partially complete. Partially complete metrics: <comma separated list of metrics>. Try again later or remove metric and re-run report.
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java 2ad6e20
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java c9e7c29
>
> Diff: https://reviews.apache.org/r/55715/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Narayan Periwal
>
>
Re: Review Request 55715: Update error message for data completeness
check
Posted by Narayan Periwal <na...@inmobi.com>.
> On Jan. 24, 2017, 8:32 a.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java, line 975
> > <https://reviews.apache.org/r/55715/diff/1/?file=1608972#file1608972line975>
> >
> > Can you add assert for actual messsage containing measure name as part of the message?
Added.
- Narayan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55715/#review162789
-----------------------------------------------------------
On Jan. 25, 2017, 6:29 a.m., Narayan Periwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55715/
> -----------------------------------------------------------
>
> (Updated Jan. 25, 2017, 6:29 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1384
> https://issues.apache.org/jira/browse/LENS-1384
>
>
> Repository: lens
>
>
> Description
> -------
>
> We can make the error message for the data completeness check less verbose.
> New message can be something like - Requested metrics are only partially complete. Partially complete metrics: <comma separated list of metrics>. Try again later or remove metric and re-run report.
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java 2ad6e20
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java c9e7c29
>
> Diff: https://reviews.apache.org/r/55715/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Narayan Periwal
>
>
Re: Review Request 55715: Update error message for data completeness
check
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55715/#review162789
-----------------------------------------------------------
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java (line 975)
<https://reviews.apache.org/r/55715/#comment234151>
Can you add assert for actual messsage containing measure name as part of the message?
- Amareshwari Sriramadasu
On Jan. 19, 2017, 12:25 p.m., Narayan Periwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55715/
> -----------------------------------------------------------
>
> (Updated Jan. 19, 2017, 12:25 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1384
> https://issues.apache.org/jira/browse/LENS-1384
>
>
> Repository: lens
>
>
> Description
> -------
>
> We can make the error message for the data completeness check less verbose.
> New message can be something like - Requested metrics are only partially complete. Partially complete metrics: <comma separated list of metrics>. Try again later or remove metric and re-run report.
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java 2ad6e20
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java c9e7c29
>
> Diff: https://reviews.apache.org/r/55715/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Narayan Periwal
>
>
Re: Review Request 55715: Update error message for data completeness
check
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55715/#review163226
-----------------------------------------------------------
Ship it!
Ship It!
- Amareshwari Sriramadasu
On Jan. 25, 2017, 4:01 p.m., Narayan Periwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55715/
> -----------------------------------------------------------
>
> (Updated Jan. 25, 2017, 4:01 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1384
> https://issues.apache.org/jira/browse/LENS-1384
>
>
> Repository: lens
>
>
> Description
> -------
>
> We can make the error message for the data completeness check less verbose.
> New message can be something like - Requested metrics are only partially complete. Partially complete metrics: <comma separated list of metrics>. Try again later or remove metric and re-run report.
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java 2ad6e20
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java c9e7c29
>
> Diff: https://reviews.apache.org/r/55715/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Narayan Periwal
>
>
Re: Review Request 55715: Update error message for data completeness
check
Posted by Narayan Periwal <na...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55715/
-----------------------------------------------------------
(Updated Jan. 25, 2017, 4:01 p.m.)
Review request for lens.
Bugs: LENS-1384
https://issues.apache.org/jira/browse/LENS-1384
Repository: lens
Description
-------
We can make the error message for the data completeness check less verbose.
New message can be something like - Requested metrics are only partially complete. Partially complete metrics: <comma separated list of metrics>. Try again later or remove metric and re-run report.
Diffs (updated)
-----
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java 2ad6e20
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java c9e7c29
Diff: https://reviews.apache.org/r/55715/diff/
Testing
-------
Thanks,
Narayan Periwal
Re: Review Request 55715: Update error message for data completeness
check
Posted by Narayan Periwal <na...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55715/
-----------------------------------------------------------
(Updated Jan. 25, 2017, 7:31 a.m.)
Review request for lens.
Bugs: LENS-1384
https://issues.apache.org/jira/browse/LENS-1384
Repository: lens
Description
-------
We can make the error message for the data completeness check less verbose.
New message can be something like - Requested metrics are only partially complete. Partially complete metrics: <comma separated list of metrics>. Try again later or remove metric and re-run report.
Diffs (updated)
-----
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java 2ad6e20
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java c9e7c29
Diff: https://reviews.apache.org/r/55715/diff/
Testing
-------
Thanks,
Narayan Periwal
Re: Review Request 55715: Update error message for data completeness
check
Posted by Narayan Periwal <na...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55715/
-----------------------------------------------------------
(Updated Jan. 25, 2017, 6:29 a.m.)
Review request for lens.
Bugs: LENS-1384
https://issues.apache.org/jira/browse/LENS-1384
Repository: lens
Description
-------
We can make the error message for the data completeness check less verbose.
New message can be something like - Requested metrics are only partially complete. Partially complete metrics: <comma separated list of metrics>. Try again later or remove metric and re-run report.
Diffs (updated)
-----
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java 2ad6e20
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java c9e7c29
Diff: https://reviews.apache.org/r/55715/diff/
Testing
-------
Thanks,
Narayan Periwal