[GitHub] [skywalking-python] kezhenxu94 commented on pull request #297: [wip]Build multi-architecture Docker images for Python agent

["kezhenxu94 (via GitHub)" <gi...@apache.org>]

kezhenxu94 commented on PR #297:
URL: https://github.com/apache/skywalking-python/pull/297#issuecomment-1475042913

   > 
   > 
   > 
   > 
   > > I can build locally when I set the `VERSION=1.0.0` (`make build-image VERSION=1.0.0`) so you might want to update your repo and set the same version.
   > 
   > > 
   > 
   > > * We should also verify this in CI:
   > 
   > >   
   > 
   > >   * Build docker images without pushing to remote registry in PR checks, with `make build-image`.
   > 
   > >   * Build and push images to ghcr.io with `make push-image`, [example](https://github.com/apache/skywalking-java/blob/main/.github/workflows/publish-docker.yaml)
   > 
   > 
   > 
   > When building a new docker image with CI, would it be better to use the local skywalking-python package instead of the one provided by PyPI?
   > 
   > 
   
   Yes sure we should use the local skywalking Python package because that's what we want to verify. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org