[GitHub] [accumulo] ddanielr commented on pull request #3297: fix metrics tags, tserver hostname, remove tags from thrift metrics

["ddanielr (via GitHub)" <gi...@apache.org>]

ddanielr commented on PR #3297:
URL: https://github.com/apache/accumulo/pull/3297#issuecomment-1509472723

   Overall the changes look good! Thanks for including my changes from #3296. 
   
   > If it could take on different values, it also seemed unlikely that it would be something that end-users would need to trend / watch by specific thread. Monitoring thift times could provide a view into the health of the processes - knowing it was a specific thread seemed like something that would be needed by developers that were profiling specific code sections and metrics may not be the best way to determine that specific thrift thread timing.
   
   Agreed! If profiling specific code sections is required then we should focus on adding traceability support as a separate feature vs attempting to combine that data into the existing metrics store.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org