You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pubscribe-user@ws.apache.org by Ciprian Ciubotariu <ci...@softnrg.dnttm.ro> on 2005/11/18 15:26:38 UTC
Bug in WSRF for 1-way MEPs
Hi.
I've corrected the ResourceHandler in WSRF-1.1 to no longer fault on
1-way MEPs (like the standard notify message in WS-Notification
NotificationConsumer interface, for instance). Apparently the response
message in the messageContext is already null, and there's no need to
set it to null (which axis does by calling message.setMessageContext,
where message == null), so by commenting the offending line the notify
implementation no longer faults and the reply is HTTP 202 (I haven't
checked the specs, but everything seems to be OK from the client side).
The patch is attached (it's text and easy to read by humans if you don't
want to patch -p1 < wsrf-1.1.patch). Oh, also the build process is
broken, so the patch includes my hacks to make it work on my machine
(well, it works after manually downloading xmlbeans, renaming
jsr173_0.1_api.jar to jsr173-0.1_api.jar and copying it to the maven
repository in the xmlbeans directory, but hey... it builds).
Yours,
Cipi
P.S. Is there any activity on this project? Because the #apache-ws
channel is empty, mailing lists are low on info, bug tracking DBs seem
to be deserted by maintainers, the source distribution cannot be built etc.
Re: Bug in WSRF for 1-way MEPs
Posted by Ciprian Ciubotariu <ci...@softnrg.dnttm.ro>.
Great! Happy to contribute.
Cipi
Ian Springer wrote:
> Hi Cipi,
>
> Thanks, I've applied your patch.
>
> It looks like someone removed the jsr173 API jar from
> http://www.ibiblio.org/maven/xmlbeans/jars/, but I discovered
> http://www.ibiblio.org/maven/stax/jars/stax-api-1.0.jar, which ought
> to be a suitable replacement. I modified the WSRF and Pubscribe
> project.xml's to point to that location.
>
> As for the recent lack of activity in the project, I can only speak
> for those committers employed by HP. We've been unable to devote much
> time to the project recently because our management has been pulling
> us in other directions. We hope to be able to eventually become more
> active again, but in the meantime, we'll at least try to stay on top
> of the mailing lists and bugs in JIRA.
>
> Regards,
> Ian
>
> Ciprian Ciubotariu wrote:
>
>> Hi.
>>
>> I've corrected the ResourceHandler in WSRF-1.1 to no longer fault on
>> 1-way MEPs (like the standard notify message in WS-Notification
>> NotificationConsumer interface, for instance). Apparently the response
>> message in the messageContext is already null, and there's no need to
>> set it to null (which axis does by calling message.setMessageContext,
>> where message == null), so by commenting the offending line the notify
>> implementation no longer faults and the reply is HTTP 202 (I haven't
>> checked the specs, but everything seems to be OK from the client side).
>>
>> The patch is attached (it's text and easy to read by humans if you don't
>> want to patch -p1 < wsrf-1.1.patch). Oh, also the build process is
>> broken, so the patch includes my hacks to make it work on my machine
>> (well, it works after manually downloading xmlbeans, renaming
>> jsr173_0.1_api.jar to jsr173-0.1_api.jar and copying it to the maven
>> repository in the xmlbeans directory, but hey... it builds).
>>
>> Yours,
>>
>> Cipi
>>
>> P.S. Is there any activity on this project? Because the #apache-ws
>> channel is empty, mailing lists are low on info, bug tracking DBs seem
>> to be deserted by maintainers, the source distribution cannot be
>> built etc.
>>
>> ------------------------------------------------------------------------
>>
>> diff -Naur wsrf-src-1.1/project.xml wsrf-src-1.1-corrected/project.xml
>> --- wsrf-src-1.1/project.xml 2005-10-25 12:37:10.000000000 +0300
>> +++ wsrf-src-1.1-corrected/project.xml 2005-11-18
>> 15:32:49.014558300 +0200
>> @@ -451,8 +451,8 @@
>>
>> <dependency>
>> <groupId>xmlbeans</groupId>
>> - <artifactId>xmlbeans-jsr173-api</artifactId>
>> - <version>2.0-dev</version>
>> + <artifactId>jsr173</artifactId>
>> + <version>1.0_api</version>
>> <url>http://xmlbeans.apache.org/</url>
>> <properties>
>> <license>ApacheLicense-2.0.txt</license>
>> diff -Naur
>> wsrf-src-1.1/src/java/org/apache/ws/resource/handler/ResourceHandler.java
>> wsrf-src-1.1-corrected/src/java/org/apache/ws/resource/handler/ResourceHandler.java
>>
>> ---
>> wsrf-src-1.1/src/java/org/apache/ws/resource/handler/ResourceHandler.java
>> 2005-10-25 12:37:40.000000000 +0300
>> +++
>> wsrf-src-1.1-corrected/src/java/org/apache/ws/resource/handler/ResourceHandler.java
>> 2005-11-18 15:48:29.271737100 +0200
>> @@ -236,7 +236,7 @@
>> else // one-way MEP
>> {
>> // a null message tells the SOAP engine to return an
>> empty HTTP response with a 202 status code
>> - ( (SOAPMessageContext) msgContext ).setMessage( null );
>> +// ( (SOAPMessageContext) msgContext ).setMessage( null );
>> }
>> }
>> catch ( Exception e )
>>
>
>
Re: Bug in WSRF for 1-way MEPs
Posted by Ian Springer <ip...@apache.org>.
Hi Cipi,
Thanks, I've applied your patch.
It looks like someone removed the jsr173 API jar from
http://www.ibiblio.org/maven/xmlbeans/jars/, but I discovered
http://www.ibiblio.org/maven/stax/jars/stax-api-1.0.jar, which ought to
be a suitable replacement. I modified the WSRF and Pubscribe
project.xml's to point to that location.
As for the recent lack of activity in the project, I can only speak for
those committers employed by HP. We've been unable to devote much time
to the project recently because our management has been pulling us in
other directions. We hope to be able to eventually become more active
again, but in the meantime, we'll at least try to stay on top of the
mailing lists and bugs in JIRA.
Regards,
Ian
Ciprian Ciubotariu wrote:
> Hi.
>
> I've corrected the ResourceHandler in WSRF-1.1 to no longer fault on
> 1-way MEPs (like the standard notify message in WS-Notification
> NotificationConsumer interface, for instance). Apparently the response
> message in the messageContext is already null, and there's no need to
> set it to null (which axis does by calling message.setMessageContext,
> where message == null), so by commenting the offending line the notify
> implementation no longer faults and the reply is HTTP 202 (I haven't
> checked the specs, but everything seems to be OK from the client side).
>
> The patch is attached (it's text and easy to read by humans if you don't
> want to patch -p1 < wsrf-1.1.patch). Oh, also the build process is
> broken, so the patch includes my hacks to make it work on my machine
> (well, it works after manually downloading xmlbeans, renaming
> jsr173_0.1_api.jar to jsr173-0.1_api.jar and copying it to the maven
> repository in the xmlbeans directory, but hey... it builds).
>
> Yours,
>
> Cipi
>
> P.S. Is there any activity on this project? Because the #apache-ws
> channel is empty, mailing lists are low on info, bug tracking DBs seem
> to be deserted by maintainers, the source distribution cannot be built etc.
>
> ------------------------------------------------------------------------
>
> diff -Naur wsrf-src-1.1/project.xml wsrf-src-1.1-corrected/project.xml
> --- wsrf-src-1.1/project.xml 2005-10-25 12:37:10.000000000 +0300
> +++ wsrf-src-1.1-corrected/project.xml 2005-11-18 15:32:49.014558300 +0200
> @@ -451,8 +451,8 @@
>
> <dependency>
> <groupId>xmlbeans</groupId>
> - <artifactId>xmlbeans-jsr173-api</artifactId>
> - <version>2.0-dev</version>
> + <artifactId>jsr173</artifactId>
> + <version>1.0_api</version>
> <url>http://xmlbeans.apache.org/</url>
> <properties>
> <license>ApacheLicense-2.0.txt</license>
> diff -Naur wsrf-src-1.1/src/java/org/apache/ws/resource/handler/ResourceHandler.java wsrf-src-1.1-corrected/src/java/org/apache/ws/resource/handler/ResourceHandler.java
> --- wsrf-src-1.1/src/java/org/apache/ws/resource/handler/ResourceHandler.java 2005-10-25 12:37:40.000000000 +0300
> +++ wsrf-src-1.1-corrected/src/java/org/apache/ws/resource/handler/ResourceHandler.java 2005-11-18 15:48:29.271737100 +0200
> @@ -236,7 +236,7 @@
> else // one-way MEP
> {
> // a null message tells the SOAP engine to return an empty HTTP response with a 202 status code
> - ( (SOAPMessageContext) msgContext ).setMessage( null );
> +// ( (SOAPMessageContext) msgContext ).setMessage( null );
> }
> }
> catch ( Exception e )
>
---------------------------------------------------------------------
To unsubscribe, e-mail: wsrf-user-unsubscribe@ws.apache.org
For additional commands, e-mail: wsrf-user-help@ws.apache.org
Re: Bug in WSRF for 1-way MEPs
Posted by Ian Springer <ip...@apache.org>.
Hi Cipi,
Thanks, I've applied your patch.
It looks like someone removed the jsr173 API jar from
http://www.ibiblio.org/maven/xmlbeans/jars/, but I discovered
http://www.ibiblio.org/maven/stax/jars/stax-api-1.0.jar, which ought to
be a suitable replacement. I modified the WSRF and Pubscribe
project.xml's to point to that location.
As for the recent lack of activity in the project, I can only speak for
those committers employed by HP. We've been unable to devote much time
to the project recently because our management has been pulling us in
other directions. We hope to be able to eventually become more active
again, but in the meantime, we'll at least try to stay on top of the
mailing lists and bugs in JIRA.
Regards,
Ian
Ciprian Ciubotariu wrote:
> Hi.
>
> I've corrected the ResourceHandler in WSRF-1.1 to no longer fault on
> 1-way MEPs (like the standard notify message in WS-Notification
> NotificationConsumer interface, for instance). Apparently the response
> message in the messageContext is already null, and there's no need to
> set it to null (which axis does by calling message.setMessageContext,
> where message == null), so by commenting the offending line the notify
> implementation no longer faults and the reply is HTTP 202 (I haven't
> checked the specs, but everything seems to be OK from the client side).
>
> The patch is attached (it's text and easy to read by humans if you don't
> want to patch -p1 < wsrf-1.1.patch). Oh, also the build process is
> broken, so the patch includes my hacks to make it work on my machine
> (well, it works after manually downloading xmlbeans, renaming
> jsr173_0.1_api.jar to jsr173-0.1_api.jar and copying it to the maven
> repository in the xmlbeans directory, but hey... it builds).
>
> Yours,
>
> Cipi
>
> P.S. Is there any activity on this project? Because the #apache-ws
> channel is empty, mailing lists are low on info, bug tracking DBs seem
> to be deserted by maintainers, the source distribution cannot be built etc.
>
> ------------------------------------------------------------------------
>
> diff -Naur wsrf-src-1.1/project.xml wsrf-src-1.1-corrected/project.xml
> --- wsrf-src-1.1/project.xml 2005-10-25 12:37:10.000000000 +0300
> +++ wsrf-src-1.1-corrected/project.xml 2005-11-18 15:32:49.014558300 +0200
> @@ -451,8 +451,8 @@
>
> <dependency>
> <groupId>xmlbeans</groupId>
> - <artifactId>xmlbeans-jsr173-api</artifactId>
> - <version>2.0-dev</version>
> + <artifactId>jsr173</artifactId>
> + <version>1.0_api</version>
> <url>http://xmlbeans.apache.org/</url>
> <properties>
> <license>ApacheLicense-2.0.txt</license>
> diff -Naur wsrf-src-1.1/src/java/org/apache/ws/resource/handler/ResourceHandler.java wsrf-src-1.1-corrected/src/java/org/apache/ws/resource/handler/ResourceHandler.java
> --- wsrf-src-1.1/src/java/org/apache/ws/resource/handler/ResourceHandler.java 2005-10-25 12:37:40.000000000 +0300
> +++ wsrf-src-1.1-corrected/src/java/org/apache/ws/resource/handler/ResourceHandler.java 2005-11-18 15:48:29.271737100 +0200
> @@ -236,7 +236,7 @@
> else // one-way MEP
> {
> // a null message tells the SOAP engine to return an empty HTTP response with a 202 status code
> - ( (SOAPMessageContext) msgContext ).setMessage( null );
> +// ( (SOAPMessageContext) msgContext ).setMessage( null );
> }
> }
> catch ( Exception e )
>