You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2015/09/17 23:49:23 UTC

Review Request 38471: Fixed MESOS-3430 by making the sandbox/work directory mount as shared and slave.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38471/
-----------------------------------------------------------

Review request for mesos, haosdent huang, Timothy Chen, and Jiang Yan Xu.


Bugs: MESOS-3430
    https://issues.apache.org/jira/browse/MESOS-3430


Repository: mesos


Description
-------

Fixed MESOS-3430 by making the sandbox/work directory mount as shared and slave.


Diffs
-----

  src/slave/containerizer/isolators/filesystem/linux.cpp b6746345b70b462123c3254065e4f09a42f45e5b 

Diff: https://reviews.apache.org/r/38471/diff/


Testing
-------

sudo make check

Tested on a box with '/' marked as a shared mount.


Thanks,

Jie Yu


Re: Review Request 38471: Fixed MESOS-3430 by making the sandbox/work directory mount as shared and slave.

Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38471/#review99454
-----------------------------------------------------------

Ship it!


Ship It!

- Jiang Yan Xu


On Sept. 17, 2015, 2:59 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38471/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2015, 2:59 p.m.)
> 
> 
> Review request for mesos, haosdent huang, Timothy Chen, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-3430
>     https://issues.apache.org/jira/browse/MESOS-3430
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed MESOS-3430 by making the sandbox/work directory mount as shared and slave.
> 
> 'Shared and slave' is a state, see https://www.kernel.org/doc/Documentation/filesystems/sharedsubtree.txt
> 
> This is mainly for those systems that mark '/' as a shared mount by default.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/isolators/filesystem/linux.cpp b6746345b70b462123c3254065e4f09a42f45e5b 
> 
> Diff: https://reviews.apache.org/r/38471/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> Tested on a box with '/' marked as a shared mount.
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Re: Review Request 38471: Fixed MESOS-3430 by making the sandbox/work directory mount as shared and slave.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38471/
-----------------------------------------------------------

(Updated Sept. 17, 2015, 9:59 p.m.)


Review request for mesos, haosdent huang, Timothy Chen, and Jiang Yan Xu.


Bugs: MESOS-3430
    https://issues.apache.org/jira/browse/MESOS-3430


Repository: mesos


Description (updated)
-------

Fixed MESOS-3430 by making the sandbox/work directory mount as shared and slave.

'Shared and slave' is a state, see https://www.kernel.org/doc/Documentation/filesystems/sharedsubtree.txt

This is mainly for those systems that mark '/' as a shared mount by default.


Diffs
-----

  src/slave/containerizer/isolators/filesystem/linux.cpp b6746345b70b462123c3254065e4f09a42f45e5b 

Diff: https://reviews.apache.org/r/38471/diff/


Testing
-------

sudo make check

Tested on a box with '/' marked as a shared mount.


Thanks,

Jie Yu