You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@orc.apache.org by piyush-mukati <gi...@git.apache.org> on 2017/11/15 05:31:51 UTC

[GitHub] orc pull request #190: ORC-264 schema evolution columns name comparising is ...

GitHub user piyush-mukati opened a pull request:

    https://github.com/apache/orc/pull/190

    ORC-264 schema evolution columns name comparising is case unaware

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/piyush-mukati/orc ORC-264

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/orc/pull/190.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #190
    
----
commit 4372478aecfa9f6a7e017a830653f88a973642cc
Author: piyush.mukati <pi...@gmail.com>
Date:   2017-11-15T05:30:43Z

    ORC-264 schema evolution columns name comparising is case unaware

----


---

[GitHub] orc issue #190: ORC-264 schema evolution columns name comparising is case un...

Posted by piyush-mukati <gi...@git.apache.org>.

Github user piyush-mukati commented on the issue:

    https://github.com/apache/orc/pull/190
  
    @owen-hortonworks  I have added the suggested change, please review.


---

[GitHub] orc pull request #190: ORC-264 schema evolution columns name comparising is ...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/orc/pull/190


---

[GitHub] orc issue #190: ORC-264 schema evolution columns name comparising is case un...

Posted by owen-hortonworks <gi...@git.apache.org>.

Github user owen-hortonworks commented on the issue:

    https://github.com/apache/orc/pull/190
  
    Unfortunately, this would break the non-sql clients. Looking more into Hive's behavior, it currently does:
    * lowercases all column names
    * preserves all struct field names
    
    That makes a mess. I'd propose that we add a new option for readers that makes schema evolution lowercase everything and Hive should always set that option.


---