You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "davidhcoe (via GitHub)" <gi...@apache.org> on 2025/01/21 04:06:40 UTC
[PR] feat(csharp/drivers/BigQuery): use a default project ID if one is not specified [arrow-adbc]
davidhcoe opened a new pull request, #2471:
URL: https://github.com/apache/arrow-adbc/pull/2471
- No longer requires a project ID to be specified in the parameters
- If not specified, will use a default project ID (same as the Go driver)
- Adds parameter to include the public project ID if desired
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(csharp/src/Drivers/BigQuery): use a default project ID if one is not specified [arrow-adbc]
Posted by "CurtHagenlocher (via GitHub)" <gi...@apache.org>.
CurtHagenlocher merged PR #2471:
URL: https://github.com/apache/arrow-adbc/pull/2471
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(csharp/src/Drivers/BigQuery): use a default project ID if one is not specified [arrow-adbc]
Posted by "davidhcoe (via GitHub)" <gi...@apache.org>.
davidhcoe commented on code in PR #2471:
URL: https://github.com/apache/arrow-adbc/pull/2471#discussion_r1923715196
##########
csharp/src/Drivers/BigQuery/BigQueryConnection.cs:
##########
@@ -308,11 +316,20 @@ private IArrowArray[] GetCatalogs(
if (catalogs != null)
{
- foreach (CloudProject catalog in catalogs)
+ List<string> projectIds = catalogs.Select(x => x.ProjectId).ToList();
+
+ string publicProjectId = "bigquery-public-data";
Review Comment:
updated in latest PR
##########
csharp/src/Drivers/BigQuery/BigQueryConnection.cs:
##########
@@ -994,7 +1012,7 @@ public override AdbcStatement CreateStatement()
{
if (this.credential == null)
{
- throw new InvalidOperationException();
+ throw new InvalidOperationException("A credential must be set");
Review Comment:
updated in latest PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(csharp/src/Drivers/BigQuery): use a default project ID if one is not specified [arrow-adbc]
Posted by "CurtHagenlocher (via GitHub)" <gi...@apache.org>.
CurtHagenlocher commented on code in PR #2471:
URL: https://github.com/apache/arrow-adbc/pull/2471#discussion_r1923051953
##########
csharp/src/Drivers/BigQuery/BigQueryConnection.cs:
##########
@@ -994,7 +1012,7 @@ public override AdbcStatement CreateStatement()
{
if (this.credential == null)
{
- throw new InvalidOperationException();
+ throw new InvalidOperationException("A credential must be set");
Review Comment:
Should this be an `AdbcException`? We could set the status code to `AdbcStatusCode.Unauthenticated`.
##########
csharp/src/Drivers/BigQuery/BigQueryConnection.cs:
##########
@@ -308,11 +316,20 @@ private IArrowArray[] GetCatalogs(
if (catalogs != null)
{
- foreach (CloudProject catalog in catalogs)
+ List<string> projectIds = catalogs.Select(x => x.ProjectId).ToList();
+
+ string publicProjectId = "bigquery-public-data";
Review Comment:
consider making const and moving alongside other consts like `infoDriverName`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org