You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@eventmesh.apache.org by "Alonexc (via GitHub)" <gi...@apache.org> on 2023/04/27 03:00:35 UTC

[GitHub] [eventmesh] Alonexc opened a new issue, #3833: [Enhancement] Do some code optimization.[ZookeeperRegistryService]

Alonexc opened a new issue, #3833:
URL: https://github.com/apache/eventmesh/issues/3833

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/eventmesh/issues?q=is%3Aissue) and found no similar issues.
   
   
   ### Enhancement Request
   
   ![image](https://user-images.githubusercontent.com/91315508/234748059-f7f2782e-acb6-4dd4-b0e2-b75b320550bf.png)
   ![image](https://user-images.githubusercontent.com/91315508/234748070-4d456d98-8277-45c8-a9ff-e46bc66bcbaf.png)
   ![image](https://user-images.githubusercontent.com/91315508/234748075-59bfd2a8-9e3d-4990-88f3-540f2a36c5e4.png)
   ![image](https://user-images.githubusercontent.com/91315508/234748083-26e6925f-b668-4619-ab5d-b528d8e7cee6.png)
   located at:
   eventmesh-registry-plugin/eventmesh-registry-zookeeper/src/main/java/org/apache/eventmesh/registry/zookeeper/service/ZookeeperRegistryService.java line 63,143-164,192-213,227,298.
   
   
   ### Describe the solution you'd like
   
   a. Change to `private` modifier.
   b. Repeat code extraction as method.
   ![image](https://user-images.githubusercontent.com/91315508/234748118-16c6c0f8-5a2a-4060-ba9a-30afba792cd7.png)
   ![image](https://user-images.githubusercontent.com/91315508/234748124-8bca792a-d2e6-4563-8142-c8bd42f620de.png)
   
   c. Replace “null” Collections.emptyXXXX ().
   ![image](https://user-images.githubusercontent.com/91315508/234748141-65d0d933-5098-49dd-9ba9-afe84eb770a8.png)
   ![image](https://user-images.githubusercontent.com/91315508/234748157-a2c590ae-57cd-41b2-8e2a-337b87378f59.png)
   
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org

Re: [I] [Enhancement] Do some code optimization.[ZookeeperMetaService] (eventmesh)

Posted by "Alonexc (via GitHub)" <gi...@apache.org>.
Alonexc commented on issue #3833:
URL: https://github.com/apache/eventmesh/issues/3833#issuecomment-1966146793

   Yes, the location may have changed due to updates to the code module, this looks unfinished, welcome to the eventmesh community.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org

Re: [I] [Enhancement] Do some code optimization.[ZookeeperMetaService] (eventmesh)

Posted by "Ish1yu (via GitHub)" <gi...@apache.org>.
Ish1yu commented on issue #3833:
URL: https://github.com/apache/eventmesh/issues/3833#issuecomment-1965669228

   Hello, I am a beginner in eventmesh. Upon seeing the problem described in this issue, I wonder if eventmesh has already been refactored. I couldn't find the location of eventmesh-registry-zookeeper, but I found one located in eventmesh metaeventmesh-meta\eventmesh-meta-zookeeper\src\main\java\org\apache\eventmesh\meta\zookeeper\service\ZookeeperMetaService. Do I need to modify it here?
   
   Meanwhile, regarding the document "Quick Start", I think the description of meta (Registry Meta Service) is too simple. I only understood it based on the code. Can I try to improve the Chinese description of Quick Start in the document?（https://eventmesh.apache.org/zh/docs/instruction/runtime）


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org

Re: [I] [Enhancement] Do some code optimization.[ZookeeperMetaService] (eventmesh)

Posted by "mxsm (via GitHub)" <gi...@apache.org>.
mxsm closed issue #3833: [Enhancement] Do some code optimization.[ZookeeperMetaService]
URL: https://github.com/apache/eventmesh/issues/3833


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org