You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@brooklyn.apache.org by he...@apache.org on 2016/02/01 18:44:05 UTC

[05/50] brooklyn-docs git commit: code review comments, hopefully address some of the WTF's around logging!

code review comments, hopefully address some of the WTF's around logging!


Project: http://git-wip-us.apache.org/repos/asf/brooklyn-docs/repo
Commit: http://git-wip-us.apache.org/repos/asf/brooklyn-docs/commit/4070ad2e
Tree: http://git-wip-us.apache.org/repos/asf/brooklyn-docs/tree/4070ad2e
Diff: http://git-wip-us.apache.org/repos/asf/brooklyn-docs/diff/4070ad2e

Branch: refs/heads/0.6.0
Commit: 4070ad2e98eedccd755a89c214a6912c92777af3
Parents: f0fe568
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Authored: Mon Sep 23 09:56:06 2013 +0100
Committer: Alex Heneveld <al...@cloudsoftcorp.com>
Committed: Mon Sep 23 10:35:56 2013 +0100

----------------------------------------------------------------------
 docs/dev/tips/logging.md | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/brooklyn-docs/blob/4070ad2e/docs/dev/tips/logging.md
----------------------------------------------------------------------
diff --git a/docs/dev/tips/logging.md b/docs/dev/tips/logging.md
index 02d82c3..927fd0b 100644
--- a/docs/dev/tips/logging.md
+++ b/docs/dev/tips/logging.md
@@ -123,3 +123,18 @@ The only differences of the ``logback-test.xml`` configuration is that:
 * You may find that your IDE logs to a file ``brooklyn-tests.log`` 
   if it doesn't distinguish between test build classpaths and normal classpaths.
 
+* Logging configuration using file overrides such as this is very sensitive to
+  classpath order. To get a separate `brooklyn-tests.log` file during testing,
+  for example, the `brooklyn-test-support` project with scope `test` must be
+  declared as a dependency *before* `brooklyn-logback-includes`, due to the way
+  both files declare `logback-appender-file.xml`.
+  
+* Similarly note that the `logback-custom.xml` file is included *after* 
+  logging categories and levels are declared, but before appenders are declared,
+  so that logging levels declared in that file dominate, and that 
+  properties from that file apply to appenders.
+
+* Finally remember this is open to improvement. It's the best system we've found
+  so far but we welcome advice. In particular if it could be possible to include
+  files from the classpath with wildcards in alphabetical order, we'd be able
+  to remove some of the quirks listed above (though at a cost of some complexity!).