[GitHub] [superset] ktmud commented on a diff in pull request #19703: chore(build): upgrade less-loader

[GitBox <gi...@apache.org>]

ktmud commented on code in PR #19703:
URL: https://github.com/apache/superset/pull/19703#discussion_r850566043


##########
superset-frontend/tools/eslint-plugin-theme-colors/package.json:
##########
@@ -9,9 +9,5 @@
   "keywords": [],
   "license": "Apache-2.0",
   "author": "Apache",
-  "dependencies": {},
-  "engines": {
-    "node": "^16.9.1",
-    "npm": "^7.5.4"

Review Comment:
   Yeah, this package itself is very simple and it's only used internally. I don't think the engine requirement is necessary.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org