Salesforce Hook/Operator

[Jon Nalley <jn...@truecar.com>]

Hi,

I noticed that there is a sales force hook included in the Airflow repo:
https://github.com/apache/incubator-airflow/blob/master/airflow/contrib/hooks/salesforce_hook.py

There is also a salesforce hook and operator in the salesforce_plugin repo:
https://github.com/airflow-plugins/salesforce_plugin

Is one preferred over the other?

Thanks!

Re: Salesforce Hook/Operator

[Daniel Cohen <da...@cloudinary.com>]

I used  airflow-plugins/salesforce_plugin
<https://github.com/airflow-plugins/salesforce_plugin> as a base for my
work.
I disregarded the hook in the repo since it didn't work and used the OOTB
hook
<https://github.com/apache/incubator-airflow/blob/master/airflow/contrib/hooks/salesforce_hook.py>
.
The operator (SalesforceToS3Operator
<https://github.com/CloudinaryLtd/salesforce_plugin/blob/master/operators/salesforce_to_s3_operator.py#L60>)
on the other hand is pretty useful and there is not equivalent in
apache-airflow repo.
I eventually contributed everything back
to airflow-plugins/salesforce_plugin so comments or questions are welcome.

d.



On Tue, Sep 11, 2018 at 7:53 PM Taylor Edmiston <te...@gmail.com> wrote:

> The version in airflow-plugins/salesforce_plugin is borrowed from the one
> in airflow.contrib, so I would prefer the official one.
>
> If you have time to test, feel free to send us a PR that upgrades to the
> latest stable version (looks like some changes are on master but not
> v1-10-stable) from contrib, or removes the forked hook from that plugin and
> instead reference the official one.  On GitHub you can tag
> @benjamingregory @andscoop
> or me (@tedmiston) for review.
>
> *Taylor Edmiston*
> Blog <https://blog.tedmiston.com/> | CV
> <https://stackoverflow.com/cv/taylor> | LinkedIn
> <https://www.linkedin.com/in/tedmiston/> | AngelList
> <https://angel.co/taylor> | Stack Overflow
> <https://stackoverflow.com/users/149428/taylor-edmiston>
>
>
>
> On Mon, Sep 10, 2018 at 5:12 PM Jon Nalley <jn...@truecar.com> wrote:
>
> > Hi,
> >
> > I noticed that there is a sales force hook included in the Airflow repo:
> >
> >
> https://github.com/apache/incubator-airflow/blob/master/airflow/contrib/hooks/salesforce_hook.py
> >
> > There is also a salesforce hook and operator in the salesforce_plugin
> repo:
> > https://github.com/airflow-plugins/salesforce_plugin
> >
> > Is one preferred over the other?
> >
> > Thanks!
> >
>


-- 
daniel cohen
+972-(0)54-4799-147

Re: Salesforce Hook/Operator

[Taylor Edmiston <te...@gmail.com>]

The version in airflow-plugins/salesforce_plugin is borrowed from the one
in airflow.contrib, so I would prefer the official one.

If you have time to test, feel free to send us a PR that upgrades to the
latest stable version (looks like some changes are on master but not
v1-10-stable) from contrib, or removes the forked hook from that plugin and
instead reference the official one.  On GitHub you can tag
@benjamingregory @andscoop
or me (@tedmiston) for review.

*Taylor Edmiston*
Blog <https://blog.tedmiston.com/> | CV
<https://stackoverflow.com/cv/taylor> | LinkedIn
<https://www.linkedin.com/in/tedmiston/> | AngelList
<https://angel.co/taylor> | Stack Overflow
<https://stackoverflow.com/users/149428/taylor-edmiston>



On Mon, Sep 10, 2018 at 5:12 PM Jon Nalley <jn...@truecar.com> wrote:

> Hi,
>
> I noticed that there is a sales force hook included in the Airflow repo:
>
> https://github.com/apache/incubator-airflow/blob/master/airflow/contrib/hooks/salesforce_hook.py
>
> There is also a salesforce hook and operator in the salesforce_plugin repo:
> https://github.com/airflow-plugins/salesforce_plugin
>
> Is one preferred over the other?
>
> Thanks!
>