You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Ted Yu (JIRA)" <ji...@apache.org> on 2018/09/08 16:42:00 UTC

[jira] [Commented] (HBASE-21173) Remove the duplicate HRegion#close in TestHRegion

    [ https://issues.apache.org/jira/browse/HBASE-21173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16608119#comment-16608119 ] 

Ted Yu commented on HBASE-21173:
--------------------------------

{code}
     region.close();
     assertEquals(max, region.getMaxFlushedSeqId());
+    region = null;
{code}
I think the intention of HBASE-21138 is to let HBaseTestingUtility.closeRegionAndWAL do the cleanup.

Can you remove the duplicate region.close() call in these subtests ?

Thanks

> Remove the duplicate HRegion#close in TestHRegion
> -------------------------------------------------
>
>                 Key: HBASE-21173
>                 URL: https://issues.apache.org/jira/browse/HBASE-21173
>             Project: HBase
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 3.0.0, 2.2.0
>            Reporter: Guangxu Cheng
>            Assignee: Guangxu Cheng
>            Priority: Major
>         Attachments: HBASE-21173.master.001.patch
>
>
>  After HBASE-21138, some test methods still have the duplicate HRegion#close.So open this issue to remove the duplicate close



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)