You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by Guanghao Zhang <zg...@gmail.com> on 2017/07/16 14:16:03 UTC
One problem about document change
Hi, folks
Now I am working on the asynchronous admin which is part of asynchronous
client. The asynchronous client feature were pushed to branch-2 and master
branch. But one confuse thing is about the document change. The book site
is generated by master branch's code. So the document change should only be
pushed to master branch? Or it should be pushed to branch-2 and master
both, because this feature was merged to branch-2, too? I am not sure about
this, so look forward to you guys' idea. Thanks.
Guanghao Zhang
Re: One problem about document change
Posted by Sean Busbey <bu...@apache.org>.
yep!
On Mon, Jul 17, 2017 at 9:19 PM, Guanghao Zhang <zg...@gmail.com> wrote:
> Thanks for your explanation. So if we only push it to master branch, we
> should only add master tag to the fix versions of the document issue, right?
>
> 2017-07-17 22:00 GMT+08:00 Sean Busbey <bu...@apache.org>:
>
>> Contributors and committers usually only worry about making documentation
>> changes to the master branch.
>>
>> When it comes time to spin up release candidates for a new version, the
>> release manager usually copies the then-current state of documentation in
>> the master branch to the branch they'll be working from (in this case
>> branch-2). Sometimes that documentation is also tailored further to the
>> release line (e.g. to remove irrelevant feature discussion).
>>
>> On Sun, Jul 16, 2017 at 9:16 AM, Guanghao Zhang <zg...@gmail.com>
>> wrote:
>>
>> > Hi, folks
>> >
>> > Now I am working on the asynchronous admin which is part of asynchronous
>> > client. The asynchronous client feature were pushed to branch-2 and
>> master
>> > branch. But one confuse thing is about the document change. The book site
>> > is generated by master branch's code. So the document change should only
>> be
>> > pushed to master branch? Or it should be pushed to branch-2 and master
>> > both, because this feature was merged to branch-2, too? I am not sure
>> about
>> > this, so look forward to you guys' idea. Thanks.
>> >
>> > Guanghao Zhang
>> >
>>
Re: One problem about document change
Posted by Guanghao Zhang <zg...@gmail.com>.
Thanks for your explanation. So if we only push it to master branch, we
should only add master tag to the fix versions of the document issue, right?
2017-07-17 22:00 GMT+08:00 Sean Busbey <bu...@apache.org>:
> Contributors and committers usually only worry about making documentation
> changes to the master branch.
>
> When it comes time to spin up release candidates for a new version, the
> release manager usually copies the then-current state of documentation in
> the master branch to the branch they'll be working from (in this case
> branch-2). Sometimes that documentation is also tailored further to the
> release line (e.g. to remove irrelevant feature discussion).
>
> On Sun, Jul 16, 2017 at 9:16 AM, Guanghao Zhang <zg...@gmail.com>
> wrote:
>
> > Hi, folks
> >
> > Now I am working on the asynchronous admin which is part of asynchronous
> > client. The asynchronous client feature were pushed to branch-2 and
> master
> > branch. But one confuse thing is about the document change. The book site
> > is generated by master branch's code. So the document change should only
> be
> > pushed to master branch? Or it should be pushed to branch-2 and master
> > both, because this feature was merged to branch-2, too? I am not sure
> about
> > this, so look forward to you guys' idea. Thanks.
> >
> > Guanghao Zhang
> >
>
Re: One problem about document change
Posted by Sean Busbey <bu...@apache.org>.
Contributors and committers usually only worry about making documentation
changes to the master branch.
When it comes time to spin up release candidates for a new version, the
release manager usually copies the then-current state of documentation in
the master branch to the branch they'll be working from (in this case
branch-2). Sometimes that documentation is also tailored further to the
release line (e.g. to remove irrelevant feature discussion).
On Sun, Jul 16, 2017 at 9:16 AM, Guanghao Zhang <zg...@gmail.com> wrote:
> Hi, folks
>
> Now I am working on the asynchronous admin which is part of asynchronous
> client. The asynchronous client feature were pushed to branch-2 and master
> branch. But one confuse thing is about the document change. The book site
> is generated by master branch's code. So the document change should only be
> pushed to master branch? Or it should be pushed to branch-2 and master
> both, because this feature was merged to branch-2, too? I am not sure about
> this, so look forward to you guys' idea. Thanks.
>
> Guanghao Zhang
>