You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/27 11:14:34 UTC

[GitHub] [flink] zentol edited a comment on pull request #13796: [FLINK-19810][CI] Automatically run a basic NOTICE file check on CI

zentol edited a comment on pull request #13796:
URL: https://github.com/apache/flink/pull/13796#issuecomment-717170059


   I went through the issues the checker found, but most of them appear to be invalid:
   
   Contradicting statement(similar instances exist for kinesis, flink-oss-fs-hadoop, and possibly others):
   
   ```
   Could not find dependency org.apache.commons:commons-compress:1.20 in NOTICE file /__w/2/s/flink-formats/flink-sql-avro/src/main/resources/META-INF/NOTICE
   Dependency com.apache.commons:commons-compress:1.20 is mentioned in NOTICE file /__w/2/s/flink-formats/flink-sql-avro/src/main/resources/META-INF/NOTICE, but is not expected there
   ```
   
   The flink-dist warnings appear to be mostly incorrect; akka and slf4j are indeed bundled and hence should be listed in the NOTICE. I haven't checked other entries.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org