[GitHub] [accumulo] keith-turner commented on a diff in pull request #3720: Always use retry backoff in ZooReader(Writer)

["keith-turner (via GitHub)" <gi...@apache.org>]

keith-turner commented on code in PR #3720:
URL: https://github.com/apache/accumulo/pull/3720#discussion_r1304613468


##########
core/src/main/java/org/apache/accumulo/core/fate/zookeeper/ZooReader.java:
##########
@@ -184,7 +184,11 @@ protected <R> R retryLoopMutator(ZKFunctionMutator<R> zkf,
       try {
         return zkf.apply(getZooKeeper());
       } catch (KeeperException e) {
-        if (alwaysRetryCondition.test(e) || useRetryForTransient(retries, e)) {
+        if (alwaysRetryCondition.test(e)) {
+          retries.waitForNextAttempt(log,

Review Comment:
   Looking at RETRY_FACTORY at the top of the class it constructs a retry with `maxRetries(10)`.  Would this mean a different retry factory is needed for the always retry case?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org