You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kudu.apache.org by mp...@apache.org on 2016/07/12 07:45:36 UTC
[1/2] incubator-kudu git commit: Update docs on how to run gcovr
Repository: incubator-kudu
Updated Branches:
refs/heads/master 1f8ab62ff -> 074f849c8
Update docs on how to run gcovr
Change-Id: I494136e20452b76572d753b54fc7a095aa54a69b
Reviewed-on: http://gerrit.cloudera.org:8080/3508
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Project: http://git-wip-us.apache.org/repos/asf/incubator-kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-kudu/commit/45a87a93
Tree: http://git-wip-us.apache.org/repos/asf/incubator-kudu/tree/45a87a93
Diff: http://git-wip-us.apache.org/repos/asf/incubator-kudu/diff/45a87a93
Branch: refs/heads/master
Commit: 45a87a9371e0885389f0c6b2a4e3875a9e1ea5ff
Parents: 1f8ab62
Author: Mike Percy <mp...@apache.org>
Authored: Sun Jun 26 18:28:45 2016 -0700
Committer: Mike Percy <mp...@apache.org>
Committed: Tue Jul 12 07:45:10 2016 +0000
----------------------------------------------------------------------
README.adoc | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/45a87a93/README.adoc
----------------------------------------------------------------------
diff --git a/README.adoc b/README.adoc
index fd19459..abb3479 100644
--- a/README.adoc
+++ b/README.adoc
@@ -218,8 +218,7 @@ $ gdb -ex 'set disable-randomization off' -ex 'b __tsan::PrintReport' ./some-tes
=== Generating code coverage reports
-In order to generate a code coverage report, you must build with gcc (not clang)
-and use the following flags:
+In order to generate a code coverage report, you must use the following flags:
[source,bash]
----
@@ -238,12 +237,15 @@ gcovr:
[source,bash]
----
-$ mkdir cov_html
$ cd build/coverage
-$ ../../thirdparty/gcovr-3.0/scripts/gcovr -r ../../src/ \
- --gcov-executable=../../build-support/llvm-gcov-wrapper
+$ mkdir cov_html
+$ ../../thirdparty/installed/bin/gcovr \
+ --gcov-executable=$(pwd)/../../build-support/llvm-gcov-wrapper \
+ --html --html-details -o cov_html/coverage.html
----
+Then open `cov_html/coverage.html` in your web browser.
+
=== Running lint checks
[2/2] incubator-kudu git commit: barrier.h: Add missing
thread_restrictions.h include
Posted by mp...@apache.org.
barrier.h: Add missing thread_restrictions.h include
This is required for ThreadRestrictions::AssertWaitAllowed().
Change-Id: I6eab8e9e9d69cea44eb62d01137040fe02043537
Reviewed-on: http://gerrit.cloudera.org:8080/3620
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Project: http://git-wip-us.apache.org/repos/asf/incubator-kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-kudu/commit/074f849c
Tree: http://git-wip-us.apache.org/repos/asf/incubator-kudu/tree/074f849c
Diff: http://git-wip-us.apache.org/repos/asf/incubator-kudu/diff/074f849c
Branch: refs/heads/master
Commit: 074f849c8e5967bb4265b0dc83e244354263b105
Parents: 45a87a9
Author: Mike Percy <mp...@apache.org>
Authored: Mon Jul 11 20:19:39 2016 -0700
Committer: Mike Percy <mp...@apache.org>
Committed: Tue Jul 12 07:45:18 2016 +0000
----------------------------------------------------------------------
src/kudu/util/barrier.h | 1 +
1 file changed, 1 insertion(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/074f849c/src/kudu/util/barrier.h
----------------------------------------------------------------------
diff --git a/src/kudu/util/barrier.h b/src/kudu/util/barrier.h
index 901d46d..88e5682 100644
--- a/src/kudu/util/barrier.h
+++ b/src/kudu/util/barrier.h
@@ -19,6 +19,7 @@
#include "kudu/gutil/macros.h"
#include "kudu/util/condition_variable.h"
#include "kudu/util/mutex.h"
+#include "kudu/util/thread_restrictions.h"
namespace kudu {