You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iceberg.apache.org by hu...@apache.org on 2025/11/18 05:10:52 UTC

(iceberg) branch main updated: Refactor: populate writeOptions in extraSnapshotMetadata using common util (#14604)

This is an automated email from the ASF dual-hosted git repository.

huaxingao pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/iceberg.git


The following commit(s) were added to refs/heads/main by this push:
     new 8c7ffec48f Refactor: populate writeOptions in extraSnapshotMetadata using common util (#14604)
8c7ffec48f is described below

commit 8c7ffec48ffd8d51e0ec7c8eb12d9aaeee214212
Author: yingjianwu98 <15...@users.noreply.github.com>
AuthorDate: Mon Nov 17 21:10:46 2025 -0800

    Refactor: populate writeOptions in extraSnapshotMetadata using common util (#14604)
    
    * small refactor for writeOptions when populating extraSnapshotMetadata to use common util
    
    * reformat
    
    ---------
    
    Co-authored-by: Yingjian Wu <yi...@netflix.com>
---
 .../src/main/java/org/apache/iceberg/spark/SparkWriteConf.java   | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/SparkWriteConf.java b/spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/SparkWriteConf.java
index c4f43d7b77..96131e0e56 100644
--- a/spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/SparkWriteConf.java
+++ b/spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/SparkWriteConf.java
@@ -261,13 +261,8 @@ public class SparkWriteConf {
             SparkSQLProperties.SNAPSHOT_PROPERTY_PREFIX));
 
     // Add write options, overriding session configuration if necessary
-    writeOptions.forEach(
-        (key, value) -> {
-          if (key.startsWith(SnapshotSummary.EXTRA_METADATA_PREFIX)) {
-            extraSnapshotMetadata.put(
-                key.substring(SnapshotSummary.EXTRA_METADATA_PREFIX.length()), value);
-          }
-        });
+    extraSnapshotMetadata.putAll(
+        PropertyUtil.propertiesWithPrefix(writeOptions, SnapshotSummary.EXTRA_METADATA_PREFIX));
 
     return extraSnapshotMetadata;
   }