You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by "ppkarwasz (via GitHub)" <gi...@apache.org> on 2023/03/03 21:01:10 UTC
[PR] Auto-merge Dependabot PRs (logging-log4j2)
ppkarwasz opened a new pull request, #1322:
URL: https://github.com/apache/logging-log4j2/pull/1322
If the build succeeds, we want to automatically merge Dependabot PRs. Exceptions to the rules should be explicitly written into `dependabot.yml` (i.e. do not close Dependabot PRs, add an exception).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Auto-merge Dependabot PRs (logging-log4j2)
Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz merged PR #1322:
URL: https://github.com/apache/logging-log4j2/pull/1322
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Auto-merge Dependabot PRs (logging-log4j2)
Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz commented on PR #1322:
URL: https://github.com/apache/logging-log4j2/pull/1322#issuecomment-1454870795
I am not sure if `branches-ignore` is what prevents the double run: I think that the "branch" setting checks the branch that was pushed (`2.x` in our case).
The `GITHUB_TOKEN` used by Github Actions does not trigger workflows according to https://docs.github.com/en/actions/security-guides/automatic-token-authentication, so no `push` event should be generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Auto-merge Dependabot PRs (logging-log4j2)
Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz commented on PR #1322:
URL: https://github.com/apache/logging-log4j2/pull/1322#issuecomment-1454895081
This CI should prove that merging the PR does not cause a second CI run: https://github.com/ppkarwasz/logging-log4j2/pull/310
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Auto-merge Dependabot PRs (logging-log4j2)
Posted by "vy (via GitHub)" <gi...@apache.org>.
vy commented on PR #1322:
URL: https://github.com/apache/logging-log4j2/pull/1322#issuecomment-1454866093
Great job @ppkarwasz! :100: AFAIK, this setup would run the build workflow twice: the 1st one while verifying the PR, and the 2nd one after merging it. You can avoid this by adding the following block to `build.yml`:
```
on:
push:
# Avoid workflow run for _merged_ `dependabot` PRs.
# They were (hopefully!) already tested in PR-triggered workflow.
branches-ignore: "dependabot/**"
```
See [my rotating-fos configuration](/rotating-fos/blob/master/.github/workflows/build.yml#L21) for an example.
You can this PR after this change, IMO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org