[jira] [Commented] (ORC-391) [C++] parseType does not accept underscore in the field name

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ORC-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16561972#comment-16561972 ] 

ASF GitHub Bot commented on ORC-391:
------------------------------------

Github user majetideepak commented on a diff in the pull request:

    https://github.com/apache/orc/pull/296#discussion_r206153654
  
    --- Diff: tools/test/TestCSVFileImport.cc ---
    @@ -53,3 +53,33 @@ TEST (TestCSVFileImport, test10rows) {
       EXPECT_EQ(expected, output);
       EXPECT_EQ("", error);
     }
    +
    +TEST (TestCSVFileImport, test10rows_underscore) {
    +  // create an ORC file from importing the CSV file
    +  const std::string pgm1 = findProgram("tools/src/csv-import");
    +  const std::string csvFile = findExample("TestCSVFileImport.test10rows.csv");
    +  const std::string orcFile = "/tmp/test_csv_import_test_10_rows.orc";
    +  const std::string schema = "struct<_a:bigint,b_:string,c:double>";
    --- End diff --
    
    Thanks for the test! can you rename `c` to `c_col`?


> [C++]  parseType does not accept underscore in the field name
> -------------------------------------------------------------
>
>                 Key: ORC-391
>                 URL: https://issues.apache.org/jira/browse/ORC-391
>             Project: ORC
>          Issue Type: Bug
>            Reporter: Zherui Cao
>            Priority: Minor
>             Fix For: 1.6.0
>
>
> Java does not have this restriction. The scope of this Jira is to allow this in the C++ implementation.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)