[GitHub] kasjer commented on a change in pull request #1448: Reduce ram usage in fcb

[GitBox <gi...@apache.org>]

kasjer commented on a change in pull request #1448: Reduce ram usage in fcb
URL: https://github.com/apache/mynewt-core/pull/1448#discussion_r225362799
 
 

 ##########
 File path: fs/fcb/include/fcb/fcb.h
 ##########
 @@ -36,33 +36,43 @@ extern "C" {
 
 #define FCB_MAX_LEN	(CHAR_MAX | CHAR_MAX << 7) /* Max length of element */
 
+#define FCB_SECTOR_OLDEST UINT16_MAX
+
 /**
- * Entry location is pointer to area (within fcb->f_sectors), and offset
- * within that area.
+ * Entry location point to sector, and offset
+ * within that sector.
  */
 struct fcb_entry {
-    struct flash_area *fe_area;	/* ptr to area within fcb->f_sectors */
-    uint32_t fe_elem_off;	/* start of entry */
-    uint32_t fe_data_off;	/* start of data */
+    struct sector_range *fe_range;  /* ptr to area within fcb->f_ranages */
+    uint16_t fe_sector;     /* sector number in fcb flash */
+    uint16_t fe_elem_off;	/* start of entry in sector */
 
 Review comment:
   done

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services