You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by minahlee <gi...@git.apache.org> on 2015/10/01 07:21:43 UTC
[GitHub] incubator-zeppelin pull request: [Zeppelin 329] Notebook copied in...
GitHub user minahlee opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/331
[Zeppelin 329] Notebook copied in file system level should be reflected in notebook list
This PR enables Zeppelin to reflect addition/changes/removal of `{ZEPPELIN_NOTEBOOK_DIR}/{notebookId}/note.json` on the file system without restarting ZeppelinServer.
To activate this functionality, user needs to set `ZEPPELIN_NOTEBOOK_GET_FROM_REPO` to be true in conf/zeppelin-env.sh.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/minahlee/incubator-zeppelin ZEPPELIN-329
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/331.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #331
----
commit 34f412b41c0871172721c590f5e1267fdb3f0694
Author: Mina Lee <mi...@nflabs.com>
Date: 2015-10-01T03:05:34Z
ZEPPELIN-329 Notebook copied in file system level should be reflected in notebook list
commit 82bbb57ed61fc68d64e58294652b0c8522160b2a
Author: Mina Lee <mi...@nflabs.com>
Date: 2015-10-01T03:07:54Z
Fix indentation
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [Zeppelin 329] Notebook copied in...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/331#issuecomment-147634464
Merging if there're no more discussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [Zeppelin 329] Notebook copied in...
Posted by minahlee <gi...@git.apache.org>.
Github user minahlee commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/331#issuecomment-145621950
Beacause PR will load notebooks from storage everytime client requests notebook list, which can be burden to Zeppelin with a bunch of notebooks. So I wanted to make as less effect as possible on current behavior. Would it be better to activate it by default?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [Zeppelin 329] Notebook copied in...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/331
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [Zeppelin 329] Notebook copied in...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/331#issuecomment-145209942
Nice improvement. Could you choose little more intuitive name than `ZEPPELIN_NOTEBOOK_GET_FROM_REPO` ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [Zeppelin 329] Notebook copied in...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/331#issuecomment-147167587
I think activating this function by default will brings some IO overhead in some cases. (large number of big notebooks). As @minahlee mentioned, it's better to keep it de-activated by default. When the implementation becomes more efficient it can be activated by default. That could be future work.
So, Looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [Zeppelin 329] Notebook copied in...
Posted by minahlee <gi...@git.apache.org>.
Github user minahlee commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/331#issuecomment-145493238
@Leemoonsoo @khalidhuseynov ready for review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [Zeppelin 329] Notebook copied in...
Posted by anthonycorbacho <gi...@git.apache.org>.
Github user anthonycorbacho commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/331#issuecomment-145711460
so why not using a watcher? like if someone drop a notebook in the notebook dir, you update the list of notebook.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [Zeppelin 329] Notebook copied in...
Posted by anthonycorbacho <gi...@git.apache.org>.
Github user anthonycorbacho commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/331#issuecomment-145587447
why do you need to activate this functionality? shouldnt be a expected behavior?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---