[jira] [Commented] (HBASE-14257) Periodic flusher only handles hbase:meta, not other system tables

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-14257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14906169#comment-14906169 ] 

Hadoop QA commented on HBASE-14257:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12762072/HBASE-14257.patch
  against master branch at commit 5b7894f92ba3e9ff700da1e9194ebb4774d8b71e.
  ATTACHMENT ID: 12762072

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new or modified tests.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0 2.7.1)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the total number of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     

     {color:red}-1 core zombie tests{color}.  There are 1 zombie test(s): 	at org.apache.hadoop.hbase.regionserver.TestHRegion.testWritesWhileScanning(TestHRegion.java:3890)

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/15711//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/15711//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/15711//artifact/patchprocess/checkstyle-aggregate.html

  Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/15711//console

This message is automatically generated.

> Periodic flusher only handles hbase:meta, not other system tables
> -----------------------------------------------------------------
>
>                 Key: HBASE-14257
>                 URL: https://issues.apache.org/jira/browse/HBASE-14257
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 2.0.0, 1.2.0
>            Reporter: Lars George
>            Assignee: Abhishek Singh Chouhan
>              Labels: beginner
>         Attachments: HBASE-14257.patch
>
>
> In {{HRegion.shouldFlush}} we have
> {code}
>     long modifiedFlushCheckInterval = flushCheckInterval;
>     if (getRegionInfo().isMetaRegion() &&
>         getRegionInfo().getReplicaId() == HRegionInfo.DEFAULT_REPLICA_ID) {
>       modifiedFlushCheckInterval = META_CACHE_FLUSH_INTERVAL;
>     }
> {code}
> That method is called by the {{PeriodicMemstoreFlusher}} thread, and prefers the {{hbase:meta}} only for faster flushing. It should be doing the same for other system tables. I suggest to use {{HRI.isSystemTable()}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)