[GitHub] dpogue commented on a change in pull request #655: Use custom Gradle properties to read SDK versions from config.xml

[GitBox <gi...@apache.org>]

dpogue commented on a change in pull request #655: Use custom Gradle properties to read SDK versions from config.xml
URL: https://github.com/apache/cordova-android/pull/655#discussion_r255291753
 
 

 ##########
 File path: bin/templates/cordova/lib/prepare.js
 ##########
 @@ -43,8 +43,16 @@ module.exports.prepare = function (cordovaProject, options) {
 
     this._config = updateConfigFilesFrom(cordovaProject.projectConfig, munger, this.locations);
 
+    // Prepare the min and target SDK version
+    const minSdkVersion = this._config.getPreference('android-minSdkVersion', 'android');
+    const targetSdkVersion = this._config.getPreference('android-targetSdkVersion', 'android');
+
+    let gradlePropertiesUserConfig = {};
+    if (minSdkVersion) gradlePropertiesUserConfig.minSdkVersion = minSdkVersion;
 
 Review comment:
   I believe we want the `cdv`-prefixed versions, because that's what [build.gradle is looking for](https://github.com/apache/cordova-android/blob/master/bin/templates/project/app/build.gradle#L46-L90) 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org