You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2023/06/08 05:32:17 UTC
[kudu-CR] [webserver] handlers for application/octet-stream content
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20023
Change subject: [webserver] handlers for application/octet-stream content
......................................................................
[webserver] handlers for application/octet-stream content
This patch introduces application/octet-stream (a.k.a. binary data)
handlers for the embedded web server.
As a particular application of the newly introduced feature, this patch
also adds /ipki-ca-cert-der endpoint to the master's embedded webserver.
It outputs the same IPKI CA certificate as the /ipki-ca-cert and
/ipki-ca-cert-pem endpoints, but in DER format. This will be used
in a changelist where Java client needs to import Kudu cluster's CA
certificate into its trust chain when using JWT for authentication.
As it turns out, the 'standard' security providers for Java runtime
don't provide enough functionality to conveniently work with X509 in PEM
format (yes, there is BouncyCastle, but I'm not sure we want to
introduce such a dependency just for the convenience of working with
certificates in PEM format).
To cover the newly introduced functionality, an extra test has been added
into security-itest and PeriodicWebUIChecker has been updated.
Change-Id: I894d8e00943617cb80ec5aa14a15db3448ad9252
---
M src/kudu/integration-tests/security-itest.cc
M src/kudu/master/master_path_handlers.cc
M src/kudu/master/master_path_handlers.h
M src/kudu/mini-cluster/webui_checker.h
M src/kudu/server/webserver.cc
M src/kudu/server/webserver.h
M src/kudu/util/web_callback_registry.h
7 files changed, 151 insertions(+), 23 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/23/20023/1
--
To view, visit http://gerrit.cloudera.org:8080/20023
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I894d8e00943617cb80ec5aa14a15db3448ad9252
Gerrit-Change-Number: 20023
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] [webserver] handlers for application/octet-stream content
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20023 )
Change subject: [webserver] handlers for application/octet-stream content
......................................................................
[webserver] handlers for application/octet-stream content
This patch introduces application/octet-stream (a.k.a. binary data)
handlers for the embedded web server.
As a particular application of the newly introduced feature, this patch
also adds /ipki-ca-cert-der endpoint to the master's embedded webserver.
It outputs the same IPKI CA certificate as the /ipki-ca-cert and
/ipki-ca-cert-pem endpoints, but in DER format. This will be used
in a changelist where Java client needs to import Kudu cluster's CA
certificate into its trust chain when using JWT for authentication.
As it turns out, the 'standard' security providers for Java runtime
don't provide enough functionality to conveniently work with X509 in PEM
format (yes, there is BouncyCastle, but I'm not sure we want to
introduce such a dependency just for the convenience of working with
certificates in PEM format at a few call sites in the Java client).
To cover the newly introduced functionality, an extra test has been added
into security-itest and PeriodicWebUIChecker has been updated.
Change-Id: I894d8e00943617cb80ec5aa14a15db3448ad9252
Reviewed-on: http://gerrit.cloudera.org:8080/20023
Tested-by: Kudu Jenkins
Reviewed-by: Zoltan Chovan <zc...@cloudera.com>
Reviewed-by: Attila Bukor <ab...@apache.org>
---
M src/kudu/integration-tests/security-itest.cc
M src/kudu/master/master_path_handlers.cc
M src/kudu/master/master_path_handlers.h
M src/kudu/mini-cluster/webui_checker.h
M src/kudu/server/webserver.cc
M src/kudu/server/webserver.h
M src/kudu/util/web_callback_registry.h
7 files changed, 154 insertions(+), 28 deletions(-)
Approvals:
Kudu Jenkins: Verified
Zoltan Chovan: Looks good to me, but someone else must approve
Attila Bukor: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/20023
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I894d8e00943617cb80ec5aa14a15db3448ad9252
Gerrit-Change-Number: 20023
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] [webserver] handlers for application/octet-stream content
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Zoltan Chovan, Attila Bukor, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20023
to look at the new patch set (#2).
Change subject: [webserver] handlers for application/octet-stream content
......................................................................
[webserver] handlers for application/octet-stream content
This patch introduces application/octet-stream (a.k.a. binary data)
handlers for the embedded web server.
As a particular application of the newly introduced feature, this patch
also adds /ipki-ca-cert-der endpoint to the master's embedded webserver.
It outputs the same IPKI CA certificate as the /ipki-ca-cert and
/ipki-ca-cert-pem endpoints, but in DER format. This will be used
in a changelist where Java client needs to import Kudu cluster's CA
certificate into its trust chain when using JWT for authentication.
As it turns out, the 'standard' security providers for Java runtime
don't provide enough functionality to conveniently work with X509 in PEM
format (yes, there is BouncyCastle, but I'm not sure we want to
introduce such a dependency just for the convenience of working with
certificates in PEM format).
To cover the newly introduced functionality, an extra test has been added
into security-itest and PeriodicWebUIChecker has been updated.
Change-Id: I894d8e00943617cb80ec5aa14a15db3448ad9252
---
M src/kudu/integration-tests/security-itest.cc
M src/kudu/master/master_path_handlers.cc
M src/kudu/master/master_path_handlers.h
M src/kudu/mini-cluster/webui_checker.h
M src/kudu/server/webserver.cc
M src/kudu/server/webserver.h
M src/kudu/util/web_callback_registry.h
7 files changed, 156 insertions(+), 28 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/23/20023/2
--
To view, visit http://gerrit.cloudera.org:8080/20023
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I894d8e00943617cb80ec5aa14a15db3448ad9252
Gerrit-Change-Number: 20023
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] [webserver] handlers for application/octet-stream content
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/20023 )
Change subject: [webserver] handlers for application/octet-stream content
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/20023
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I894d8e00943617cb80ec5aa14a15db3448ad9252
Gerrit-Change-Number: 20023
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Jun 2023 16:58:28 +0000
Gerrit-HasComments: No
[kudu-CR] [webserver] handlers for application/octet-stream content
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Zoltan Chovan, Attila Bukor, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20023
to look at the new patch set (#3).
Change subject: [webserver] handlers for application/octet-stream content
......................................................................
[webserver] handlers for application/octet-stream content
This patch introduces application/octet-stream (a.k.a. binary data)
handlers for the embedded web server.
As a particular application of the newly introduced feature, this patch
also adds /ipki-ca-cert-der endpoint to the master's embedded webserver.
It outputs the same IPKI CA certificate as the /ipki-ca-cert and
/ipki-ca-cert-pem endpoints, but in DER format. This will be used
in a changelist where Java client needs to import Kudu cluster's CA
certificate into its trust chain when using JWT for authentication.
As it turns out, the 'standard' security providers for Java runtime
don't provide enough functionality to conveniently work with X509 in PEM
format (yes, there is BouncyCastle, but I'm not sure we want to
introduce such a dependency just for the convenience of working with
certificates in PEM format at a few call sites in the Java client).
To cover the newly introduced functionality, an extra test has been added
into security-itest and PeriodicWebUIChecker has been updated.
Change-Id: I894d8e00943617cb80ec5aa14a15db3448ad9252
---
M src/kudu/integration-tests/security-itest.cc
M src/kudu/master/master_path_handlers.cc
M src/kudu/master/master_path_handlers.h
M src/kudu/mini-cluster/webui_checker.h
M src/kudu/server/webserver.cc
M src/kudu/server/webserver.h
M src/kudu/util/web_callback_registry.h
7 files changed, 154 insertions(+), 28 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/23/20023/3
--
To view, visit http://gerrit.cloudera.org:8080/20023
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I894d8e00943617cb80ec5aa14a15db3448ad9252
Gerrit-Change-Number: 20023
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] [webserver] handlers for application/octet-stream content
Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/20023 )
Change subject: [webserver] handlers for application/octet-stream content
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/20023
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I894d8e00943617cb80ec5aa14a15db3448ad9252
Gerrit-Change-Number: 20023
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Jun 2023 06:01:24 +0000
Gerrit-HasComments: No
[kudu-CR] [webserver] handlers for application/octet-stream content
Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/20023 )
Change subject: [webserver] handlers for application/octet-stream content
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/20023
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I894d8e00943617cb80ec5aa14a15db3448ad9252
Gerrit-Change-Number: 20023
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Jun 2023 14:48:40 +0000
Gerrit-HasComments: No