You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/03/12 13:30:22 UTC
[GitHub] [apisix-dashboard] stu01509 opened a new pull request #1580: fix: fix the upstream timeout unit
stu01509 opened a new pull request #1580:
URL: https://github.com/apache/apisix-dashboard/pull/1580
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [x] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [ ] Backport patches
- Related issues
Fix #1565
___
### Bugfix
- Description
- How to fix?
Change the upstream timeout unit to s.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun merged pull request #1580: fix: fix the upstream timeout unit
Posted by GitBox <gi...@apache.org>.
LiteSun merged pull request #1580:
URL: https://github.com/apache/apisix-dashboard/pull/1580
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1580: fix: fix the upstream timeout unit
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1580:
URL: https://github.com/apache/apisix-dashboard/pull/1580#issuecomment-797511954
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1580?src=pr&el=h1) Report
> Merging [#1580](https://codecov.io/gh/apache/apisix-dashboard/pull/1580?src=pr&el=desc) (bcc88cc) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/48e66cded1f4f7b67d37a9f1337fca492d6f44f5?el=desc) (48e66cd) will **decrease** coverage by `5.33%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1580?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1580 +/- ##
==========================================
- Coverage 71.50% 66.16% -5.34%
==========================================
Files 132 132
Lines 5341 5341
Branches 584 584
==========================================
- Hits 3819 3534 -285
- Misses 1277 1495 +218
- Partials 245 312 +67
```
| Flag | Coverage Δ | |
|---|---|---|
| backend-e2e-test | `60.74% <ø> (ø)` | |
| backend-e2e-test-ginkgo | `46.27% <ø> (ø)` | |
| backend-unit-test | `?` | |
| frontend-e2e-test | `73.21% <100.00%> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1580?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [web/src/components/Upstream/UpstreamForm.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1580/diff?src=pr&el=tree#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL1Vwc3RyZWFtRm9ybS50c3g=) | `62.01% <100.00%> (ø)` | |
| [api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1580/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==) | `0.00% <0.00%> (-64.29%)` | :arrow_down: |
| [api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1580/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==) | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
| [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1580/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | `57.44% <0.00%> (-34.05%)` | :arrow_down: |
| [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1580/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | `47.22% <0.00%> (-30.56%)` | :arrow_down: |
| [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1580/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `58.43% <0.00%> (-29.52%)` | :arrow_down: |
| [api/internal/filter/ip\_filter.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1580/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9pcF9maWx0ZXIuZ28=) | `48.71% <0.00%> (-23.08%)` | :arrow_down: |
| [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1580/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | `64.51% <0.00%> (-19.36%)` | :arrow_down: |
| [...pi/internal/handler/plugin\_config/plugin\_config.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1580/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luX2NvbmZpZy9wbHVnaW5fY29uZmlnLmdv) | `59.57% <0.00%> (-18.09%)` | :arrow_down: |
| [api/internal/handler/route/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1580/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGUvcm91dGUuZ28=) | `63.59% <0.00%> (-14.65%)` | :arrow_down: |
| ... and [13 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1580/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1580?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1580?src=pr&el=footer). Last update [48e66cd...bcc88cc](https://codecov.io/gh/apache/apisix-dashboard/pull/1580?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1580: fix: fix the upstream timeout unit
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1580:
URL: https://github.com/apache/apisix-dashboard/pull/1580#issuecomment-797511954
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1580?src=pr&el=h1) Report
> Merging [#1580](https://codecov.io/gh/apache/apisix-dashboard/pull/1580?src=pr&el=desc) (4a50bfd) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/e22de2966fe322ee26b8023e9a5e493cfa643535?el=desc) (e22de29) will **decrease** coverage by `14.80%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1580?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1580 +/- ##
===========================================
- Coverage 66.34% 51.54% -14.81%
===========================================
Files 46 37 -9
Lines 3019 2555 -464
===========================================
- Hits 2003 1317 -686
- Misses 768 1057 +289
+ Partials 248 181 -67
```
| Flag | Coverage Δ | |
|---|---|---|
| backend-e2e-test-ginkgo | `?` | |
| backend-unit-test | `51.54% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1580?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1580/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1580/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1580/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1580/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-67.29%)` | :arrow_down: |
| [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1580/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
| [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1580/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-52.11%)` | :arrow_down: |
| [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1580/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
| [api/internal/handler/server\_info/server\_info.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1580/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmVyX2luZm8vc2VydmVyX2luZm8uZ28=) | `57.14% <0.00%> (-33.34%)` | :arrow_down: |
| [api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1580/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==) | `0.00% <0.00%> (-33.34%)` | :arrow_down: |
| [api/internal/handler/consumer/consumer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1580/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvY29uc3VtZXIvY29uc3VtZXIuZ28=) | `63.82% <0.00%> (-27.66%)` | :arrow_down: |
| ... and [32 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1580/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1580?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1580?src=pr&el=footer). Last update [e22de29...4a50bfd](https://codecov.io/gh/apache/apisix-dashboard/pull/1580?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] stu01509 commented on pull request #1580: fix: fix the upstream timeout unit
Posted by GitBox <gi...@apache.org>.
stu01509 commented on pull request #1580:
URL: https://github.com/apache/apisix-dashboard/pull/1580#issuecomment-799355802
> hi, please sync codes from branch master.
Done!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] stu01509 commented on pull request #1580: fix: fix the upstream timeout unit
Posted by GitBox <gi...@apache.org>.
stu01509 commented on pull request #1580:
URL: https://github.com/apache/apisix-dashboard/pull/1580#issuecomment-799215549
Hi @liuxiran and @nic-chen
Update the commit, fix the **import_export_route.spec.js** compare file error.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] stu01509 commented on pull request #1580: fix: fix the upstream timeout unit
Posted by GitBox <gi...@apache.org>.
stu01509 commented on pull request #1580:
URL: https://github.com/apache/apisix-dashboard/pull/1580#issuecomment-798857957
Hi @liuxiran and @nic-chen
Thanks for point out, so should I fix the E2E test error or waiting for @nic-chen to solve it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #1580: fix: fix the upstream timeout unit
Posted by GitBox <gi...@apache.org>.
nic-chen commented on pull request #1580:
URL: https://github.com/apache/apisix-dashboard/pull/1580#issuecomment-799336420
hi, please sync codes from branch master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #1580: fix: fix the upstream timeout unit
Posted by GitBox <gi...@apache.org>.
nic-chen commented on pull request #1580:
URL: https://github.com/apache/apisix-dashboard/pull/1580#issuecomment-799297401
wait for #1594
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1580: fix: fix the upstream timeout unit
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1580:
URL: https://github.com/apache/apisix-dashboard/pull/1580#issuecomment-797511954
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1580?src=pr&el=h1) Report
> Merging [#1580](https://codecov.io/gh/apache/apisix-dashboard/pull/1580?src=pr&el=desc) (bcc88cc) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/48e66cded1f4f7b67d37a9f1337fca492d6f44f5?el=desc) (48e66cd) will **decrease** coverage by `10.75%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1580?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1580 +/- ##
===========================================
- Coverage 71.50% 60.74% -10.76%
===========================================
Files 132 46 -86
Lines 5341 3019 -2322
Branches 584 0 -584
===========================================
- Hits 3819 1834 -1985
+ Misses 1277 873 -404
- Partials 245 312 +67
```
| Flag | Coverage Δ | |
|---|---|---|
| backend-e2e-test | `60.74% <ø> (ø)` | |
| backend-e2e-test-ginkgo | `46.27% <ø> (ø)` | |
| backend-unit-test | `?` | |
| frontend-e2e-test | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1580?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1580/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==) | `0.00% <0.00%> (-64.29%)` | :arrow_down: |
| [api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1580/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==) | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
| [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1580/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | `57.44% <0.00%> (-34.05%)` | :arrow_down: |
| [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1580/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | `47.22% <0.00%> (-30.56%)` | :arrow_down: |
| [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1580/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `58.43% <0.00%> (-29.52%)` | :arrow_down: |
| [api/internal/filter/ip\_filter.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1580/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9pcF9maWx0ZXIuZ28=) | `48.71% <0.00%> (-23.08%)` | :arrow_down: |
| [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1580/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | `64.51% <0.00%> (-19.36%)` | :arrow_down: |
| [...pi/internal/handler/plugin\_config/plugin\_config.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1580/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luX2NvbmZpZy9wbHVnaW5fY29uZmlnLmdv) | `59.57% <0.00%> (-18.09%)` | :arrow_down: |
| [api/internal/handler/route/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1580/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGUvcm91dGUuZ28=) | `63.59% <0.00%> (-14.65%)` | :arrow_down: |
| [api/internal/handler/upstream/upstream.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1580/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvdXBzdHJlYW0vdXBzdHJlYW0uZ28=) | `74.76% <0.00%> (-14.02%)` | :arrow_down: |
| ... and [97 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1580/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1580?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1580?src=pr&el=footer). Last update [48e66cd...bcc88cc](https://codecov.io/gh/apache/apisix-dashboard/pull/1580?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on pull request #1580: fix: fix the upstream timeout unit
Posted by GitBox <gi...@apache.org>.
liuxiran commented on pull request #1580:
URL: https://github.com/apache/apisix-dashboard/pull/1580#issuecomment-798594667
Hi @stu01509
For the error in `route/import_export_route.spec.js`, you would try to update these codes to `6`
* https://github.com/apache/apisix-dashboard/blob/9cb4b430e4337a9a1b6a4b3eea4763a76c2feeb7/web/cypress/fixtures/export-route-dataset.json#L43~L45
* https://github.com/apache/apisix-dashboard/blob/9cb4b430e4337a9a1b6a4b3eea4763a76c2feeb7/web/cypress/fixtures/export-route-dataset.json#L96~L98
* https://github.com/apache/apisix-dashboard/blob/9cb4b430e4337a9a1b6a4b3eea4763a76c2feeb7/web/cypress/fixtures/export-route-dataset.json#L148~L150
and for the error https://github.com/apache/apisix-dashboard/pull/1580/checks?check_run_id=2100719617, may need @nic-chen 's help, for this error also occued in https://github.com/apache/apisix-dashboard/pull/1576/checks?check_run_id=2101373014 thanks a lot.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #1580: fix: fix the upstream timeout unit
Posted by GitBox <gi...@apache.org>.
nic-chen commented on pull request #1580:
URL: https://github.com/apache/apisix-dashboard/pull/1580#issuecomment-799003391
thanks @liuxiran
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] stu01509 commented on pull request #1580: fix: fix the upstream timeout unit
Posted by GitBox <gi...@apache.org>.
stu01509 commented on pull request #1580:
URL: https://github.com/apache/apisix-dashboard/pull/1580#issuecomment-797865812
> LGTM, and would like to update those 3 fields' value to `6`? for they are in seconds 🤔
>
> https://github.com/stu01509/apisix-dashboard/blob/fix-%231565-use-seconds/web/src/components/Upstream/constant.ts#L22-L24
Agree, So I update the commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1580: fix: fix the upstream timeout unit
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1580:
URL: https://github.com/apache/apisix-dashboard/pull/1580#issuecomment-797511954
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1580?src=pr&el=h1) Report
> Merging [#1580](https://codecov.io/gh/apache/apisix-dashboard/pull/1580?src=pr&el=desc) (11dcccc) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/e22de2966fe322ee26b8023e9a5e493cfa643535?el=desc) (e22de29) will **increase** coverage by `3.42%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1580?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1580 +/- ##
==========================================
+ Coverage 69.01% 72.44% +3.42%
==========================================
Files 132 86 -46
Lines 5374 2355 -3019
Branches 592 592
==========================================
- Hits 3709 1706 -2003
+ Misses 1417 649 -768
+ Partials 248 0 -248
```
| Flag | Coverage Δ | |
|---|---|---|
| backend-e2e-test-ginkgo | `?` | |
| backend-unit-test | `?` | |
| frontend-e2e-test | `72.44% <100.00%> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1580?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [web/src/components/Upstream/constant.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1580/diff?src=pr&el=tree#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbnN0YW50LnRz) | `100.00% <ø> (ø)` | |
| [web/src/components/Upstream/UpstreamForm.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1580/diff?src=pr&el=tree#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL1Vwc3RyZWFtRm9ybS50c3g=) | `62.01% <100.00%> (ø)` | |
| [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1580/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | | |
| [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1580/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | | |
| [api/internal/utils/utils.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1580/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3V0aWxzLmdv) | | |
| [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1580/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | | |
| [api/internal/handler/label/label.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1580/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbGFiZWwvbGFiZWwuZ28=) | | |
| [api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1580/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=) | | |
| [api/internal/utils/pid.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1580/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3BpZC5nbw==) | | |
| [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1580/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | | |
| ... and [38 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1580/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1580?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1580?src=pr&el=footer). Last update [e22de29...11dcccc](https://codecov.io/gh/apache/apisix-dashboard/pull/1580?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #1580: fix: fix the upstream timeout unit
Posted by GitBox <gi...@apache.org>.
nic-chen commented on pull request #1580:
URL: https://github.com/apache/apisix-dashboard/pull/1580#issuecomment-798843102
> Hi @stu01509
>
> For the error in `route/import_export_route.spec.js`, you would try to update these codes to `6`
>
> * https://github.com/apache/apisix-dashboard/blob/9cb4b430e4337a9a1b6a4b3eea4763a76c2feeb7/web/cypress/fixtures/export-route-dataset.json#L43~L45
>
> * https://github.com/apache/apisix-dashboard/blob/9cb4b430e4337a9a1b6a4b3eea4763a76c2feeb7/web/cypress/fixtures/export-route-dataset.json#L96~L98
>
> * https://github.com/apache/apisix-dashboard/blob/9cb4b430e4337a9a1b6a4b3eea4763a76c2feeb7/web/cypress/fixtures/export-route-dataset.json#L148~L150
>
>
>
> and for the error https://github.com/apache/apisix-dashboard/pull/1580/checks?check_run_id=2100719617, may need @nic-chen 's help, for this error also occued in https://github.com/apache/apisix-dashboard/pull/1576/checks?check_run_id=2101373014 thanks a lot.
>
>
I found the reason, will fix it soon
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io commented on pull request #1580: fix: fix the upstream timeout unit
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1580:
URL: https://github.com/apache/apisix-dashboard/pull/1580#issuecomment-797511954
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1580?src=pr&el=h1) Report
> Merging [#1580](https://codecov.io/gh/apache/apisix-dashboard/pull/1580?src=pr&el=desc) (bcc88cc) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/48e66cded1f4f7b67d37a9f1337fca492d6f44f5?el=desc) (48e66cd) will **decrease** coverage by `25.22%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1580?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1580 +/- ##
===========================================
- Coverage 71.50% 46.27% -25.23%
===========================================
Files 132 46 -86
Lines 5341 3019 -2322
Branches 584 0 -584
===========================================
- Hits 3819 1397 -2422
- Misses 1277 1337 +60
- Partials 245 285 +40
```
| Flag | Coverage Δ | |
|---|---|---|
| backend-e2e-test | `?` | |
| backend-e2e-test-ginkgo | `46.27% <ø> (ø)` | |
| backend-unit-test | `?` | |
| frontend-e2e-test | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1580?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/handler/label/label.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1580/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbGFiZWwvbGFiZWwuZ28=) | `9.43% <0.00%> (-72.65%)` | :arrow_down: |
| [api/internal/handler/data\_loader/route\_export.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1580/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfZXhwb3J0Lmdv) | `3.38% <0.00%> (-65.79%)` | :arrow_down: |
| [api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1580/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==) | `0.00% <0.00%> (-64.29%)` | :arrow_down: |
| [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1580/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | `27.41% <0.00%> (-56.46%)` | :arrow_down: |
| [api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1580/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==) | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
| [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1580/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | `36.11% <0.00%> (-41.67%)` | :arrow_down: |
| [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1580/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | `52.12% <0.00%> (-39.37%)` | :arrow_down: |
| [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1580/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `27.41% <0.00%> (-37.50%)` | :arrow_down: |
| [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1580/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `57.22% <0.00%> (-30.73%)` | :arrow_down: |
| [api/internal/handler/route/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1580/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGUvcm91dGUuZ28=) | `48.95% <0.00%> (-29.29%)` | :arrow_down: |
| ... and [102 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1580/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1580?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1580?src=pr&el=footer). Last update [48e66cd...bcc88cc](https://codecov.io/gh/apache/apisix-dashboard/pull/1580?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1580: fix: fix the upstream timeout unit
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1580:
URL: https://github.com/apache/apisix-dashboard/pull/1580#issuecomment-797511954
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1580?src=pr&el=h1) Report
> Merging [#1580](https://codecov.io/gh/apache/apisix-dashboard/pull/1580?src=pr&el=desc) (4a50bfd) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/e22de2966fe322ee26b8023e9a5e493cfa643535?el=desc) (e22de29) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1580?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1580 +/- ##
=======================================
Coverage 66.34% 66.34%
=======================================
Files 46 46
Lines 3019 3019
=======================================
Hits 2003 2003
- Misses 768 770 +2
+ Partials 248 246 -2
```
| Flag | Coverage Δ | |
|---|---|---|
| backend-e2e-test-ginkgo | `46.27% <ø> (ø)` | |
| backend-unit-test | `51.54% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1580?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1580/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `86.74% <0.00%> (-1.21%)` | :arrow_down: |
| [api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1580/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==) | `33.33% <0.00%> (ø)` | |
| [api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1580/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv) | `45.45% <0.00%> (+1.81%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1580?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1580?src=pr&el=footer). Last update [e22de29...4a50bfd](https://codecov.io/gh/apache/apisix-dashboard/pull/1580?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on pull request #1580: fix: fix the upstream timeout unit
Posted by GitBox <gi...@apache.org>.
liuxiran commented on pull request #1580:
URL: https://github.com/apache/apisix-dashboard/pull/1580#issuecomment-798992193
> Hi @liuxiran and @nic-chen
>
> Thanks for point out, so should I fix the E2E test error or waiting for @nic-chen to solve it?
you can try to fix the e2e error in `route/import_export_route.spec.js` first😊 @stu01509
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org