You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "alexeyinkin (via GitHub)" <gi...@apache.org> on 2023/04/12 14:23:12 UTC

[GitHub] [beam] alexeyinkin commented on a diff in pull request #26235: [Playground] Make fields categories and context_line optional in examples tag

alexeyinkin commented on code in PR #26235:
URL: https://github.com/apache/beam/pull/26235#discussion_r1164204092


##########
playground/backend/internal/db/mapper/precompiled_object_mapper_test.go:
##########
@@ -40,7 +40,7 @@ func TestPrecompiledObjectMapper_ToObjectInfo(t *testing.T) {
 		Categories:      []string{"MOCK_CAT_1", "MOCK_CAT_2", "MOCK_CAT_3"},
 		PipelineOptions: "MOCK_OPTIONS",

Review Comment:
   This will also help because the current value fails to be parsed and so the example is not runnable.
   ```suggestion
   		PipelineOptions: "--name1 value1 --name2 value2",
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org