[GitHub] [lucene-solr] MarcusSorealheis opened a new pull request #805: SOLR-13649 change the default behavior of the basic authentication plugin.

[GitBox <gi...@apache.org>]

MarcusSorealheis opened a new pull request #805: SOLR-13649 change the default behavior of the basic authentication plugin.
URL: https://github.com/apache/lucene-solr/pull/805
 
 
   <!--
   Before creating a pull request, please file an issue in the ASF Jira system for Lucene or Solr:
   
   * https://issues.apache.org/jira/projects/LUCENE
   * https://issues.apache.org/jira/projects/SOLR
   
   You will need to create an account in Jira in order to create an issue.
   
   The title of the PR should reference the Jira issue number in the form:
   
   * LUCENE-####: <short description of problem or changes>
   * SOLR-####: <short description of problem or changes>
   
   LUCENE and SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
   
   Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
   
   
   # Description
   
   The default value for `blockUnknown` is `false`. That default behavior is a bit counterintuitive because if someone wishes to enable basic authentication, you would expect that they would want all unknown users to need to authenticate by default. I can imagine cases where you would not, but those cases would be less frequent.
   
   
   # Solution
   
   set `blockUnknown` to `true`
   
   # Tests
   
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [ ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
   - [ ] I have created a Jira issue and added the issue ID to my pull request title.
   - [ ] I am authorized to contribute this code to the ASF and have removed any code I do not have a license to distribute.
   - [ ] I have developed this patch against the `master` branch.
   - [ ] I have run `ant precommit` and the appropriate test suite.
   - [ ] I have added tests for my changes.
   - [ ] I have added documentation for the Ref Guide (for Solr changes only).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org