You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Michael Han (JIRA)" <ji...@apache.org> on 2017/04/27 21:22:04 UTC
[jira] [Resolved] (ZOOKEEPER-2316) comment does not match code
logic
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Han resolved ZOOKEEPER-2316.
------------------------------------
Resolution: Fixed
Fix Version/s: (was: 3.5.1)
3.5.4
3.6.0
Issue resolved by pull request 223
[https://github.com/apache/zookeeper/pull/223]
> comment does not match code logic
> ---------------------------------
>
> Key: ZOOKEEPER-2316
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2316
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.5.1
> Reporter: sunhaitao
> Priority: Trivial
> Fix For: 3.6.0, 3.5.4
>
>
> when i read the code below, the comment is put in an incorrect,place.
> " // in order to be committed, a proposal must be accepted by a quorum "
> should be place on top of :
> if (!p.hasAllQuorums()) {
> return false;
> }
> ---------------------------------------------------------------------------------------
> 3.5.1 Leader code
> // getting a quorum from all necessary configurations
> if (!p.hasAllQuorums()) {
> return false;
> }
>
> // commit proposals in order
> if (zxid != lastCommitted+1) {
> LOG.warn("Commiting zxid 0x" + Long.toHexString(zxid)
> + " from " + followerAddr + " not first!");
> LOG.warn("First is "
> + (lastCommitted+1));
> }
>
> // in order to be committed, a proposal must be accepted by a quorum
>
> outstandingProposals.remove(zxid);
>
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)