You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "sunank200 (via GitHub)" <gi...@apache.org> on 2025/02/10 20:18:02 UTC
[PR] Add missing migration for renaming execution_date to logical_date to log table [airflow]
sunank200 opened a new pull request, #46634:
URL: https://github.com/apache/airflow/pull/46634
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
The PR [#43902](https://github.com/apache/airflow/pull/43902) renames the `execution_date` column to `logical_date` in the log table as well, apart from the dag run table. But this PR missed the migration file for log table changes.
This PR adds a migration file to update the log table by renaming the `execution_date` column to `logical_date`. The column remains nullable.
Changes:
dag_run table:
Renamed execution_date column to logical_date
Updated unique constraint from dag_run_dag_id_execution_date_key to dag_run_dag_id_logical_date_key
log table:
Renamed execution_date column to logical_date
Ensured logical_date remains nullable
Updated migration script to reflect these changes while maintaining compatibility with existing data.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add missing migration for renaming execution_date to logical_date to log table [airflow]
Posted by "ashb (via GitHub)" <gi...@apache.org>.
ashb commented on PR #46634:
URL: https://github.com/apache/airflow/pull/46634#issuecomment-2649171371
 I think GitHub is having a moment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add missing migration for renaming execution_date to logical_date to log table [airflow]
Posted by "dstandish (via GitHub)" <gi...@apache.org>.
dstandish commented on code in PR #46634:
URL: https://github.com/apache/airflow/pull/46634#discussion_r1949879795
##########
airflow/migrations/versions/0032_3_0_0_rename_execution_date_to_logical_date_and_nullable.py:
##########
@@ -17,7 +17,7 @@
# under the License.
"""
-Make logical_date nullable.
+Renamed column execution_date to logical_date in both dag_run and log tables. Make logical_date nullable.
Review Comment:
```suggestion
Rename execution_date to logical_date
Rename column execution_date to logical_date in both dag_run and log tables. Make logical_date nullable.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add missing migration for renaming execution_date to logical_date to log table [airflow]
Posted by "sunank200 (via GitHub)" <gi...@apache.org>.
sunank200 commented on code in PR #46634:
URL: https://github.com/apache/airflow/pull/46634#discussion_r1950244146
##########
airflow/migrations/versions/0032_3_0_0_rename_execution_date_to_logical_date_and_nullable.py:
##########
@@ -17,7 +17,7 @@
# under the License.
"""
-Make logical_date nullable.
+Renamed column execution_date to logical_date in both dag_run and log tables. Make logical_date nullable.
Review Comment:
Changed it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add missing migration for renaming execution_date to logical_date to log table [airflow]
Posted by "dstandish (via GitHub)" <gi...@apache.org>.
dstandish commented on code in PR #46634:
URL: https://github.com/apache/airflow/pull/46634#discussion_r1949870898
##########
airflow/migrations/versions/0032_3_0_0_rename_execution_date_to_logical_date_and_nullable.py:
##########
@@ -17,7 +17,7 @@
# under the License.
"""
-Make logical_date nullable.
+Renamed column execution_date to logical_date in both dag_run and log tables. Make logical_date nullable.
Review Comment:
It makes sense to keep the first line simple, short, one line, one sentence. Can move any other necessary details below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add missing migration for renaming execution_date to logical_date to log table [airflow]
Posted by "Lee-W (via GitHub)" <gi...@apache.org>.
Lee-W merged PR #46634:
URL: https://github.com/apache/airflow/pull/46634
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org