You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "MaxGekk (via GitHub)" <gi...@apache.org> on 2023/04/27 19:22:41 UTC

[GitHub] [spark] MaxGekk commented on a diff in pull request #40955: [SPARK-42843][SQL] Update the error class _LEGACY_ERROR_TEMP_2007 to REGEX_GROUP_INDEX_EXCEED_REGEX_GROUP_COUNT

MaxGekk commented on code in PR #40955:
URL: https://github.com/apache/spark/pull/40955#discussion_r1179591025


##########
core/src/main/resources/error/error-classes.json:
##########
@@ -1373,6 +1373,11 @@
       "Found recursive reference in Protobuf schema, which can not be processed by Spark by default: <fieldDescriptor>. try setting the option `recursive.fields.max.depth` 0 to 10. Going beyond 10 levels of recursion is not allowed."
     ]
   },
+  "REGEX_GROUP_INDEX_EXCEED_REGEX_GROUP_COUNT" : {

Review Comment:
   Could you consider adding a sub-class to `INVALID_PARAMETER_VALUE`, please.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org