[GitHub] agrawaldevesh edited a comment on issue #6719: Adding support for Pinot

[GitBox <gi...@apache.org>]

agrawaldevesh edited a comment on issue #6719: Adding support for Pinot
URL: https://github.com/apache/incubator-superset/pull/6719#issuecomment-457880746
 
 
   @villebro, I was able to confirm the issue with the OSS docker pinot. The issue was a bug in my pinotdb-dbapi code and I have updated that PR. 
   
   Pinot does not really have the notion of schema. Usually the tableName is kept same as the schemaName but that's not the case in the provided test table baseballStats. 
   
   Anyway, changing the sql editor query to read "select * from baseballStats" (instead of "select * from baseball.baseballStats") did the trick (after the pinotdb-dbapi fix). 
   
   Thanks for your testing and helping me fix this !.
   
   Otherwise, I have incorporated the changes you requested and so I think this PR is safe to merge in.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org