deprecated, source resolver, test case mess

[Geoff Howard <co...@leverageweb.com>]

As many people know, excluding the deprecated classes from the build 
causes the test case compilation to fail which then kills the build.

I started looking into why the test cases depend on the deprecated 
classes and have so far only been able to determine that it is a big 
hairy mess.  I think Cocoon needs to rid itself of this issue before the 
  beta release if at all possible.

It appears that these test cases did not get updated when Source and 
friends moved to excalibur.  (though it may be that they are designed to 
test even deprecated components which would be another discussion).

So, it seems to me that the options are:
- fix the problem in the test cases (if I knew how it would be done by now)
- remove the tests that don't compile without deprecated
- un-deprecate whatever is necessary to hide the problem
- leave things as is and warn users that it is impossible to exclude the 
deprecated classes (and perhaps remove the config option)

What do you think?

Geoff Howard

Re: deprecated, source resolver, test case mess

[Ugo Cei <u....@cbim.it>]

Geoff Howard wrote:
> - remove the tests that don't compile without deprecated
+1


-- 
Ugo Cei - Consorzio di Bioingegneria e Informatica Medica
P.le Volontari del Sangue, 2 - 27100 Pavia - Italy
Phone: +39.0382.525100 - E-mail: u.cei@cbim.it

Re: deprecated, source resolver, test case mess

[Stephan Michels <st...@apache.org>]

On 24 Jul 2003, David Crossley wrote:

> Stephan Michels wrote:
>
> > The only testcase, which depends on the deprecated package is the
> > ResolverImplTestCase, I think. I don't know the status of the
> > Resolver, but I see that parts of it went into the xmlutil package of
> > Excalibur.
> >
> > So, perhaps someone can throw light on?!
>
> The entity-resolver testcases were some of the earliest testcases for
> Cocoon. They helped a lot (and still do help) to test cross-platform
> issues. Many thanks to Berni Huber for them. He did warn us at the time
> that they would be hard to maintain.
>
> Now the entity resolver components have moved to Avalon. Cocoon makes
> direct use of it via Excalibur. The testcases still use the old classes,
> merely because they have not been updated following the move.
>
> I think that it would be good to re-implement those testcases over at
> Avalon beside their code. However, i do not have time for that at the
> moment. We can hopefully get them from the Cocoon CVS Attic when needed.
>
> Do we still need the entity-resolver testcases in Cocoon? I think that
> things are stable now in the 2.1 ... can you use the Catalog Entity
> Resolver sample (if the first sample renders a page then okay)
> and see the test document from the page at:
> http://localhost:8888/docs/installing/tests.html
> and run 'build test' okay?
>
> I can on Linux, so i am +0.9 for the removal of the testcases.
> (The fractional bid is only because i cannot help.)
>
> There are other filesystem testcases which would be good to keep.

Okay, thank you for the explaination. So, then we should move the
testcase to the repository of Excalibur.

Stephan.

Re: deprecated, source resolver, test case mess

[David Crossley <cr...@indexgeo.com.au>]

Stephan Michels wrote:
> Geoff Howard wrote:
> 
> > As many people know, excluding the deprecated classes from the build
> > causes the test case compilation to fail which then kills the build.
> >
> > I started looking into why the test cases depend on the deprecated
> > classes and have so far only been able to determine that it is a big
> > hairy mess.  I think Cocoon needs to rid itself of this issue before the
> >   beta release if at all possible.
> >
> > It appears that these test cases did not get updated when Source and
> > friends moved to excalibur.  (though it may be that they are designed to
> > test even deprecated components which would be another discussion).
> >
> > So, it seems to me that the options are:
> > - fix the problem in the test cases (if I knew how it would be done by now)
> > - remove the tests that don't compile without deprecated
> > - un-deprecate whatever is necessary to hide the problem
> > - leave things as is and warn users that it is impossible to exclude the
> > deprecated classes (and perhaps remove the config option)
> >
> > What do you think?
> 
> The only testcase, which depends on the deprecated package is the
> ResolverImplTestCase, I think. I don't know the status of the
> Resolver, but I see that parts of it went into the xmlutil package of
> Excalibur.
> 
> So, perhaps someone can throw light on?!

The entity-resolver testcases were some of the earliest testcases for
Cocoon. They helped a lot (and still do help) to test cross-platform
issues. Many thanks to Berni Huber for them. He did warn us at the time
that they would be hard to maintain.

Now the entity resolver components have moved to Avalon. Cocoon makes
direct use of it via Excalibur. The testcases still use the old classes,
merely because they have not been updated following the move.

I think that it would be good to re-implement those testcases over at
Avalon beside their code. However, i do not have time for that at the
moment. We can hopefully get them from the Cocoon CVS Attic when needed.

Do we still need the entity-resolver testcases in Cocoon? I think that
things are stable now in the 2.1 ... can you use the Catalog Entity
Resolver sample (if the first sample renders a page then okay)
and see the test document from the page at:
http://localhost:8888/docs/installing/tests.html
and run 'build test' okay?

I can on Linux, so i am +0.9 for the removal of the testcases.
(The fractional bid is only because i cannot help.)

There are other filesystem testcases which would be good to keep.

--David

Re: deprecated, source resolver, test case mess

[Geoff Howard <co...@leverageweb.com>]

Stephan Michels wrote:
> On Wed, 23 Jul 2003, Geoff Howard wrote:

...

> 
> The only testcase, which depends on the deprecated package is the
> ResolverImplTestCase, I think. I don't know the status of the
> Resolver, but I see that parts of it went into the xmlutil package of
> Excalibur.

Well, I tried that but found that SourceResolverAdaptor also depended on 
deprecated, but I see you fixed it while I slept.  Ok, so that and 
deleting/moving ResolverImplTestCase may be all it takes?  I can't work 
on this for the next 9 or so hours but if no one's done anything by 
then, I'll get to it.

Geoff

Re: deprecated, source resolver, test case mess

[Stephan Michels <st...@apache.org>]

On Wed, 23 Jul 2003, Geoff Howard wrote:

> As many people know, excluding the deprecated classes from the build
> causes the test case compilation to fail which then kills the build.
>
> I started looking into why the test cases depend on the deprecated
> classes and have so far only been able to determine that it is a big
> hairy mess.  I think Cocoon needs to rid itself of this issue before the
>   beta release if at all possible.
>
> It appears that these test cases did not get updated when Source and
> friends moved to excalibur.  (though it may be that they are designed to
> test even deprecated components which would be another discussion).
>
> So, it seems to me that the options are:
> - fix the problem in the test cases (if I knew how it would be done by now)
> - remove the tests that don't compile without deprecated
> - un-deprecate whatever is necessary to hide the problem
> - leave things as is and warn users that it is impossible to exclude the
> deprecated classes (and perhaps remove the config option)
>
> What do you think?

The only testcase, which depends on the deprecated package is the
ResolverImplTestCase, I think. I don't know the status of the
Resolver, but I see that parts of it went into the xmlutil package of
Excalibur.

So, perhaps someone can throw light on?!

Stephan.