[GitHub] [pinot] gortiz commented on a diff in pull request #10759: bug fix: add @JsonProperty for variable _assignmentStrategy in SegmentAssignmentConfig

["gortiz (via GitHub)" <gi...@apache.org>]

gortiz commented on code in PR #10759:
URL: https://github.com/apache/pinot/pull/10759#discussion_r1196145111


##########
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/assignment/SegmentAssignmentConfig.java:
##########
@@ -34,6 +34,7 @@ public SegmentAssignmentConfig(@JsonProperty(value = "segmentAssignmentStrategy"
     _assignmentStrategy = assignmentStrategy;
   }
 
+  @JsonProperty("segmentAssignmentStrategy")

Review Comment:
   I would place the annotation in the attribute, given that there is already a json annotation there



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org