You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2019/03/20 09:56:51 UTC
Review Request 70250: Made hashmap::containsValue consistent with
stout naming convention.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70250/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Benno Evers.
Repository: mesos
Description
-------
In stout we use snake case, not camel case.
This patch contains fixes to users in Mesos.
Diffs
-----
src/master/master.cpp dc68fc324de7242737123015fbac19a2129778ce
src/slave/containerizer/docker.cpp fc29e20bedd37f77b9be49cedbb1012473abdfee
src/slave/containerizer/mesos/launcher.cpp b38f88db4d120eb27ad56bdb7639cb80c76063d3
Diff: https://reviews.apache.org/r/70250/diff/1/
Testing
-------
`make check`, not a functional change
Thanks,
Benjamin Bannier
Re: Review Request 70250: Made hashmap::containsValue consistent with
stout naming convention.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70250/#review213833
-----------------------------------------------------------
PASS: Mesos patch 70250 was successfully built and tested.
Reviews applied: `['70249', '70250']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2985/mesos-review-70250
- Mesos Reviewbot Windows
On March 20, 2019, 2:56 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70250/
> -----------------------------------------------------------
>
> (Updated March 20, 2019, 2:56 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Benno Evers.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In stout we use snake case, not camel case.
>
> This patch contains fixes to users in Mesos.
>
>
> Diffs
> -----
>
> src/master/master.cpp dc68fc324de7242737123015fbac19a2129778ce
> src/slave/containerizer/docker.cpp fc29e20bedd37f77b9be49cedbb1012473abdfee
> src/slave/containerizer/mesos/launcher.cpp b38f88db4d120eb27ad56bdb7639cb80c76063d3
>
>
> Diff: https://reviews.apache.org/r/70250/diff/1/
>
>
> Testing
> -------
>
> `make check`, not a functional change
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 70250: Made hashmap::containsValue consistent with
stout naming convention.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70250/#review213827
-----------------------------------------------------------
Ship it!
- Benno Evers
On March 20, 2019, 9:56 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70250/
> -----------------------------------------------------------
>
> (Updated March 20, 2019, 9:56 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Benno Evers.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In stout we use snake case, not camel case.
>
> This patch contains fixes to users in Mesos.
>
>
> Diffs
> -----
>
> src/master/master.cpp dc68fc324de7242737123015fbac19a2129778ce
> src/slave/containerizer/docker.cpp fc29e20bedd37f77b9be49cedbb1012473abdfee
> src/slave/containerizer/mesos/launcher.cpp b38f88db4d120eb27ad56bdb7639cb80c76063d3
>
>
> Diff: https://reviews.apache.org/r/70250/diff/1/
>
>
> Testing
> -------
>
> `make check`, not a functional change
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 70250: Made hashmap::containsValue consistent with
stout naming convention.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70250/#review213832
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70249, 70250]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 20, 2019, 2:56 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70250/
> -----------------------------------------------------------
>
> (Updated March 20, 2019, 2:56 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Benno Evers.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In stout we use snake case, not camel case.
>
> This patch contains fixes to users in Mesos.
>
>
> Diffs
> -----
>
> src/master/master.cpp dc68fc324de7242737123015fbac19a2129778ce
> src/slave/containerizer/docker.cpp fc29e20bedd37f77b9be49cedbb1012473abdfee
> src/slave/containerizer/mesos/launcher.cpp b38f88db4d120eb27ad56bdb7639cb80c76063d3
>
>
> Diff: https://reviews.apache.org/r/70250/diff/1/
>
>
> Testing
> -------
>
> `make check`, not a functional change
>
>
> Thanks,
>
> Benjamin Bannier
>
>