[GitHub] [hbase] Apache9 commented on a diff in pull request #4337: HBASE-25058 Export necessary modules when running under JDK11

[GitBox <gi...@apache.org>]

Apache9 commented on code in PR #4337:
URL: https://github.com/apache/hbase/pull/4337#discussion_r855243274


##########
pom.xml:
##########
@@ -3036,7 +3036,16 @@
       <properties>
         <maven.compiler.release>${releaseTarget}</maven.compiler.release>
         <!-- TODO: replicate logic for windows support -->
-        <argLine>--add-opens=java.base/jdk.internal.ref=ALL-UNNAMED ${hbase-surefire.argLine}</argLine>
+        <argLine>-Dio.netty.tryReflectionSetAccessible=true
+          --illegal-access=permit
+          --add-modules jdk.unsupported
+          --add-opens java.base/java.nio=ALL-UNNAMED
+          --add-opens java.base/sun.nio.ch=ALL-UNNAMED
+          --add-opens java.base/java.lang=ALL-UNNAMED
+          --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED

Review Comment:
   Ah, copy-paste error. Thanks for pointing this out.
   
   Let me change it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org