You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by "TuroczyX (via GitHub)" <gi...@apache.org> on 2023/04/03 14:00:37 UTC

[GitHub] [hive] TuroczyX commented on pull request #4160: remove toLowerCases

TuroczyX commented on PR #4160:
URL: https://github.com/apache/hive/pull/4160#issuecomment-1494375699

   I do not have historical knowledge about it, but this change seems pretty risky. I guess there are several other components that are rely on these names. Also in some environment we would like to reduce the possibility to not play with CamelCases. I guess there are a lot of tests and other components are rely on these names in lower case. Also these are mainly for comparison as I see.
   
   @ayushtkn @deniskuzZ do you know the history of the toLowerCase()?
   
   @RobbertDM Why this is an issue for you? Is it blocking some development? Or just bothering your eyes? :) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org