[GitHub] [pulsar] BewareMyPower commented on pull request #15220: [Branch-2.9][test] Fix AdminTest#test500Error.

[GitBox <gi...@apache.org>]

BewareMyPower commented on PR #15220:
URL: https://github.com/apache/pulsar/pull/15220#issuecomment-1103437780

   Currently we can apply the following patch as a workaround for failed cpp-tests.
   
   ```diff
   diff --git a/pulsar-client-cpp/tests/ProducerTest.cc b/pulsar-client-cpp/tests/ProducerTest.cc
   index 14461429da3..258811fcdaf 100644
   --- a/pulsar-client-cpp/tests/ProducerTest.cc
   +++ b/pulsar-client-cpp/tests/ProducerTest.cc
   @@ -269,6 +269,7 @@ TEST(ProducerTest, testBacklogQuotasExceeded) {
        ASSERT_EQ(ResultOk, client.createProducer(partition, producer));
        ASSERT_EQ(ResultOk, producer.send(MessageBuilder().setContent(std::string(1024L, 'a')).build()));
        ASSERT_EQ(ResultOk, producer.close());
   +    ASSERT_EQ(ResultOk, consumer.close());
    
        setBacklogPolicy("producer_request_hold", 1024);
        ASSERT_EQ(ResultProducerBlockedQuotaExceededError, client.createProducer(topic, producer));
   @@ -283,4 +284,4 @@ TEST(ProducerTest, testBacklogQuotasExceeded) {
        ASSERT_EQ(ResultOk, client.createProducer(partition, producer));
    
        client.close();
   -}
   \ No newline at end of file
   +}
   ```
   
   But I think it's a bug introduced in branch-2.9. The master branch doesn't need to close the consumer.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org