You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/03/16 13:23:01 UTC
[GitHub] [flink] zentol opened a new pull request #19116: [FLINK-26616][tests] Remove deadlines from CommonTestUtils
zentol opened a new pull request #19116:
URL: https://github.com/apache/flink/pull/19116
Since we concluded to not use timeouts in tests we should remove them from test utils. That way we don't do the removal again and again for individual test cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #19116: [FLINK-26616][tests] Remove deadlines from CommonTestUtils
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #19116:
URL: https://github.com/apache/flink/pull/19116#discussion_r832427075
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/leaderelection/TestingLeaderBase.java
##########
@@ -44,44 +42,35 @@
public void waitForLeader(long timeout) throws Exception {
throwExceptionIfNotNull();
- final String errorMsg = "Contender was not elected as the leader within " + timeout + "ms";
CommonTestUtils.waitUntilCondition(
() -> {
final LeaderInformation leader =
leaderEventQueue.poll(timeout, TimeUnit.MILLISECONDS);
return leader != null && !leader.isEmpty();
- },
- Deadline.fromNow(Duration.ofMillis(timeout)),
- errorMsg);
+ });
isLeader = true;
}
public void waitForRevokeLeader(long timeout) throws Exception {
throwExceptionIfNotNull();
- final String errorMsg = "Contender was not revoked within " + timeout + "ms";
CommonTestUtils.waitUntilCondition(
() -> {
final LeaderInformation leader =
leaderEventQueue.poll(timeout, TimeUnit.MILLISECONDS);
return leader != null && leader.isEmpty();
- },
- Deadline.fromNow(Duration.ofMillis(timeout)),
- errorMsg);
+ });
isLeader = false;
}
public void waitForError(long timeout) throws Exception {
- final String errorMsg = "Contender did not see an exception with " + timeout + "ms";
CommonTestUtils.waitUntilCondition(
() -> {
error = errorQueue.poll(timeout, TimeUnit.MILLISECONDS);
return error != null;
- },
- Deadline.fromNow(Duration.ofMillis(timeout)),
- errorMsg);
+ });
Review comment:
errorQueue.take() would be equivalent to the current code. Even if it returns the error getError is not obsolete, as it allows you to test for the absence of an error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19116: [FLINK-26616][tests] Remove deadlines from CommonTestUtils
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19116:
URL: https://github.com/apache/flink/pull/19116#issuecomment-1069128888
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ce239101f1da9f768fd1b0857392a57cc4aed72d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33182",
"triggerID" : "ce239101f1da9f768fd1b0857392a57cc4aed72d",
"triggerType" : "PUSH"
}, {
"hash" : "60ae673acad69c86c771dd1c0fd772772f38cfa8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33190",
"triggerID" : "60ae673acad69c86c771dd1c0fd772772f38cfa8",
"triggerType" : "PUSH"
}, {
"hash" : "d013f8148fa4925a984a62267d91fd6b33f13eeb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33195",
"triggerID" : "d013f8148fa4925a984a62267d91fd6b33f13eeb",
"triggerType" : "PUSH"
}, {
"hash" : "2956f30f6d565e77b74a9964a49c00d005aca5c7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33196",
"triggerID" : "2956f30f6d565e77b74a9964a49c00d005aca5c7",
"triggerType" : "PUSH"
}, {
"hash" : "72c13df14fc83f64b67e20ecae82c25dbf49e6b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33236",
"triggerID" : "72c13df14fc83f64b67e20ecae82c25dbf49e6b7",
"triggerType" : "PUSH"
}, {
"hash" : "1e5e3cab5533bf80cf20e980debe66719a960741",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33360",
"triggerID" : "1e5e3cab5533bf80cf20e980debe66719a960741",
"triggerType" : "PUSH"
}, {
"hash" : "5bbab8b28bbe2e63c46e26e609d08c48ab580364",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33490",
"triggerID" : "5bbab8b28bbe2e63c46e26e609d08c48ab580364",
"triggerType" : "PUSH"
}, {
"hash" : "8b28c8df7c96a3bab4cdfc30ff45d4912ce048b1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33615",
"triggerID" : "8b28c8df7c96a3bab4cdfc30ff45d4912ce048b1",
"triggerType" : "PUSH"
}, {
"hash" : "82bf6b61e372f2cd1f8eef0429f4d134df1e257e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33616",
"triggerID" : "82bf6b61e372f2cd1f8eef0429f4d134df1e257e",
"triggerType" : "PUSH"
}, {
"hash" : "82bf6b61e372f2cd1f8eef0429f4d134df1e257e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33616",
"triggerID" : "1076106270",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 82bf6b61e372f2cd1f8eef0429f4d134df1e257e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33616)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #19116: [FLINK-26616][tests] Remove deadlines from CommonTestUtils
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #19116:
URL: https://github.com/apache/flink/pull/19116#issuecomment-1069128888
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ce239101f1da9f768fd1b0857392a57cc4aed72d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ce239101f1da9f768fd1b0857392a57cc4aed72d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ce239101f1da9f768fd1b0857392a57cc4aed72d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19116: [FLINK-26616][tests] Remove deadlines from CommonTestUtils
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19116:
URL: https://github.com/apache/flink/pull/19116#issuecomment-1069128888
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ce239101f1da9f768fd1b0857392a57cc4aed72d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33182",
"triggerID" : "ce239101f1da9f768fd1b0857392a57cc4aed72d",
"triggerType" : "PUSH"
}, {
"hash" : "60ae673acad69c86c771dd1c0fd772772f38cfa8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33190",
"triggerID" : "60ae673acad69c86c771dd1c0fd772772f38cfa8",
"triggerType" : "PUSH"
}, {
"hash" : "d013f8148fa4925a984a62267d91fd6b33f13eeb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33195",
"triggerID" : "d013f8148fa4925a984a62267d91fd6b33f13eeb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d013f8148fa4925a984a62267d91fd6b33f13eeb Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33195)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19116: [FLINK-26616][tests] Remove deadlines from CommonTestUtils
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19116:
URL: https://github.com/apache/flink/pull/19116#issuecomment-1069128888
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #19116: [FLINK-26616][tests] Remove deadlines from CommonTestUtils
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #19116:
URL: https://github.com/apache/flink/pull/19116#discussion_r832502392
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/testutils/CommonTestUtils.java
##########
@@ -131,40 +128,16 @@ public static void printLog4jDebugConfig(File file) throws IOException {
}
}
- public static void waitUntilCondition(
- SupplierWithException<Boolean, Exception> condition, Deadline timeout)
- throws Exception {
- waitUntilCondition(condition, timeout, RETRY_INTERVAL);
- }
-
- public static void waitUntilCondition(
- SupplierWithException<Boolean, Exception> condition,
- Deadline timeout,
- long retryIntervalMillis)
- throws Exception {
- waitUntilCondition(
- condition, timeout, retryIntervalMillis, "Condition was not met in given timeout.");
- }
-
- public static void waitUntilCondition(
- SupplierWithException<Boolean, Exception> condition, Deadline timeout, String errorMsg)
+ public static void waitUntilCondition(SupplierWithException<Boolean, Exception> condition)
Review comment:
That's gonna be annoying because the classes have the same name, so you may end up with fully-qualified imports within and current users of the runtime CommonTestUtils.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] XComp commented on a change in pull request #19116: [FLINK-26616][tests] Remove deadlines from CommonTestUtils
Posted by GitBox <gi...@apache.org>.
XComp commented on a change in pull request #19116:
URL: https://github.com/apache/flink/pull/19116#discussion_r837141717
##########
File path: flink-kubernetes/src/test/java/org/apache/flink/kubernetes/kubeclient/resources/TestingLeaderCallbackHandler.java
##########
@@ -63,38 +59,23 @@ public boolean hasLeadership() {
return isLeader;
}
- public static String waitUntilNewLeaderAppears(long timeout) throws Exception {
- final AtomicReference<String> leaderRef = new AtomicReference<>();
- CommonTestUtils.waitUntilCondition(
- () -> {
- final String lockIdentity = sharedQueue.poll(timeout, TimeUnit.MILLISECONDS);
- leaderRef.set(lockIdentity);
- return lockIdentity != null;
Review comment:
I was wondering whether we should add a null check in the constructor to comply to the previous implementation (ignoring `null` values). But `BlockingQueue`s don't accept `null` as values, anyway. The only benefit we gain from it is that we would fail earlier (in the constructor rather than the `offer` calls) if somebody "accidentally" used `null` as a `lockIdentity`. but that's probably off-topic to this change, anyway. So, I leave it up to you...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19116: [FLINK-26616][tests] Remove deadlines from CommonTestUtils
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19116:
URL: https://github.com/apache/flink/pull/19116#issuecomment-1069128888
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ce239101f1da9f768fd1b0857392a57cc4aed72d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33182",
"triggerID" : "ce239101f1da9f768fd1b0857392a57cc4aed72d",
"triggerType" : "PUSH"
}, {
"hash" : "60ae673acad69c86c771dd1c0fd772772f38cfa8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33190",
"triggerID" : "60ae673acad69c86c771dd1c0fd772772f38cfa8",
"triggerType" : "PUSH"
}, {
"hash" : "d013f8148fa4925a984a62267d91fd6b33f13eeb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33195",
"triggerID" : "d013f8148fa4925a984a62267d91fd6b33f13eeb",
"triggerType" : "PUSH"
}, {
"hash" : "2956f30f6d565e77b74a9964a49c00d005aca5c7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33196",
"triggerID" : "2956f30f6d565e77b74a9964a49c00d005aca5c7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d013f8148fa4925a984a62267d91fd6b33f13eeb Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33195)
* 2956f30f6d565e77b74a9964a49c00d005aca5c7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33196)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19116: [FLINK-26616][tests] Remove deadlines from CommonTestUtils
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19116:
URL: https://github.com/apache/flink/pull/19116#issuecomment-1069128888
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ce239101f1da9f768fd1b0857392a57cc4aed72d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33182",
"triggerID" : "ce239101f1da9f768fd1b0857392a57cc4aed72d",
"triggerType" : "PUSH"
}, {
"hash" : "60ae673acad69c86c771dd1c0fd772772f38cfa8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33190",
"triggerID" : "60ae673acad69c86c771dd1c0fd772772f38cfa8",
"triggerType" : "PUSH"
}, {
"hash" : "d013f8148fa4925a984a62267d91fd6b33f13eeb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33195",
"triggerID" : "d013f8148fa4925a984a62267d91fd6b33f13eeb",
"triggerType" : "PUSH"
}, {
"hash" : "2956f30f6d565e77b74a9964a49c00d005aca5c7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33196",
"triggerID" : "2956f30f6d565e77b74a9964a49c00d005aca5c7",
"triggerType" : "PUSH"
}, {
"hash" : "72c13df14fc83f64b67e20ecae82c25dbf49e6b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33236",
"triggerID" : "72c13df14fc83f64b67e20ecae82c25dbf49e6b7",
"triggerType" : "PUSH"
}, {
"hash" : "1e5e3cab5533bf80cf20e980debe66719a960741",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33360",
"triggerID" : "1e5e3cab5533bf80cf20e980debe66719a960741",
"triggerType" : "PUSH"
}, {
"hash" : "5bbab8b28bbe2e63c46e26e609d08c48ab580364",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33490",
"triggerID" : "5bbab8b28bbe2e63c46e26e609d08c48ab580364",
"triggerType" : "PUSH"
}, {
"hash" : "8b28c8df7c96a3bab4cdfc30ff45d4912ce048b1",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33615",
"triggerID" : "8b28c8df7c96a3bab4cdfc30ff45d4912ce048b1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5bbab8b28bbe2e63c46e26e609d08c48ab580364 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33490)
* 8b28c8df7c96a3bab4cdfc30ff45d4912ce048b1 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33615)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19116: [FLINK-26616][tests] Remove deadlines from CommonTestUtils
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19116:
URL: https://github.com/apache/flink/pull/19116#issuecomment-1069128888
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ce239101f1da9f768fd1b0857392a57cc4aed72d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33182",
"triggerID" : "ce239101f1da9f768fd1b0857392a57cc4aed72d",
"triggerType" : "PUSH"
}, {
"hash" : "60ae673acad69c86c771dd1c0fd772772f38cfa8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33190",
"triggerID" : "60ae673acad69c86c771dd1c0fd772772f38cfa8",
"triggerType" : "PUSH"
}, {
"hash" : "d013f8148fa4925a984a62267d91fd6b33f13eeb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33195",
"triggerID" : "d013f8148fa4925a984a62267d91fd6b33f13eeb",
"triggerType" : "PUSH"
}, {
"hash" : "2956f30f6d565e77b74a9964a49c00d005aca5c7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33196",
"triggerID" : "2956f30f6d565e77b74a9964a49c00d005aca5c7",
"triggerType" : "PUSH"
}, {
"hash" : "72c13df14fc83f64b67e20ecae82c25dbf49e6b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33236",
"triggerID" : "72c13df14fc83f64b67e20ecae82c25dbf49e6b7",
"triggerType" : "PUSH"
}, {
"hash" : "1e5e3cab5533bf80cf20e980debe66719a960741",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33360",
"triggerID" : "1e5e3cab5533bf80cf20e980debe66719a960741",
"triggerType" : "PUSH"
}, {
"hash" : "5bbab8b28bbe2e63c46e26e609d08c48ab580364",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33490",
"triggerID" : "5bbab8b28bbe2e63c46e26e609d08c48ab580364",
"triggerType" : "PUSH"
}, {
"hash" : "8b28c8df7c96a3bab4cdfc30ff45d4912ce048b1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33615",
"triggerID" : "8b28c8df7c96a3bab4cdfc30ff45d4912ce048b1",
"triggerType" : "PUSH"
}, {
"hash" : "82bf6b61e372f2cd1f8eef0429f4d134df1e257e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33616",
"triggerID" : "82bf6b61e372f2cd1f8eef0429f4d134df1e257e",
"triggerType" : "PUSH"
}, {
"hash" : "82bf6b61e372f2cd1f8eef0429f4d134df1e257e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33616",
"triggerID" : "1076106270",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 82bf6b61e372f2cd1f8eef0429f4d134df1e257e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33616)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19116: [FLINK-26616][tests] Remove deadlines from CommonTestUtils
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19116:
URL: https://github.com/apache/flink/pull/19116#issuecomment-1069128888
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ce239101f1da9f768fd1b0857392a57cc4aed72d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33182",
"triggerID" : "ce239101f1da9f768fd1b0857392a57cc4aed72d",
"triggerType" : "PUSH"
}, {
"hash" : "60ae673acad69c86c771dd1c0fd772772f38cfa8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33190",
"triggerID" : "60ae673acad69c86c771dd1c0fd772772f38cfa8",
"triggerType" : "PUSH"
}, {
"hash" : "d013f8148fa4925a984a62267d91fd6b33f13eeb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33195",
"triggerID" : "d013f8148fa4925a984a62267d91fd6b33f13eeb",
"triggerType" : "PUSH"
}, {
"hash" : "2956f30f6d565e77b74a9964a49c00d005aca5c7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33196",
"triggerID" : "2956f30f6d565e77b74a9964a49c00d005aca5c7",
"triggerType" : "PUSH"
}, {
"hash" : "72c13df14fc83f64b67e20ecae82c25dbf49e6b7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "72c13df14fc83f64b67e20ecae82c25dbf49e6b7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2956f30f6d565e77b74a9964a49c00d005aca5c7 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33196)
* 72c13df14fc83f64b67e20ecae82c25dbf49e6b7 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] XComp commented on pull request #19116: [FLINK-26616][tests] Remove deadlines from CommonTestUtils
Posted by GitBox <gi...@apache.org>.
XComp commented on pull request #19116:
URL: https://github.com/apache/flink/pull/19116#issuecomment-1072328700
@zentol There's still something odd with `DefaultLeaderRetrievalServiceTest`. Have you looked into the CI error?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19116: [FLINK-26616][tests] Remove deadlines from CommonTestUtils
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19116:
URL: https://github.com/apache/flink/pull/19116#issuecomment-1069128888
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ce239101f1da9f768fd1b0857392a57cc4aed72d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33182",
"triggerID" : "ce239101f1da9f768fd1b0857392a57cc4aed72d",
"triggerType" : "PUSH"
}, {
"hash" : "60ae673acad69c86c771dd1c0fd772772f38cfa8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33190",
"triggerID" : "60ae673acad69c86c771dd1c0fd772772f38cfa8",
"triggerType" : "PUSH"
}, {
"hash" : "d013f8148fa4925a984a62267d91fd6b33f13eeb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33195",
"triggerID" : "d013f8148fa4925a984a62267d91fd6b33f13eeb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d013f8148fa4925a984a62267d91fd6b33f13eeb Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33195)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19116: [FLINK-26616][tests] Remove deadlines from CommonTestUtils
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19116:
URL: https://github.com/apache/flink/pull/19116#issuecomment-1069128888
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ce239101f1da9f768fd1b0857392a57cc4aed72d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33182",
"triggerID" : "ce239101f1da9f768fd1b0857392a57cc4aed72d",
"triggerType" : "PUSH"
}, {
"hash" : "60ae673acad69c86c771dd1c0fd772772f38cfa8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33190",
"triggerID" : "60ae673acad69c86c771dd1c0fd772772f38cfa8",
"triggerType" : "PUSH"
}, {
"hash" : "d013f8148fa4925a984a62267d91fd6b33f13eeb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33195",
"triggerID" : "d013f8148fa4925a984a62267d91fd6b33f13eeb",
"triggerType" : "PUSH"
}, {
"hash" : "2956f30f6d565e77b74a9964a49c00d005aca5c7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33196",
"triggerID" : "2956f30f6d565e77b74a9964a49c00d005aca5c7",
"triggerType" : "PUSH"
}, {
"hash" : "72c13df14fc83f64b67e20ecae82c25dbf49e6b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33236",
"triggerID" : "72c13df14fc83f64b67e20ecae82c25dbf49e6b7",
"triggerType" : "PUSH"
}, {
"hash" : "1e5e3cab5533bf80cf20e980debe66719a960741",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33360",
"triggerID" : "1e5e3cab5533bf80cf20e980debe66719a960741",
"triggerType" : "PUSH"
}, {
"hash" : "5bbab8b28bbe2e63c46e26e609d08c48ab580364",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33490",
"triggerID" : "5bbab8b28bbe2e63c46e26e609d08c48ab580364",
"triggerType" : "PUSH"
}, {
"hash" : "8b28c8df7c96a3bab4cdfc30ff45d4912ce048b1",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33615",
"triggerID" : "8b28c8df7c96a3bab4cdfc30ff45d4912ce048b1",
"triggerType" : "PUSH"
}, {
"hash" : "82bf6b61e372f2cd1f8eef0429f4d134df1e257e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33616",
"triggerID" : "82bf6b61e372f2cd1f8eef0429f4d134df1e257e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8b28c8df7c96a3bab4cdfc30ff45d4912ce048b1 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33615)
* 82bf6b61e372f2cd1f8eef0429f4d134df1e257e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33616)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19116: [FLINK-26616][tests] Remove deadlines from CommonTestUtils
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19116:
URL: https://github.com/apache/flink/pull/19116#issuecomment-1069128888
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ce239101f1da9f768fd1b0857392a57cc4aed72d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33182",
"triggerID" : "ce239101f1da9f768fd1b0857392a57cc4aed72d",
"triggerType" : "PUSH"
}, {
"hash" : "60ae673acad69c86c771dd1c0fd772772f38cfa8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33190",
"triggerID" : "60ae673acad69c86c771dd1c0fd772772f38cfa8",
"triggerType" : "PUSH"
}, {
"hash" : "d013f8148fa4925a984a62267d91fd6b33f13eeb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33195",
"triggerID" : "d013f8148fa4925a984a62267d91fd6b33f13eeb",
"triggerType" : "PUSH"
}, {
"hash" : "2956f30f6d565e77b74a9964a49c00d005aca5c7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33196",
"triggerID" : "2956f30f6d565e77b74a9964a49c00d005aca5c7",
"triggerType" : "PUSH"
}, {
"hash" : "72c13df14fc83f64b67e20ecae82c25dbf49e6b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33236",
"triggerID" : "72c13df14fc83f64b67e20ecae82c25dbf49e6b7",
"triggerType" : "PUSH"
}, {
"hash" : "1e5e3cab5533bf80cf20e980debe66719a960741",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33360",
"triggerID" : "1e5e3cab5533bf80cf20e980debe66719a960741",
"triggerType" : "PUSH"
}, {
"hash" : "5bbab8b28bbe2e63c46e26e609d08c48ab580364",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33490",
"triggerID" : "5bbab8b28bbe2e63c46e26e609d08c48ab580364",
"triggerType" : "PUSH"
}, {
"hash" : "8b28c8df7c96a3bab4cdfc30ff45d4912ce048b1",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33615",
"triggerID" : "8b28c8df7c96a3bab4cdfc30ff45d4912ce048b1",
"triggerType" : "PUSH"
}, {
"hash" : "82bf6b61e372f2cd1f8eef0429f4d134df1e257e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "82bf6b61e372f2cd1f8eef0429f4d134df1e257e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5bbab8b28bbe2e63c46e26e609d08c48ab580364 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33490)
* 8b28c8df7c96a3bab4cdfc30ff45d4912ce048b1 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33615)
* 82bf6b61e372f2cd1f8eef0429f4d134df1e257e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19116: [FLINK-26616][tests] Remove deadlines from CommonTestUtils
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19116:
URL: https://github.com/apache/flink/pull/19116#issuecomment-1069128888
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ce239101f1da9f768fd1b0857392a57cc4aed72d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33182",
"triggerID" : "ce239101f1da9f768fd1b0857392a57cc4aed72d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ce239101f1da9f768fd1b0857392a57cc4aed72d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33182)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19116: [FLINK-26616][tests] Remove deadlines from CommonTestUtils
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19116:
URL: https://github.com/apache/flink/pull/19116#issuecomment-1069128888
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ce239101f1da9f768fd1b0857392a57cc4aed72d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33182",
"triggerID" : "ce239101f1da9f768fd1b0857392a57cc4aed72d",
"triggerType" : "PUSH"
}, {
"hash" : "60ae673acad69c86c771dd1c0fd772772f38cfa8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "60ae673acad69c86c771dd1c0fd772772f38cfa8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ce239101f1da9f768fd1b0857392a57cc4aed72d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33182)
* 60ae673acad69c86c771dd1c0fd772772f38cfa8 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19116: [FLINK-26616][tests] Remove deadlines from CommonTestUtils
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19116:
URL: https://github.com/apache/flink/pull/19116#issuecomment-1069128888
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ce239101f1da9f768fd1b0857392a57cc4aed72d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33182",
"triggerID" : "ce239101f1da9f768fd1b0857392a57cc4aed72d",
"triggerType" : "PUSH"
}, {
"hash" : "60ae673acad69c86c771dd1c0fd772772f38cfa8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33190",
"triggerID" : "60ae673acad69c86c771dd1c0fd772772f38cfa8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 60ae673acad69c86c771dd1c0fd772772f38cfa8 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33190)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19116: [FLINK-26616][tests] Remove deadlines from CommonTestUtils
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19116:
URL: https://github.com/apache/flink/pull/19116#issuecomment-1069128888
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ce239101f1da9f768fd1b0857392a57cc4aed72d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33182",
"triggerID" : "ce239101f1da9f768fd1b0857392a57cc4aed72d",
"triggerType" : "PUSH"
}, {
"hash" : "60ae673acad69c86c771dd1c0fd772772f38cfa8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33190",
"triggerID" : "60ae673acad69c86c771dd1c0fd772772f38cfa8",
"triggerType" : "PUSH"
}, {
"hash" : "d013f8148fa4925a984a62267d91fd6b33f13eeb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33195",
"triggerID" : "d013f8148fa4925a984a62267d91fd6b33f13eeb",
"triggerType" : "PUSH"
}, {
"hash" : "2956f30f6d565e77b74a9964a49c00d005aca5c7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33196",
"triggerID" : "2956f30f6d565e77b74a9964a49c00d005aca5c7",
"triggerType" : "PUSH"
}, {
"hash" : "72c13df14fc83f64b67e20ecae82c25dbf49e6b7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33236",
"triggerID" : "72c13df14fc83f64b67e20ecae82c25dbf49e6b7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 72c13df14fc83f64b67e20ecae82c25dbf49e6b7 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33236)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19116: [FLINK-26616][tests] Remove deadlines from CommonTestUtils
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19116:
URL: https://github.com/apache/flink/pull/19116#issuecomment-1069128888
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ce239101f1da9f768fd1b0857392a57cc4aed72d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33182",
"triggerID" : "ce239101f1da9f768fd1b0857392a57cc4aed72d",
"triggerType" : "PUSH"
}, {
"hash" : "60ae673acad69c86c771dd1c0fd772772f38cfa8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33190",
"triggerID" : "60ae673acad69c86c771dd1c0fd772772f38cfa8",
"triggerType" : "PUSH"
}, {
"hash" : "d013f8148fa4925a984a62267d91fd6b33f13eeb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33195",
"triggerID" : "d013f8148fa4925a984a62267d91fd6b33f13eeb",
"triggerType" : "PUSH"
}, {
"hash" : "2956f30f6d565e77b74a9964a49c00d005aca5c7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33196",
"triggerID" : "2956f30f6d565e77b74a9964a49c00d005aca5c7",
"triggerType" : "PUSH"
}, {
"hash" : "72c13df14fc83f64b67e20ecae82c25dbf49e6b7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33236",
"triggerID" : "72c13df14fc83f64b67e20ecae82c25dbf49e6b7",
"triggerType" : "PUSH"
}, {
"hash" : "1e5e3cab5533bf80cf20e980debe66719a960741",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33360",
"triggerID" : "1e5e3cab5533bf80cf20e980debe66719a960741",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 72c13df14fc83f64b67e20ecae82c25dbf49e6b7 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33236)
* 1e5e3cab5533bf80cf20e980debe66719a960741 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33360)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19116: [FLINK-26616][tests] Remove deadlines from CommonTestUtils
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19116:
URL: https://github.com/apache/flink/pull/19116#issuecomment-1069128888
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ce239101f1da9f768fd1b0857392a57cc4aed72d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33182",
"triggerID" : "ce239101f1da9f768fd1b0857392a57cc4aed72d",
"triggerType" : "PUSH"
}, {
"hash" : "60ae673acad69c86c771dd1c0fd772772f38cfa8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33190",
"triggerID" : "60ae673acad69c86c771dd1c0fd772772f38cfa8",
"triggerType" : "PUSH"
}, {
"hash" : "d013f8148fa4925a984a62267d91fd6b33f13eeb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33195",
"triggerID" : "d013f8148fa4925a984a62267d91fd6b33f13eeb",
"triggerType" : "PUSH"
}, {
"hash" : "2956f30f6d565e77b74a9964a49c00d005aca5c7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33196",
"triggerID" : "2956f30f6d565e77b74a9964a49c00d005aca5c7",
"triggerType" : "PUSH"
}, {
"hash" : "72c13df14fc83f64b67e20ecae82c25dbf49e6b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33236",
"triggerID" : "72c13df14fc83f64b67e20ecae82c25dbf49e6b7",
"triggerType" : "PUSH"
}, {
"hash" : "1e5e3cab5533bf80cf20e980debe66719a960741",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33360",
"triggerID" : "1e5e3cab5533bf80cf20e980debe66719a960741",
"triggerType" : "PUSH"
}, {
"hash" : "5bbab8b28bbe2e63c46e26e609d08c48ab580364",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33490",
"triggerID" : "5bbab8b28bbe2e63c46e26e609d08c48ab580364",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1e5e3cab5533bf80cf20e980debe66719a960741 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33360)
* 5bbab8b28bbe2e63c46e26e609d08c48ab580364 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33490)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] XComp commented on a change in pull request #19116: [FLINK-26616][tests] Remove deadlines from CommonTestUtils
Posted by GitBox <gi...@apache.org>.
XComp commented on a change in pull request #19116:
URL: https://github.com/apache/flink/pull/19116#discussion_r832319562
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/leaderretrieval/DefaultLeaderRetrievalServiceTest.java
##########
@@ -112,13 +110,6 @@ public void testErrorIsIgnoredAfterBeingStop() throws Exception {
leaderRetrievalService.stop();
testingLeaderRetrievalDriver.onFatalError(testException);
- try {
- testingListener.waitForError(timeout);
Review comment:
We cannot just remove this because waitForError polls the error from the errorQueue in TestingRetrievalBase. This test doesn't even fail when `leaderRetrievalService.stop()` is commented out.
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElectionServiceTest.java
##########
@@ -258,15 +256,6 @@ public void testErrorIsIgnoredAfterBeingStop() throws Exception {
leaderElectionService.stop();
testingLeaderElectionDriver.onFatalError(testException);
-
- try {
- testingContender.waitForError(timeout);
Review comment:
We cannot just remove this because `waitForError` polls the error from the `errorQueue` in `TestingLeaderBase`. This test doesn't even fail when `leaderElectionService.stop()` is commented out.
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/leaderelection/TestingRetrievalBase.java
##########
@@ -68,28 +62,21 @@ public String waitForNewLeader(long timeout) throws Exception {
public void waitForEmptyLeaderInformation(long timeout) throws Exception {
throwExceptionIfNotNull();
- final String errorMsg =
- "Listener was not notified about an empty leader within " + timeout + "ms";
CommonTestUtils.waitUntilCondition(
() -> {
leader = leaderEventQueue.poll(timeout, TimeUnit.MILLISECONDS);
return leader != null && leader.isEmpty();
- },
- Deadline.fromNow(Duration.ofMillis(timeout)),
- errorMsg);
+ });
oldAddress = null;
}
public void waitForError(long timeout) throws Exception {
- final String errorMsg = "Listener did not see an exception with " + timeout + "ms";
CommonTestUtils.waitUntilCondition(
() -> {
error = errorQueue.poll(timeout, TimeUnit.MILLISECONDS);
return error != null;
- },
- Deadline.fromNow(Duration.ofMillis(timeout)),
- errorMsg);
+ });
Review comment:
Just checked if that also applies for `waitFor[New|Empty]Leader`. But there we still need the `oldAddress` for verification.
##########
File path: flink-yarn-tests/src/test/java/org/apache/flink/yarn/YARNHighAvailabilityITCase.java
##########
@@ -262,8 +261,7 @@ private void waitForApplicationAttempt(final ApplicationId applicationId, final
yarnClient.getApplicationReport(applicationId);
return applicationReport.getCurrentApplicationAttemptId().getAttemptId()
>= attemptId;
- },
- Deadline.fromNow(TIMEOUT));
+ });
Review comment:
nit: TIMEOUT is only used in `waitForJobTermination`. We could move the value of the variable into that method to improve code readability...
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/leaderelection/TestingLeaderBase.java
##########
@@ -44,44 +42,35 @@
public void waitForLeader(long timeout) throws Exception {
throwExceptionIfNotNull();
- final String errorMsg = "Contender was not elected as the leader within " + timeout + "ms";
CommonTestUtils.waitUntilCondition(
() -> {
final LeaderInformation leader =
leaderEventQueue.poll(timeout, TimeUnit.MILLISECONDS);
return leader != null && !leader.isEmpty();
- },
- Deadline.fromNow(Duration.ofMillis(timeout)),
- errorMsg);
+ });
isLeader = true;
}
public void waitForRevokeLeader(long timeout) throws Exception {
throwExceptionIfNotNull();
- final String errorMsg = "Contender was not revoked within " + timeout + "ms";
CommonTestUtils.waitUntilCondition(
() -> {
final LeaderInformation leader =
leaderEventQueue.poll(timeout, TimeUnit.MILLISECONDS);
return leader != null && leader.isEmpty();
- },
- Deadline.fromNow(Duration.ofMillis(timeout)),
- errorMsg);
+ });
isLeader = false;
}
public void waitForError(long timeout) throws Exception {
- final String errorMsg = "Contender did not see an exception with " + timeout + "ms";
CommonTestUtils.waitUntilCondition(
() -> {
error = errorQueue.poll(timeout, TimeUnit.MILLISECONDS);
return error != null;
- },
- Deadline.fromNow(Duration.ofMillis(timeout)),
- errorMsg);
+ });
Review comment:
I'm wondering whether errorQueue.poll(...) without the `waitUntilCondition` method call would be sufficient enough. Returning the error would make `getError` obsolete as well.
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/leaderelection/TestingRetrievalBase.java
##########
@@ -68,28 +62,21 @@ public String waitForNewLeader(long timeout) throws Exception {
public void waitForEmptyLeaderInformation(long timeout) throws Exception {
throwExceptionIfNotNull();
- final String errorMsg =
- "Listener was not notified about an empty leader within " + timeout + "ms";
CommonTestUtils.waitUntilCondition(
() -> {
leader = leaderEventQueue.poll(timeout, TimeUnit.MILLISECONDS);
return leader != null && leader.isEmpty();
- },
- Deadline.fromNow(Duration.ofMillis(timeout)),
- errorMsg);
+ });
oldAddress = null;
}
public void waitForError(long timeout) throws Exception {
- final String errorMsg = "Listener did not see an exception with " + timeout + "ms";
CommonTestUtils.waitUntilCondition(
() -> {
error = errorQueue.poll(timeout, TimeUnit.MILLISECONDS);
return error != null;
- },
- Deadline.fromNow(Duration.ofMillis(timeout)),
- errorMsg);
+ });
Review comment:
Same as for the `TestingLeaderBase.waitForError` method
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/testutils/CommonTestUtils.java
##########
@@ -131,40 +128,16 @@ public static void printLog4jDebugConfig(File file) throws IOException {
}
}
- public static void waitUntilCondition(
- SupplierWithException<Boolean, Exception> condition, Deadline timeout)
- throws Exception {
- waitUntilCondition(condition, timeout, RETRY_INTERVAL);
- }
-
- public static void waitUntilCondition(
- SupplierWithException<Boolean, Exception> condition,
- Deadline timeout,
- long retryIntervalMillis)
- throws Exception {
- waitUntilCondition(
- condition, timeout, retryIntervalMillis, "Condition was not met in given timeout.");
- }
-
- public static void waitUntilCondition(
- SupplierWithException<Boolean, Exception> condition, Deadline timeout, String errorMsg)
+ public static void waitUntilCondition(SupplierWithException<Boolean, Exception> condition)
Review comment:
Is there a reason why we keep the redundancy? `org.apache.flink.core.testutils.CommonTestUtils` is accessible from within `flink-runtime` as well.
##########
File path: flink-yarn-tests/src/test/java/org/apache/flink/yarn/YARNSessionCapacitySchedulerITCase.java
##########
@@ -390,16 +389,14 @@ private void submitJob(final String jobFileName) throws IOException, Interrupted
private static void waitForTaskManagerRegistration(
final String host, final int port, final Duration waitDuration) throws Exception {
Review comment:
```suggestion
final String host, final int port) throws Exception {
```
`waitDuration` is not used anymore
##########
File path: flink-yarn-tests/src/test/java/org/apache/flink/yarn/YARNSessionFIFOITCase.java
##########
@@ -157,12 +156,7 @@ ApplicationId runDetachedModeTest(Map<String, String> securityProperties) throws
// wait until two containers are running
LOG.info("Waiting until two containers are running");
CommonTestUtils.waitUntilCondition(
- () -> getRunningContainers() >= 2,
- Deadline.fromNow(timeout),
- testConditionIntervalInMillis,
- "We didn't reach the state of two containers running (instead: "
- + getRunningContainers()
- + ")");
+ () -> getRunningContainers() >= 2, testConditionIntervalInMillis);
Review comment:
the local `timeout` variable is unused now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19116: [FLINK-26616][tests] Remove deadlines from CommonTestUtils
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19116:
URL: https://github.com/apache/flink/pull/19116#issuecomment-1069128888
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ce239101f1da9f768fd1b0857392a57cc4aed72d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33182",
"triggerID" : "ce239101f1da9f768fd1b0857392a57cc4aed72d",
"triggerType" : "PUSH"
}, {
"hash" : "60ae673acad69c86c771dd1c0fd772772f38cfa8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33190",
"triggerID" : "60ae673acad69c86c771dd1c0fd772772f38cfa8",
"triggerType" : "PUSH"
}, {
"hash" : "d013f8148fa4925a984a62267d91fd6b33f13eeb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33195",
"triggerID" : "d013f8148fa4925a984a62267d91fd6b33f13eeb",
"triggerType" : "PUSH"
}, {
"hash" : "2956f30f6d565e77b74a9964a49c00d005aca5c7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2956f30f6d565e77b74a9964a49c00d005aca5c7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d013f8148fa4925a984a62267d91fd6b33f13eeb Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33195)
* 2956f30f6d565e77b74a9964a49c00d005aca5c7 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19116: [FLINK-26616][tests] Remove deadlines from CommonTestUtils
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19116:
URL: https://github.com/apache/flink/pull/19116#issuecomment-1069128888
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ce239101f1da9f768fd1b0857392a57cc4aed72d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33182",
"triggerID" : "ce239101f1da9f768fd1b0857392a57cc4aed72d",
"triggerType" : "PUSH"
}, {
"hash" : "60ae673acad69c86c771dd1c0fd772772f38cfa8",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33190",
"triggerID" : "60ae673acad69c86c771dd1c0fd772772f38cfa8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ce239101f1da9f768fd1b0857392a57cc4aed72d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33182)
* 60ae673acad69c86c771dd1c0fd772772f38cfa8 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33190)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #19116: [FLINK-26616][tests] Remove deadlines from CommonTestUtils
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #19116:
URL: https://github.com/apache/flink/pull/19116#discussion_r832423015
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElectionServiceTest.java
##########
@@ -258,15 +256,6 @@ public void testErrorIsIgnoredAfterBeingStop() throws Exception {
leaderElectionService.stop();
testingLeaderElectionDriver.onFatalError(testException);
-
- try {
- testingContender.waitForError(timeout);
Review comment:
wasn't aware that getError doesn't poll from the queue; have a simple fix for that though...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19116: [FLINK-26616][tests] Remove deadlines from CommonTestUtils
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19116:
URL: https://github.com/apache/flink/pull/19116#issuecomment-1069128888
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ce239101f1da9f768fd1b0857392a57cc4aed72d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33182",
"triggerID" : "ce239101f1da9f768fd1b0857392a57cc4aed72d",
"triggerType" : "PUSH"
}, {
"hash" : "60ae673acad69c86c771dd1c0fd772772f38cfa8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33190",
"triggerID" : "60ae673acad69c86c771dd1c0fd772772f38cfa8",
"triggerType" : "PUSH"
}, {
"hash" : "d013f8148fa4925a984a62267d91fd6b33f13eeb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33195",
"triggerID" : "d013f8148fa4925a984a62267d91fd6b33f13eeb",
"triggerType" : "PUSH"
}, {
"hash" : "2956f30f6d565e77b74a9964a49c00d005aca5c7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33196",
"triggerID" : "2956f30f6d565e77b74a9964a49c00d005aca5c7",
"triggerType" : "PUSH"
}, {
"hash" : "72c13df14fc83f64b67e20ecae82c25dbf49e6b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33236",
"triggerID" : "72c13df14fc83f64b67e20ecae82c25dbf49e6b7",
"triggerType" : "PUSH"
}, {
"hash" : "1e5e3cab5533bf80cf20e980debe66719a960741",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33360",
"triggerID" : "1e5e3cab5533bf80cf20e980debe66719a960741",
"triggerType" : "PUSH"
}, {
"hash" : "5bbab8b28bbe2e63c46e26e609d08c48ab580364",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33490",
"triggerID" : "5bbab8b28bbe2e63c46e26e609d08c48ab580364",
"triggerType" : "PUSH"
}, {
"hash" : "8b28c8df7c96a3bab4cdfc30ff45d4912ce048b1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33615",
"triggerID" : "8b28c8df7c96a3bab4cdfc30ff45d4912ce048b1",
"triggerType" : "PUSH"
}, {
"hash" : "82bf6b61e372f2cd1f8eef0429f4d134df1e257e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33616",
"triggerID" : "82bf6b61e372f2cd1f8eef0429f4d134df1e257e",
"triggerType" : "PUSH"
}, {
"hash" : "82bf6b61e372f2cd1f8eef0429f4d134df1e257e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33616",
"triggerID" : "1076106270",
"triggerType" : "MANUAL"
}, {
"hash" : "8d34ceae287d88617520f66ab45ac9292a71c8f8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8d34ceae287d88617520f66ab45ac9292a71c8f8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 82bf6b61e372f2cd1f8eef0429f4d134df1e257e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33616)
* 8d34ceae287d88617520f66ab45ac9292a71c8f8 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19116: [FLINK-26616][tests] Remove deadlines from CommonTestUtils
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19116:
URL: https://github.com/apache/flink/pull/19116#issuecomment-1069128888
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ce239101f1da9f768fd1b0857392a57cc4aed72d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33182",
"triggerID" : "ce239101f1da9f768fd1b0857392a57cc4aed72d",
"triggerType" : "PUSH"
}, {
"hash" : "60ae673acad69c86c771dd1c0fd772772f38cfa8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33190",
"triggerID" : "60ae673acad69c86c771dd1c0fd772772f38cfa8",
"triggerType" : "PUSH"
}, {
"hash" : "d013f8148fa4925a984a62267d91fd6b33f13eeb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33195",
"triggerID" : "d013f8148fa4925a984a62267d91fd6b33f13eeb",
"triggerType" : "PUSH"
}, {
"hash" : "2956f30f6d565e77b74a9964a49c00d005aca5c7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33196",
"triggerID" : "2956f30f6d565e77b74a9964a49c00d005aca5c7",
"triggerType" : "PUSH"
}, {
"hash" : "72c13df14fc83f64b67e20ecae82c25dbf49e6b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33236",
"triggerID" : "72c13df14fc83f64b67e20ecae82c25dbf49e6b7",
"triggerType" : "PUSH"
}, {
"hash" : "1e5e3cab5533bf80cf20e980debe66719a960741",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33360",
"triggerID" : "1e5e3cab5533bf80cf20e980debe66719a960741",
"triggerType" : "PUSH"
}, {
"hash" : "5bbab8b28bbe2e63c46e26e609d08c48ab580364",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33490",
"triggerID" : "5bbab8b28bbe2e63c46e26e609d08c48ab580364",
"triggerType" : "PUSH"
}, {
"hash" : "8b28c8df7c96a3bab4cdfc30ff45d4912ce048b1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33615",
"triggerID" : "8b28c8df7c96a3bab4cdfc30ff45d4912ce048b1",
"triggerType" : "PUSH"
}, {
"hash" : "82bf6b61e372f2cd1f8eef0429f4d134df1e257e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33616",
"triggerID" : "82bf6b61e372f2cd1f8eef0429f4d134df1e257e",
"triggerType" : "PUSH"
}, {
"hash" : "82bf6b61e372f2cd1f8eef0429f4d134df1e257e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33616",
"triggerID" : "1076106270",
"triggerType" : "MANUAL"
}, {
"hash" : "8d34ceae287d88617520f66ab45ac9292a71c8f8",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33851",
"triggerID" : "8d34ceae287d88617520f66ab45ac9292a71c8f8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8d34ceae287d88617520f66ab45ac9292a71c8f8 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33851)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19116: [FLINK-26616][tests] Remove deadlines from CommonTestUtils
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19116:
URL: https://github.com/apache/flink/pull/19116#issuecomment-1069128888
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ce239101f1da9f768fd1b0857392a57cc4aed72d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33182",
"triggerID" : "ce239101f1da9f768fd1b0857392a57cc4aed72d",
"triggerType" : "PUSH"
}, {
"hash" : "60ae673acad69c86c771dd1c0fd772772f38cfa8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33190",
"triggerID" : "60ae673acad69c86c771dd1c0fd772772f38cfa8",
"triggerType" : "PUSH"
}, {
"hash" : "d013f8148fa4925a984a62267d91fd6b33f13eeb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33195",
"triggerID" : "d013f8148fa4925a984a62267d91fd6b33f13eeb",
"triggerType" : "PUSH"
}, {
"hash" : "2956f30f6d565e77b74a9964a49c00d005aca5c7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33196",
"triggerID" : "2956f30f6d565e77b74a9964a49c00d005aca5c7",
"triggerType" : "PUSH"
}, {
"hash" : "72c13df14fc83f64b67e20ecae82c25dbf49e6b7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33236",
"triggerID" : "72c13df14fc83f64b67e20ecae82c25dbf49e6b7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2956f30f6d565e77b74a9964a49c00d005aca5c7 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33196)
* 72c13df14fc83f64b67e20ecae82c25dbf49e6b7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33236)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19116: [FLINK-26616][tests] Remove deadlines from CommonTestUtils
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19116:
URL: https://github.com/apache/flink/pull/19116#issuecomment-1069128888
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ce239101f1da9f768fd1b0857392a57cc4aed72d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33182",
"triggerID" : "ce239101f1da9f768fd1b0857392a57cc4aed72d",
"triggerType" : "PUSH"
}, {
"hash" : "60ae673acad69c86c771dd1c0fd772772f38cfa8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33190",
"triggerID" : "60ae673acad69c86c771dd1c0fd772772f38cfa8",
"triggerType" : "PUSH"
}, {
"hash" : "d013f8148fa4925a984a62267d91fd6b33f13eeb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33195",
"triggerID" : "d013f8148fa4925a984a62267d91fd6b33f13eeb",
"triggerType" : "PUSH"
}, {
"hash" : "2956f30f6d565e77b74a9964a49c00d005aca5c7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33196",
"triggerID" : "2956f30f6d565e77b74a9964a49c00d005aca5c7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2956f30f6d565e77b74a9964a49c00d005aca5c7 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33196)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] XComp commented on a change in pull request #19116: [FLINK-26616][tests] Remove deadlines from CommonTestUtils
Posted by GitBox <gi...@apache.org>.
XComp commented on a change in pull request #19116:
URL: https://github.com/apache/flink/pull/19116#discussion_r832436523
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/testutils/CommonTestUtils.java
##########
@@ -131,40 +128,16 @@ public static void printLog4jDebugConfig(File file) throws IOException {
}
}
- public static void waitUntilCondition(
- SupplierWithException<Boolean, Exception> condition, Deadline timeout)
- throws Exception {
- waitUntilCondition(condition, timeout, RETRY_INTERVAL);
- }
-
- public static void waitUntilCondition(
- SupplierWithException<Boolean, Exception> condition,
- Deadline timeout,
- long retryIntervalMillis)
- throws Exception {
- waitUntilCondition(
- condition, timeout, retryIntervalMillis, "Condition was not met in given timeout.");
- }
-
- public static void waitUntilCondition(
- SupplierWithException<Boolean, Exception> condition, Deadline timeout, String errorMsg)
+ public static void waitUntilCondition(SupplierWithException<Boolean, Exception> condition)
Review comment:
Yes, I was wondering whether we should clean that up as part of this PR...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on pull request #19116: [FLINK-26616][tests] Remove deadlines from CommonTestUtils
Posted by GitBox <gi...@apache.org>.
zentol commented on pull request #19116:
URL: https://github.com/apache/flink/pull/19116#issuecomment-1076106270
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19116: [FLINK-26616][tests] Remove deadlines from CommonTestUtils
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19116:
URL: https://github.com/apache/flink/pull/19116#issuecomment-1069128888
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ce239101f1da9f768fd1b0857392a57cc4aed72d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33182",
"triggerID" : "ce239101f1da9f768fd1b0857392a57cc4aed72d",
"triggerType" : "PUSH"
}, {
"hash" : "60ae673acad69c86c771dd1c0fd772772f38cfa8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33190",
"triggerID" : "60ae673acad69c86c771dd1c0fd772772f38cfa8",
"triggerType" : "PUSH"
}, {
"hash" : "d013f8148fa4925a984a62267d91fd6b33f13eeb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33195",
"triggerID" : "d013f8148fa4925a984a62267d91fd6b33f13eeb",
"triggerType" : "PUSH"
}, {
"hash" : "2956f30f6d565e77b74a9964a49c00d005aca5c7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33196",
"triggerID" : "2956f30f6d565e77b74a9964a49c00d005aca5c7",
"triggerType" : "PUSH"
}, {
"hash" : "72c13df14fc83f64b67e20ecae82c25dbf49e6b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33236",
"triggerID" : "72c13df14fc83f64b67e20ecae82c25dbf49e6b7",
"triggerType" : "PUSH"
}, {
"hash" : "1e5e3cab5533bf80cf20e980debe66719a960741",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33360",
"triggerID" : "1e5e3cab5533bf80cf20e980debe66719a960741",
"triggerType" : "PUSH"
}, {
"hash" : "5bbab8b28bbe2e63c46e26e609d08c48ab580364",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33490",
"triggerID" : "5bbab8b28bbe2e63c46e26e609d08c48ab580364",
"triggerType" : "PUSH"
}, {
"hash" : "8b28c8df7c96a3bab4cdfc30ff45d4912ce048b1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33615",
"triggerID" : "8b28c8df7c96a3bab4cdfc30ff45d4912ce048b1",
"triggerType" : "PUSH"
}, {
"hash" : "82bf6b61e372f2cd1f8eef0429f4d134df1e257e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33616",
"triggerID" : "82bf6b61e372f2cd1f8eef0429f4d134df1e257e",
"triggerType" : "PUSH"
}, {
"hash" : "82bf6b61e372f2cd1f8eef0429f4d134df1e257e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33616",
"triggerID" : "1076106270",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 82bf6b61e372f2cd1f8eef0429f4d134df1e257e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33616)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] XComp commented on a change in pull request #19116: [FLINK-26616][tests] Remove deadlines from CommonTestUtils
Posted by GitBox <gi...@apache.org>.
XComp commented on a change in pull request #19116:
URL: https://github.com/apache/flink/pull/19116#discussion_r836421813
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/leaderelection/TestingRetrievalBase.java
##########
@@ -45,51 +42,36 @@
private String oldAddress;
private Throwable error;
- public String waitForNewLeader(long timeout) throws Exception {
+ public String waitForNewLeader() throws Exception {
throwExceptionIfNotNull();
- final String errorMsg =
- "Listener was not notified about a new leader within " + timeout + "ms";
CommonTestUtils.waitUntilCondition(
() -> {
- leader = leaderEventQueue.poll(timeout, TimeUnit.MILLISECONDS);
+ leader = leaderEventQueue.take();
return leader != null
&& !leader.isEmpty()
Review comment:
```suggestion
return !leader.isEmpty()
```
null check obsolete
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/leaderelection/TestingLeaderBase.java
##########
@@ -41,47 +38,32 @@
private boolean isLeader = false;
private Throwable error;
- public void waitForLeader(long timeout) throws Exception {
+ public void waitForLeader() throws Exception {
throwExceptionIfNotNull();
- final String errorMsg = "Contender was not elected as the leader within " + timeout + "ms";
CommonTestUtils.waitUntilCondition(
() -> {
- final LeaderInformation leader =
- leaderEventQueue.poll(timeout, TimeUnit.MILLISECONDS);
+ final LeaderInformation leader = leaderEventQueue.take();
return leader != null && !leader.isEmpty();
- },
- Deadline.fromNow(Duration.ofMillis(timeout)),
- errorMsg);
+ });
isLeader = true;
}
- public void waitForRevokeLeader(long timeout) throws Exception {
+ public void waitForRevokeLeader() throws Exception {
throwExceptionIfNotNull();
- final String errorMsg = "Contender was not revoked within " + timeout + "ms";
CommonTestUtils.waitUntilCondition(
() -> {
- final LeaderInformation leader =
- leaderEventQueue.poll(timeout, TimeUnit.MILLISECONDS);
+ final LeaderInformation leader = leaderEventQueue.take();
return leader != null && leader.isEmpty();
Review comment:
```suggestion
return !leader.isEmpty();
```
The `null` check is not necessary anymore.
##########
File path: flink-clients/src/test/java/org/apache/flink/client/deployment/application/ApplicationDispatcherBootstrapITCase.java
##########
@@ -223,7 +212,6 @@ public JobResultStore getJobResultStore() {
@Test
public void testSubmitFailedJobOnApplicationError() throws Exception {
- final Deadline deadline = Deadline.fromNow(TIMEOUT);
Review comment:
unused variable `TIMEOUT` in `ApplicationDispatcherBootstrapITCase`
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskExecutorITCase.java
##########
@@ -137,9 +136,7 @@ public void testJobRecoveryWithFailingTaskExecutor() throws Exception {
assertThat(jobResultFuture.isDone(), is(false));
CommonTestUtils.waitUntilCondition(
- jobIsRunning(() -> miniCluster.getExecutionGraph(jobGraph.getJobID())),
- Deadline.fromNow(TESTING_TIMEOUT),
Review comment:
The unused member `TESTING_TIMEOUT` can be removed...
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/leaderelection/TestingLeaderBase.java
##########
@@ -41,47 +38,32 @@
private boolean isLeader = false;
private Throwable error;
- public void waitForLeader(long timeout) throws Exception {
+ public void waitForLeader() throws Exception {
throwExceptionIfNotNull();
- final String errorMsg = "Contender was not elected as the leader within " + timeout + "ms";
CommonTestUtils.waitUntilCondition(
() -> {
- final LeaderInformation leader =
- leaderEventQueue.poll(timeout, TimeUnit.MILLISECONDS);
+ final LeaderInformation leader = leaderEventQueue.take();
return leader != null && !leader.isEmpty();
Review comment:
```suggestion
return !leader.isEmpty();
```
The `null` check is not necessary anymore.
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/testutils/MiniClusterResource.java
##########
@@ -159,8 +159,7 @@ private void cancelAllJobs(boolean waitUntilSlotsAreFreed) {
.isGloballyTerminalState())
.count();
return unfinishedJobs == 0;
- },
- jobCancellationDeadline);
Review comment:
It feels like we should get rid of the `jobCancellationDeadline` entirely in this method. There's no point in waiting forever for the jobs to finish if there's already another call that is actually blocked but runs into a timeout further up n this method...
##########
File path: flink-kubernetes/src/test/java/org/apache/flink/kubernetes/kubeclient/resources/TestingLeaderCallbackHandler.java
##########
@@ -70,31 +68,23 @@ public static String waitUntilNewLeaderAppears(long timeout) throws Exception {
final String lockIdentity = sharedQueue.poll(timeout, TimeUnit.MILLISECONDS);
Review comment:
I guess we could simplify the method even more (removing the `timeout` parameter) and using `sharedQueue.take()` instead of `poll`. WDYT?
##########
File path: flink-kubernetes/src/test/java/org/apache/flink/kubernetes/kubeclient/resources/TestingLeaderCallbackHandler.java
##########
@@ -70,31 +68,23 @@ public static String waitUntilNewLeaderAppears(long timeout) throws Exception {
final String lockIdentity = sharedQueue.poll(timeout, TimeUnit.MILLISECONDS);
leaderRef.set(lockIdentity);
return lockIdentity != null;
- },
- Deadline.fromNow(Duration.ofMillis(timeout)),
- "No leader is elected with " + timeout + "ms");
+ });
return leaderRef.get();
}
public void waitForNewLeader(long timeout) throws Exception {
- final String errorMsg =
- "No leader with " + lockIdentity + " is elected within " + timeout + "ms";
- poll(leaderQueue, timeout, errorMsg);
+ poll(leaderQueue, timeout);
}
public void waitForRevokeLeader(long timeout) throws Exception {
- final String errorMsg =
- "No leader with " + lockIdentity + " is revoke within " + timeout + "ms";
- poll(revokeQueue, timeout, errorMsg);
+ poll(revokeQueue, timeout);
}
- private void poll(BlockingQueue<String> queue, long timeout, String errorMsg) throws Exception {
+ private void poll(BlockingQueue<String> queue, long timeout) throws Exception {
CommonTestUtils.waitUntilCondition(
() -> {
final String lockIdentity = queue.poll(timeout, TimeUnit.MILLISECONDS);
Review comment:
Same here, `take` instead of `poll` would enablue us to remove the `timeout` parameter from this and its calling methods as well
##########
File path: flink-kubernetes/src/test/java/org/apache/flink/kubernetes/highavailability/KubernetesStateHandleStoreTest.java
##########
@@ -445,7 +445,7 @@ public void testReplaceWithNoLeadershipAndDiscardState() throws Exception {
store.addAndLock(key, state);
// Lost leadership
getLeaderCallback().notLeader();
- electionEventHandler.waitForRevokeLeader(TIMEOUT);
Review comment:
`TIMEOUT` in parent class could be annotated as `private` now
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/leaderelection/TestingRetrievalBase.java
##########
@@ -45,51 +42,36 @@
private String oldAddress;
private Throwable error;
- public String waitForNewLeader(long timeout) throws Exception {
+ public String waitForNewLeader() throws Exception {
throwExceptionIfNotNull();
- final String errorMsg =
- "Listener was not notified about a new leader within " + timeout + "ms";
CommonTestUtils.waitUntilCondition(
() -> {
- leader = leaderEventQueue.poll(timeout, TimeUnit.MILLISECONDS);
+ leader = leaderEventQueue.take();
return leader != null
&& !leader.isEmpty()
&& !leader.getLeaderAddress().equals(oldAddress);
- },
- Deadline.fromNow(Duration.ofMillis(timeout)),
- errorMsg);
+ });
oldAddress = leader.getLeaderAddress();
return leader.getLeaderAddress();
}
- public void waitForEmptyLeaderInformation(long timeout) throws Exception {
+ public void waitForEmptyLeaderInformation() throws Exception {
throwExceptionIfNotNull();
- final String errorMsg =
- "Listener was not notified about an empty leader within " + timeout + "ms";
CommonTestUtils.waitUntilCondition(
() -> {
- leader = leaderEventQueue.poll(timeout, TimeUnit.MILLISECONDS);
+ leader = leaderEventQueue.take();
return leader != null && leader.isEmpty();
Review comment:
```suggestion
return leader.isEmpty();
```
null check obsolete
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #19116: [FLINK-26616][tests] Remove deadlines from CommonTestUtils
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #19116:
URL: https://github.com/apache/flink/pull/19116#discussion_r836637193
##########
File path: flink-kubernetes/src/test/java/org/apache/flink/kubernetes/highavailability/KubernetesStateHandleStoreTest.java
##########
@@ -445,7 +445,7 @@ public void testReplaceWithNoLeadershipAndDiscardState() throws Exception {
store.addAndLock(key, state);
// Lost leadership
getLeaderCallback().notLeader();
- electionEventHandler.waitForRevokeLeader(TIMEOUT);
Review comment:
still used in the KubernetesHAServiceTest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] XComp commented on a change in pull request #19116: [FLINK-26616][tests] Remove deadlines from CommonTestUtils
Posted by GitBox <gi...@apache.org>.
XComp commented on a change in pull request #19116:
URL: https://github.com/apache/flink/pull/19116#discussion_r837117843
##########
File path: flink-kubernetes/src/test/java/org/apache/flink/kubernetes/highavailability/KubernetesStateHandleStoreTest.java
##########
@@ -445,7 +445,7 @@ public void testReplaceWithNoLeadershipAndDiscardState() throws Exception {
store.addAndLock(key, state);
// Lost leadership
getLeaderCallback().notLeader();
- electionEventHandler.waitForRevokeLeader(TIMEOUT);
Review comment:
yeah, I noticed it when continuing the review but forgot to delete this comment again...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19116: [FLINK-26616][tests] Remove deadlines from CommonTestUtils
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19116:
URL: https://github.com/apache/flink/pull/19116#issuecomment-1069128888
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ce239101f1da9f768fd1b0857392a57cc4aed72d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33182",
"triggerID" : "ce239101f1da9f768fd1b0857392a57cc4aed72d",
"triggerType" : "PUSH"
}, {
"hash" : "60ae673acad69c86c771dd1c0fd772772f38cfa8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33190",
"triggerID" : "60ae673acad69c86c771dd1c0fd772772f38cfa8",
"triggerType" : "PUSH"
}, {
"hash" : "d013f8148fa4925a984a62267d91fd6b33f13eeb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33195",
"triggerID" : "d013f8148fa4925a984a62267d91fd6b33f13eeb",
"triggerType" : "PUSH"
}, {
"hash" : "2956f30f6d565e77b74a9964a49c00d005aca5c7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33196",
"triggerID" : "2956f30f6d565e77b74a9964a49c00d005aca5c7",
"triggerType" : "PUSH"
}, {
"hash" : "72c13df14fc83f64b67e20ecae82c25dbf49e6b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33236",
"triggerID" : "72c13df14fc83f64b67e20ecae82c25dbf49e6b7",
"triggerType" : "PUSH"
}, {
"hash" : "1e5e3cab5533bf80cf20e980debe66719a960741",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33360",
"triggerID" : "1e5e3cab5533bf80cf20e980debe66719a960741",
"triggerType" : "PUSH"
}, {
"hash" : "5bbab8b28bbe2e63c46e26e609d08c48ab580364",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33490",
"triggerID" : "5bbab8b28bbe2e63c46e26e609d08c48ab580364",
"triggerType" : "PUSH"
}, {
"hash" : "8b28c8df7c96a3bab4cdfc30ff45d4912ce048b1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33615",
"triggerID" : "8b28c8df7c96a3bab4cdfc30ff45d4912ce048b1",
"triggerType" : "PUSH"
}, {
"hash" : "82bf6b61e372f2cd1f8eef0429f4d134df1e257e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33616",
"triggerID" : "82bf6b61e372f2cd1f8eef0429f4d134df1e257e",
"triggerType" : "PUSH"
}, {
"hash" : "82bf6b61e372f2cd1f8eef0429f4d134df1e257e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33616",
"triggerID" : "1076106270",
"triggerType" : "MANUAL"
}, {
"hash" : "8d34ceae287d88617520f66ab45ac9292a71c8f8",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33851",
"triggerID" : "8d34ceae287d88617520f66ab45ac9292a71c8f8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 82bf6b61e372f2cd1f8eef0429f4d134df1e257e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33616)
* 8d34ceae287d88617520f66ab45ac9292a71c8f8 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33851)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19116: [FLINK-26616][tests] Remove deadlines from CommonTestUtils
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19116:
URL: https://github.com/apache/flink/pull/19116#issuecomment-1069128888
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ce239101f1da9f768fd1b0857392a57cc4aed72d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33182",
"triggerID" : "ce239101f1da9f768fd1b0857392a57cc4aed72d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ce239101f1da9f768fd1b0857392a57cc4aed72d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33182)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19116: [FLINK-26616][tests] Remove deadlines from CommonTestUtils
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19116:
URL: https://github.com/apache/flink/pull/19116#issuecomment-1069128888
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ce239101f1da9f768fd1b0857392a57cc4aed72d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33182",
"triggerID" : "ce239101f1da9f768fd1b0857392a57cc4aed72d",
"triggerType" : "PUSH"
}, {
"hash" : "60ae673acad69c86c771dd1c0fd772772f38cfa8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "60ae673acad69c86c771dd1c0fd772772f38cfa8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ce239101f1da9f768fd1b0857392a57cc4aed72d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33182)
* 60ae673acad69c86c771dd1c0fd772772f38cfa8 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19116: [FLINK-26616][tests] Remove deadlines from CommonTestUtils
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19116:
URL: https://github.com/apache/flink/pull/19116#issuecomment-1069128888
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ce239101f1da9f768fd1b0857392a57cc4aed72d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33182",
"triggerID" : "ce239101f1da9f768fd1b0857392a57cc4aed72d",
"triggerType" : "PUSH"
}, {
"hash" : "60ae673acad69c86c771dd1c0fd772772f38cfa8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "60ae673acad69c86c771dd1c0fd772772f38cfa8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ce239101f1da9f768fd1b0857392a57cc4aed72d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33182)
* 60ae673acad69c86c771dd1c0fd772772f38cfa8 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #19116: [FLINK-26616][tests] Remove deadlines from CommonTestUtils
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #19116:
URL: https://github.com/apache/flink/pull/19116#discussion_r832435314
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/testutils/CommonTestUtils.java
##########
@@ -131,40 +128,16 @@ public static void printLog4jDebugConfig(File file) throws IOException {
}
}
- public static void waitUntilCondition(
- SupplierWithException<Boolean, Exception> condition, Deadline timeout)
- throws Exception {
- waitUntilCondition(condition, timeout, RETRY_INTERVAL);
- }
-
- public static void waitUntilCondition(
- SupplierWithException<Boolean, Exception> condition,
- Deadline timeout,
- long retryIntervalMillis)
- throws Exception {
- waitUntilCondition(
- condition, timeout, retryIntervalMillis, "Condition was not met in given timeout.");
- }
-
- public static void waitUntilCondition(
- SupplierWithException<Boolean, Exception> condition, Deadline timeout, String errorMsg)
+ public static void waitUntilCondition(SupplierWithException<Boolean, Exception> condition)
Review comment:
Are you referring to CommonTestUtils#waitUtil? Well I guess whoever added just didn't think things through. Nor checked for typos I'm afraid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #19116: [FLINK-26616][tests] Remove deadlines from CommonTestUtils
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #19116:
URL: https://github.com/apache/flink/pull/19116#discussion_r832502392
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/testutils/CommonTestUtils.java
##########
@@ -131,40 +128,16 @@ public static void printLog4jDebugConfig(File file) throws IOException {
}
}
- public static void waitUntilCondition(
- SupplierWithException<Boolean, Exception> condition, Deadline timeout)
- throws Exception {
- waitUntilCondition(condition, timeout, RETRY_INTERVAL);
- }
-
- public static void waitUntilCondition(
- SupplierWithException<Boolean, Exception> condition,
- Deadline timeout,
- long retryIntervalMillis)
- throws Exception {
- waitUntilCondition(
- condition, timeout, retryIntervalMillis, "Condition was not met in given timeout.");
- }
-
- public static void waitUntilCondition(
- SupplierWithException<Boolean, Exception> condition, Deadline timeout, String errorMsg)
+ public static void waitUntilCondition(SupplierWithException<Boolean, Exception> condition)
Review comment:
That's gonna be annoying because the classes have the same name, so you may end up with fully-qualified references within CommonTestUtils and current users of the runtime CommonTestUtils.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] XComp commented on pull request #19116: [FLINK-26616][tests] Remove deadlines from CommonTestUtils
Posted by GitBox <gi...@apache.org>.
XComp commented on pull request #19116:
URL: https://github.com/apache/flink/pull/19116#issuecomment-1072328700
@zentol There's still something odd with `DefaultLeaderRetrievalServiceTest`. Have you looked into the CI error?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19116: [FLINK-26616][tests] Remove deadlines from CommonTestUtils
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19116:
URL: https://github.com/apache/flink/pull/19116#issuecomment-1069128888
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ce239101f1da9f768fd1b0857392a57cc4aed72d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33182",
"triggerID" : "ce239101f1da9f768fd1b0857392a57cc4aed72d",
"triggerType" : "PUSH"
}, {
"hash" : "60ae673acad69c86c771dd1c0fd772772f38cfa8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33190",
"triggerID" : "60ae673acad69c86c771dd1c0fd772772f38cfa8",
"triggerType" : "PUSH"
}, {
"hash" : "d013f8148fa4925a984a62267d91fd6b33f13eeb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33195",
"triggerID" : "d013f8148fa4925a984a62267d91fd6b33f13eeb",
"triggerType" : "PUSH"
}, {
"hash" : "2956f30f6d565e77b74a9964a49c00d005aca5c7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33196",
"triggerID" : "2956f30f6d565e77b74a9964a49c00d005aca5c7",
"triggerType" : "PUSH"
}, {
"hash" : "72c13df14fc83f64b67e20ecae82c25dbf49e6b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33236",
"triggerID" : "72c13df14fc83f64b67e20ecae82c25dbf49e6b7",
"triggerType" : "PUSH"
}, {
"hash" : "1e5e3cab5533bf80cf20e980debe66719a960741",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33360",
"triggerID" : "1e5e3cab5533bf80cf20e980debe66719a960741",
"triggerType" : "PUSH"
}, {
"hash" : "5bbab8b28bbe2e63c46e26e609d08c48ab580364",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5bbab8b28bbe2e63c46e26e609d08c48ab580364",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1e5e3cab5533bf80cf20e980debe66719a960741 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33360)
* 5bbab8b28bbe2e63c46e26e609d08c48ab580364 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19116: [FLINK-26616][tests] Remove deadlines from CommonTestUtils
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19116:
URL: https://github.com/apache/flink/pull/19116#issuecomment-1069128888
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ce239101f1da9f768fd1b0857392a57cc4aed72d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33182",
"triggerID" : "ce239101f1da9f768fd1b0857392a57cc4aed72d",
"triggerType" : "PUSH"
}, {
"hash" : "60ae673acad69c86c771dd1c0fd772772f38cfa8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "60ae673acad69c86c771dd1c0fd772772f38cfa8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ce239101f1da9f768fd1b0857392a57cc4aed72d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33182)
* 60ae673acad69c86c771dd1c0fd772772f38cfa8 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19116: [FLINK-26616][tests] Remove deadlines from CommonTestUtils
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19116:
URL: https://github.com/apache/flink/pull/19116#issuecomment-1069128888
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ce239101f1da9f768fd1b0857392a57cc4aed72d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33182",
"triggerID" : "ce239101f1da9f768fd1b0857392a57cc4aed72d",
"triggerType" : "PUSH"
}, {
"hash" : "60ae673acad69c86c771dd1c0fd772772f38cfa8",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33190",
"triggerID" : "60ae673acad69c86c771dd1c0fd772772f38cfa8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ce239101f1da9f768fd1b0857392a57cc4aed72d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33182)
* 60ae673acad69c86c771dd1c0fd772772f38cfa8 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33190)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19116: [FLINK-26616][tests] Remove deadlines from CommonTestUtils
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19116:
URL: https://github.com/apache/flink/pull/19116#issuecomment-1069128888
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ce239101f1da9f768fd1b0857392a57cc4aed72d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33182",
"triggerID" : "ce239101f1da9f768fd1b0857392a57cc4aed72d",
"triggerType" : "PUSH"
}, {
"hash" : "60ae673acad69c86c771dd1c0fd772772f38cfa8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33190",
"triggerID" : "60ae673acad69c86c771dd1c0fd772772f38cfa8",
"triggerType" : "PUSH"
}, {
"hash" : "d013f8148fa4925a984a62267d91fd6b33f13eeb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33195",
"triggerID" : "d013f8148fa4925a984a62267d91fd6b33f13eeb",
"triggerType" : "PUSH"
}, {
"hash" : "2956f30f6d565e77b74a9964a49c00d005aca5c7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33196",
"triggerID" : "2956f30f6d565e77b74a9964a49c00d005aca5c7",
"triggerType" : "PUSH"
}, {
"hash" : "72c13df14fc83f64b67e20ecae82c25dbf49e6b7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33236",
"triggerID" : "72c13df14fc83f64b67e20ecae82c25dbf49e6b7",
"triggerType" : "PUSH"
}, {
"hash" : "1e5e3cab5533bf80cf20e980debe66719a960741",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1e5e3cab5533bf80cf20e980debe66719a960741",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 72c13df14fc83f64b67e20ecae82c25dbf49e6b7 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33236)
* 1e5e3cab5533bf80cf20e980debe66719a960741 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19116: [FLINK-26616][tests] Remove deadlines from CommonTestUtils
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19116:
URL: https://github.com/apache/flink/pull/19116#issuecomment-1069128888
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ce239101f1da9f768fd1b0857392a57cc4aed72d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33182",
"triggerID" : "ce239101f1da9f768fd1b0857392a57cc4aed72d",
"triggerType" : "PUSH"
}, {
"hash" : "60ae673acad69c86c771dd1c0fd772772f38cfa8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33190",
"triggerID" : "60ae673acad69c86c771dd1c0fd772772f38cfa8",
"triggerType" : "PUSH"
}, {
"hash" : "d013f8148fa4925a984a62267d91fd6b33f13eeb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33195",
"triggerID" : "d013f8148fa4925a984a62267d91fd6b33f13eeb",
"triggerType" : "PUSH"
}, {
"hash" : "2956f30f6d565e77b74a9964a49c00d005aca5c7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33196",
"triggerID" : "2956f30f6d565e77b74a9964a49c00d005aca5c7",
"triggerType" : "PUSH"
}, {
"hash" : "72c13df14fc83f64b67e20ecae82c25dbf49e6b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33236",
"triggerID" : "72c13df14fc83f64b67e20ecae82c25dbf49e6b7",
"triggerType" : "PUSH"
}, {
"hash" : "1e5e3cab5533bf80cf20e980debe66719a960741",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33360",
"triggerID" : "1e5e3cab5533bf80cf20e980debe66719a960741",
"triggerType" : "PUSH"
}, {
"hash" : "5bbab8b28bbe2e63c46e26e609d08c48ab580364",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33490",
"triggerID" : "5bbab8b28bbe2e63c46e26e609d08c48ab580364",
"triggerType" : "PUSH"
}, {
"hash" : "8b28c8df7c96a3bab4cdfc30ff45d4912ce048b1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33615",
"triggerID" : "8b28c8df7c96a3bab4cdfc30ff45d4912ce048b1",
"triggerType" : "PUSH"
}, {
"hash" : "82bf6b61e372f2cd1f8eef0429f4d134df1e257e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33616",
"triggerID" : "82bf6b61e372f2cd1f8eef0429f4d134df1e257e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 82bf6b61e372f2cd1f8eef0429f4d134df1e257e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33616)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19116: [FLINK-26616][tests] Remove deadlines from CommonTestUtils
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19116:
URL: https://github.com/apache/flink/pull/19116#issuecomment-1069128888
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ce239101f1da9f768fd1b0857392a57cc4aed72d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33182",
"triggerID" : "ce239101f1da9f768fd1b0857392a57cc4aed72d",
"triggerType" : "PUSH"
}, {
"hash" : "60ae673acad69c86c771dd1c0fd772772f38cfa8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33190",
"triggerID" : "60ae673acad69c86c771dd1c0fd772772f38cfa8",
"triggerType" : "PUSH"
}, {
"hash" : "d013f8148fa4925a984a62267d91fd6b33f13eeb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33195",
"triggerID" : "d013f8148fa4925a984a62267d91fd6b33f13eeb",
"triggerType" : "PUSH"
}, {
"hash" : "2956f30f6d565e77b74a9964a49c00d005aca5c7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33196",
"triggerID" : "2956f30f6d565e77b74a9964a49c00d005aca5c7",
"triggerType" : "PUSH"
}, {
"hash" : "72c13df14fc83f64b67e20ecae82c25dbf49e6b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33236",
"triggerID" : "72c13df14fc83f64b67e20ecae82c25dbf49e6b7",
"triggerType" : "PUSH"
}, {
"hash" : "1e5e3cab5533bf80cf20e980debe66719a960741",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33360",
"triggerID" : "1e5e3cab5533bf80cf20e980debe66719a960741",
"triggerType" : "PUSH"
}, {
"hash" : "5bbab8b28bbe2e63c46e26e609d08c48ab580364",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33490",
"triggerID" : "5bbab8b28bbe2e63c46e26e609d08c48ab580364",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5bbab8b28bbe2e63c46e26e609d08c48ab580364 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33490)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19116: [FLINK-26616][tests] Remove deadlines from CommonTestUtils
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19116:
URL: https://github.com/apache/flink/pull/19116#issuecomment-1069128888
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ce239101f1da9f768fd1b0857392a57cc4aed72d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33182",
"triggerID" : "ce239101f1da9f768fd1b0857392a57cc4aed72d",
"triggerType" : "PUSH"
}, {
"hash" : "60ae673acad69c86c771dd1c0fd772772f38cfa8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33190",
"triggerID" : "60ae673acad69c86c771dd1c0fd772772f38cfa8",
"triggerType" : "PUSH"
}, {
"hash" : "d013f8148fa4925a984a62267d91fd6b33f13eeb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33195",
"triggerID" : "d013f8148fa4925a984a62267d91fd6b33f13eeb",
"triggerType" : "PUSH"
}, {
"hash" : "2956f30f6d565e77b74a9964a49c00d005aca5c7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33196",
"triggerID" : "2956f30f6d565e77b74a9964a49c00d005aca5c7",
"triggerType" : "PUSH"
}, {
"hash" : "72c13df14fc83f64b67e20ecae82c25dbf49e6b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33236",
"triggerID" : "72c13df14fc83f64b67e20ecae82c25dbf49e6b7",
"triggerType" : "PUSH"
}, {
"hash" : "1e5e3cab5533bf80cf20e980debe66719a960741",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33360",
"triggerID" : "1e5e3cab5533bf80cf20e980debe66719a960741",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1e5e3cab5533bf80cf20e980debe66719a960741 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33360)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol merged pull request #19116: [FLINK-26616][tests] Remove deadlines from CommonTestUtils
Posted by GitBox <gi...@apache.org>.
zentol merged pull request #19116:
URL: https://github.com/apache/flink/pull/19116
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org