You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/07/15 05:53:36 UTC

[GitHub] [shardingsphere] TeslaCN commented on a diff in pull request #19188: make VERSION() support alias

TeslaCN commented on code in PR #19188:
URL: https://github.com/apache/shardingsphere/pull/19188#discussion_r921834697


##########
shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/text/admin/mysql/executor/ShowVersionExecutor.java:
##########
@@ -39,15 +43,31 @@ public final class ShowVersionExecutor implements DatabaseAdminQueryExecutor {
     
     public static final String FUNCTION_NAME = "version()";
     
+    private SelectStatement sqlStatement;

Review Comment:
   Could we make it final and use `@RequiredArgsConstructor`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org