You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Philip Martin <ph...@codematters.co.uk> on 2005/04/08 23:58:12 UTC

ra_local unitialised variable with locks

$ rm -rf repo wc
$ svnadmin create repo
$ svn import Makefile file://`pwd`/repo/foo -m ""
$ svn co file://`pwd`/repo wc
$ svn lock wc/foo -m ""

$ valgrind -q svn rm --username "" -m "" file://`pwd`/repo/foo
==31509== Conditional jump or move depends on uninitialised value(s)
==31509==    at 0x1B9B6623: verify_lock (lock.c:644)
==31509==    by 0x1B9B67C2: get_locks_callback (lock.c:674)
==31509==    by 0x1B9B64DB: walk_digest_files (lock.c:612)
==31509==    by 0x1B9B7166: svn_fs_fs__get_locks (lock.c:975)
==31509==    by 0x1B9B681B: svn_fs_fs__allow_locked_operation (lock.c:689)
==31509==    by 0x1B9BA5A5: fs_delete_node (tree.c:1893)
==31509==    by 0x1B99E650: svn_fs_delete (fs-loader.c:671)
==31509==    by 0x1B97CA8F: delete_entry (commit.c:223)
==31509==    by 0x1B916B08: path_driver_cb_func (delete.c:107)
==31509==    by 0x1BA21E96: svn_delta_path_driver (path_driver.c:243)
==31509==    by 0x1B916F03: delete_urls (delete.c:195)
==31509==    by 0x1B917067: svn_client_delete (delete.c:247)
../svn/subversion/libsvn_fs_fs/lock.c:645: (apr_err=160034)
svn: Cannot verify lock on path '/foo'; no username available

-- 
Philip Martin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: ra_local unitialised variable with locks

Posted by Philip Martin <ph...@codematters.co.uk>.
"Peter N. Lundblad" <pe...@famlundblad.se> writes:

> On Sat, 9 Apr 2005, Philip Martin wrote:
>
>>
>> $ rm -rf repo wc
>> $ svnadmin create repo
>> $ svn import Makefile file://`pwd`/repo/foo -m ""
>> $ svn co file://`pwd`/repo wc
>> $ svn lock wc/foo -m ""
>>
>> $ valgrind -q svn rm --username "" -m "" file://`pwd`/repo/foo
>> ==31509== Conditional jump or move depends on uninitialised value(s)
>> ==31509==    at 0x1B9B6623: verify_lock (lock.c:644)
> ...
>
> Could you try r14061? It should cure this uninitialized struct member.
> I'll propose for backport after your confirmation.

I'm using trunk r14067, the problem is fixed.

-- 
Philip Martin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: ra_local unitialised variable with locks

Posted by "Peter N. Lundblad" <pe...@famlundblad.se>.
On Sat, 9 Apr 2005, Philip Martin wrote:

>
> $ rm -rf repo wc
> $ svnadmin create repo
> $ svn import Makefile file://`pwd`/repo/foo -m ""
> $ svn co file://`pwd`/repo wc
> $ svn lock wc/foo -m ""
>
> $ valgrind -q svn rm --username "" -m "" file://`pwd`/repo/foo
> ==31509== Conditional jump or move depends on uninitialised value(s)
> ==31509==    at 0x1B9B6623: verify_lock (lock.c:644)
...

Could you try r14061? It should cure this uninitialized struct member.
I'll propose for backport after your confirmation.

Thanks,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org